mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-15 20:22:07 +00:00
d656f0f4ec
## About The Pull Request So, some admin verbs/tools that used tguis, i.e edit/debug planes, were available to admins with +DEBUG... but the ui_state used `GLOB.admin_state`, which checks for +ADMIN - meaning that if they _only_ had +DEBUG, they would have the verb... but it would do nothing when they used it. I've refactored `GLOB.admin_state`, `GLOB.debug_state`, and `GLOB.fun_state` into a merged `/datum/ui_state/admin_state`, with a var for which specific permissions are being checked for. You now use the `ADMIN_STATE(perms)` macro to get the UI state for those specific perms, i.e `admin_state(R_ADMIN)` or `admin_state(R_DEBUG)`, and the resulting UI state will check for _those specific perms_. These are initialized and cached in `GLOB.admin_states` (which should never be directly accessed). So, I've went thru every single usage of `GLOB.admin_state`, `GLOB.fun_state`, and `GLOB.debug_state`, and made them all use `ADMIN_STATE()` with the actual permission flags needed to use said UI in the first place. ## Why It's Good For The Game Kinda dumb for specific admin permissions to be granted verbs that don't let them use it anyways. ## Changelog 🆑 admin: Certain UI-based tools (plane debugger, filter editor, etc) that were given to admins with only +VAREDIT or +DEBUG, but refused to open without +ADMIN, now actually work for admins that have the needed permission. /🆑
95 lines
2.8 KiB
Plaintext
95 lines
2.8 KiB
Plaintext
|
|
ADMIN_VERB(message_pda, R_ADMIN, "PDA Message", "Send a message to a user's PDA.", ADMIN_CATEGORY_EVENTS)
|
|
user.holder.message_pda()
|
|
|
|
///Opens up the PDA Message Panel
|
|
/datum/admins/proc/message_pda()
|
|
if(!check_rights(R_ADMIN))
|
|
return
|
|
|
|
if(!length(GLOB.pda_messengers))
|
|
to_chat(usr, span_warning("ERROR: There are no users you can send a message to"))
|
|
return
|
|
|
|
var/datum/admin_pda_panel/ui = new(usr)
|
|
ui.ui_interact(usr)
|
|
|
|
/// Panel
|
|
/datum/admin_pda_panel
|
|
|
|
/datum/admin_pda_panel/ui_interact(mob/user, datum/tgui/ui)
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "AdminPDA")
|
|
ui.open()
|
|
|
|
/datum/admin_pda_panel/ui_state(mob/user)
|
|
return ADMIN_STATE(R_ADMIN)
|
|
|
|
/datum/admin_pda_panel/ui_static_data(mob/user)
|
|
var/list/data = list()
|
|
var/list/available_messengers = list()
|
|
for(var/messenger_ref in get_messengers_sorted_by_name())
|
|
var/datum/computer_file/program/messenger/messenger = GLOB.pda_messengers[messenger_ref]
|
|
available_messengers[REF(messenger)] = list(
|
|
ref = REF(messenger),
|
|
username = get_messenger_name(messenger),
|
|
invisible = messenger.invisible,
|
|
)
|
|
data["users"] = available_messengers
|
|
return data
|
|
|
|
/datum/admin_pda_panel/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
|
|
if(..())
|
|
return
|
|
|
|
if(!check_rights(R_ADMIN))
|
|
return
|
|
|
|
switch(action)
|
|
if("sendMessage")
|
|
var/targets = list()
|
|
var/spam = params["spam"]
|
|
var/ref = params["ref"]
|
|
var/force = params["force"]
|
|
if(!spam && (ref in GLOB.pda_messengers))
|
|
targets += GLOB.pda_messengers[ref]
|
|
else
|
|
for(var/messenger_ref in get_messengers_sorted_by_name())
|
|
var/datum/computer_file/program/messenger/messenger = GLOB.pda_messengers[messenger_ref]
|
|
if(messenger.invisible && !params["include_invisible"])
|
|
continue
|
|
targets += messenger
|
|
|
|
if(!length(targets))
|
|
to_chat(usr, span_warning("ERROR: Target is unavailable."))
|
|
return FALSE
|
|
|
|
var/datum/signal/subspace/messaging/tablet_message/signal = new(null, list(
|
|
"fakename" = params["name"],
|
|
"fakejob" = params["job"],
|
|
"message" = params["message"],
|
|
"everyone" = spam,
|
|
"ref" = null,
|
|
"targets" = targets,
|
|
"rigged" = FALSE,
|
|
"automated" = FALSE,
|
|
))
|
|
|
|
if(force)
|
|
signal.broadcast()
|
|
else
|
|
signal.levels = SSmapping.levels_by_trait(ZTRAIT_STATION)
|
|
signal.send_to_receivers()
|
|
|
|
if(!(force || signal.data["reject"]))
|
|
to_chat(usr, span_warning("ERROR: PDA message was rejected by the telecomms setup."))
|
|
return FALSE
|
|
|
|
var/recipient = spam ? "everyone" : get_messenger_name(targets[1])
|
|
|
|
message_admins("[key_name_admin(usr)] sent a custom PDA message to [recipient].")
|
|
log_admin("[key_name(usr)] sent a custom PDA message to [recipient]. Message: [params["message"]].")
|
|
log_pda("[key_name(usr)] sent an admin custom PDA message to [recipient]. Message: [params["message"]]")
|
|
return TRUE
|