mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
e65a48e91f
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761) Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks. Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work. This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping. To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway. Requested by @optimumtact. Changelog cl admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again. /cl * Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
26 lines
847 B
Plaintext
26 lines
847 B
Plaintext
// This is just a bit of fun while making an example for global signal
|
|
/datum/component/edit_complainer
|
|
var/list/say_lines
|
|
|
|
/datum/component/edit_complainer/Initialize(list/text)
|
|
if(!ismovable(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
|
|
var/static/list/default_lines = list(
|
|
"CentCom's profligacy frays another thread.",
|
|
"Another tug at the weave.",
|
|
"Who knows when the stresses will finally shatter the form?",
|
|
"Even now a light shines through the cracks.",
|
|
"CentCom once more twists knowledge beyond its authority.",
|
|
"There is an uncertain air in the mansus.",
|
|
)
|
|
say_lines = text || default_lines
|
|
|
|
RegisterSignal(SSdcs, COMSIG_GLOB_VAR_EDIT, .proc/var_edit_react)
|
|
|
|
/datum/component/edit_complainer/proc/var_edit_react(datum/source, list/arguments)
|
|
SIGNAL_HANDLER
|
|
|
|
var/atom/movable/master = parent
|
|
master.say(pick(say_lines))
|