mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-03 04:49:26 +00:00
## About The Pull Request After months of preparation, and further months of work, I am finally done. Please bear with me, as this is a massive refactor, but I have already atomized everything I could. This is now ready for review. General - The hilbert hotel slimes are now a subtype instead of a varedit. - The `use_mob_ability` subtree now also accepts non cooldown abilities. If set_behaviours is set up properly, mobs won't keep continously triggering it as if it were a 0 second cooldown action. The alternative would have been turning the slime abilities into cooldown abilities. - Wrestling off a slime now signs up to the `COMSIG_ATOM_ATTACK_HAND` signal, instead of being part of attack_hand. - Adds datum/ai_controller/controller as a fourth, optional argument to `/datum/ai_behavior/find_hunt_target/valid_dinner()` to make it possible to access blackboard keys. - Slimes no longer attack windows if they would accidentally move into them (when the conditions are met), since random walk behaviour ignores tiles they can't go in. It was also not worth to keep. Did you know this was the sole override of `ObjBump()`? - Examine was made less snowflaky/bespoke. Also added a new element: `/datum/element/basic_health_examine`, which is a simple bespoke element that prints out a custom message based on how damaged the basic mob it is attached to is. - Slimes only perform knockdown instead of paralysis, as they can attack more often now, and paralysis is not that fun. - LAssailant has been removed due being archaic code. To befriend a slime, you have to spawn a monkey with the slime console, or feed them a sheet of plasma. Simple grabbing the monkey or stuffing them in disposals do not work anymore. Slime console spawned monkeys will have a visible status effect, with pheromones coming off them to make this clearer. Actions - Feeding, reproduction and evolution is no longer a verb. - Slime feeding is no longer an action button. You have to use right click, or as previously, mousedrop. Slimes can always unbuckle from mobs they are attached to. Hunger - Instead randomly changing the starvation and max nutrition values while growing up, evolution costs 200 nutrion. This makes the code more readable, and behaviour more predictable, while still giving the intended time between evolving and splitting. As a result, I could also turn these into defines. - Added a component that handles doing an effect over time while buckled to a mob, until the mob dies or you get unbuckled. - Slimes gained nutrition is no longer randomly multiplied by the damage config value, but rather gain nutrition equal to twice the damage dealt. You'll have to eat one monkey to evolve, just as before. - Slimes do not heal passively. They only heal from eating. It was a rather miniscule value that did not have much effect. - Slimes generate electricity from hunger threshold, instead of the random amount of hunger threshold + 100. Environment - Slimes take 15 damage from cold every second, instead of using a complex formula (that also decreased the damage up to a point?). - Slimes still heal from burn damage, but this is now set on the damage coefficient list. - Slimes instead of getting stunned by the cold, freeze in an ice cube. BZ instead of setting them unconscious, calls the stasis status effect, allowing you to safely stash your hungry slimes for later. They also no longer slow down from the cold, as they are already slowed down by the damage they get. Conversely they no longer get a speed up from a random amount of temperature. I could be convinced to readd this either as part of the basic sensitive component, or a similar one. AI - Removed the attacked_stacks system. Slimes will just perform regular retaliation if you hit them in a harmful manner. - Slimes now use the pet orders component. They will interrupt their feeding when given a command by their master. - Slimes have their own subtrees. I tried to replicate as much as I could from the old code, dividing ancient code artifacts and intentional stuff, so there might be some weirdness. - Slime speech has been almost fully reduced to basic blorbing, as you can not even understand them anymore, and most of them require the slime to loop through all of their surroundings. - Discipline does not have stacks either. Disciplined baby slimes have a chance to clear their attack and hunt blackboard keys. All slimes will stop feeding on the target otherwise. - Since discipline is not a stack, rabidity instead gets removed at a 10% chance per disciplining. - Slimes faces are a bit more randomly picked now. ## Why It's Good For The Game - We want to convert all simple animals to basic mobs. Old slime code was also very strange, and had some systems that have been replicated by components. - Slimes fully paralyzing you is not fun at all. Knockdown should give you a fighting chance when a slime would like to eat you. - Slimes slow down from the heavy damage they get from the cold, so I don't think they need extra slowdown, nor do they need to speed up from warmth, as they are already fast. - Slimes turning into an icecube instead of becoming paralyzed from the cold is more fun for the slimes, as they can break out for a few moments. It is also funny. - Slimes entering proper stasis from BZ is not just a visual indicator of a slime that is safe to approach, but also keeps the slimes's hunger value in check, allowing it to not starve while stopped. They can also look around and blorble, instead of staring at a black screen, if player controlled. - The attack_stack and discipline_stack behaviours were rather overcomplicated, and the xenobio mains I talked with didn't even know it was a thing, so I argue it needed simplification. - The bespoke friendship system of slimes was also too complicated. Slimes slowly gained levels of trust, and at certain levels commands costed friendship, and other levels, they did not. The binary friend/not friend system that everything else in the game uses is much more sensible. - Using right click for feeding is much more sensible than using an action, and then picking someone from a dropdown. - Slime speech was very soulful but not only did it loop through everything in sight, you couldn't even understand it unless you spoke slime. Maybe it can be readded later in a different form. - Slime's passive healing was miniscule, and having them rely on feeding is more interesting. also fixes #81463 ## Changelog 🆑 refactor: Slimes are now basic mobs. Please report any strange behaviours! balance: Slimes only stun you for two seconds when they shock you, the rest of the duration is a knockdown. balance: Slimes are not stunned from the cold, but rather, get frozen in a freon icecube. BZ also puts them in complete stasis, instead of making them unconscious. Their speed is likewise unchanged by temperatures. balance: Slimes do not passively heal, they instead rely on feeding. fix: Slimes can use the buckling screen alert to unbuckle and stop feeding, along with clicking on the mob they are riding /🆑
200 lines
7.6 KiB
Plaintext
200 lines
7.6 KiB
Plaintext
/**
|
|
* The mob, usually meant to be a creature of some type
|
|
*
|
|
* Has a client attached that is a living person (most of the time), although I have to admit
|
|
* sometimes it's hard to tell they're sentient
|
|
*
|
|
* Has a lot of the creature game world logic, such as health etc
|
|
*/
|
|
/mob
|
|
density = TRUE
|
|
layer = MOB_LAYER
|
|
animate_movement = SLIDE_STEPS
|
|
hud_possible = list(ANTAG_HUD)
|
|
pressure_resistance = 8
|
|
mouse_drag_pointer = MOUSE_ACTIVE_POINTER
|
|
throwforce = 10
|
|
blocks_emissive = EMISSIVE_BLOCK_GENERIC
|
|
pass_flags_self = PASSMOB
|
|
// we never want to hide a turf because it's not lit
|
|
// We can rely on the lighting plane to handle that for us
|
|
see_in_dark = 1e6
|
|
// A list of factions that this mob is currently in, for hostile mob targeting, amongst other things
|
|
faction = list(FACTION_NEUTRAL)
|
|
/// The current client inhabiting this mob. Managed by login/logout
|
|
/// This exists so we can do cleanup in logout for occasions where a client was transfere rather then destroyed
|
|
/// We need to do this because the mob on logout never actually has a reference to client
|
|
/// We also need to clear this var/do other cleanup in client/Destroy, since that happens before logout
|
|
/// HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
|
|
var/client/canon_client
|
|
|
|
var/shift_to_open_context_menu = TRUE
|
|
|
|
/// Percentage of how much rgb to max the lighting plane at
|
|
/// This lets us brighten it without washing out color
|
|
/// Scale from 0-100, reset off update_sight()
|
|
var/lighting_cutoff = LIGHTING_CUTOFF_VISIBLE
|
|
// Individual color max for red, we can use this to color darkness without tinting the light
|
|
var/lighting_cutoff_red = 0
|
|
// Individual color max for green, we can use this to color darkness without tinting the light
|
|
var/lighting_cutoff_green = 0
|
|
// Individual color max for blue, we can use this to color darkness without tinting the light
|
|
var/lighting_cutoff_blue = 0
|
|
/// A list of red, green and blue cutoffs
|
|
/// This is what actually gets applied to the mob, it's modified by things like glasses
|
|
var/list/lighting_color_cutoffs = null
|
|
var/datum/mind/mind
|
|
var/static/next_mob_id = 0
|
|
|
|
/// List of movement speed modifiers applying to this mob
|
|
var/list/movespeed_modification //Lazy list, see mob_movespeed.dm
|
|
/// List of movement speed modifiers ignored by this mob. List -> List (id) -> List (sources)
|
|
var/list/movespeed_mod_immunities //Lazy list, see mob_movespeed.dm
|
|
/// The calculated mob speed slowdown based on the modifiers list
|
|
var/cached_multiplicative_slowdown
|
|
/// List of action speed modifiers applying to this mob
|
|
var/list/actionspeed_modification //Lazy list, see mob_movespeed.dm
|
|
/// List of action speed modifiers ignored by this mob. List -> List (id) -> List (sources)
|
|
var/list/actionspeed_mod_immunities //Lazy list, see mob_movespeed.dm
|
|
/// The calculated mob action speed slowdown based on the modifiers list
|
|
var/cached_multiplicative_actions_slowdown
|
|
/// List of action hud items the user has
|
|
var/list/datum/action/actions
|
|
///Cursor icon used when holding shift over things
|
|
var/examine_cursor_icon = 'icons/effects/mouse_pointers/examine_pointer.dmi'
|
|
|
|
/// Whether a mob is alive or dead. TODO: Move this to living - Nodrak (2019, still here)
|
|
var/stat = CONSCIOUS
|
|
|
|
/* A bunch of this stuff really needs to go under their own defines instead of being globally attached to mob.
|
|
A variable should only be globally attached to turfs/objects/whatever, when it is in fact needed as such.
|
|
The current method unnecessarily clusters up the variable list, especially for humans (although rearranging won't really clean it up a lot but the difference will be noticable for other mobs).
|
|
I'll make some notes on where certain variable defines should probably go.
|
|
Changing this around would probably require a good look-over the pre-existing code.
|
|
*/
|
|
|
|
/// The zone this mob is currently targeting
|
|
var/zone_selected = BODY_ZONE_CHEST
|
|
|
|
var/computer_id = null
|
|
var/list/logging = list()
|
|
|
|
/// The machine the mob is interacting with (this is very bad old code btw)
|
|
var/obj/machinery/machine = null
|
|
|
|
/// Tick time the mob can next move
|
|
var/next_move = null
|
|
|
|
/// What is the mobs real name (name is overridden for disguises etc)
|
|
var/real_name = null
|
|
|
|
|
|
/// Default body temperature
|
|
var/bodytemperature = BODYTEMP_NORMAL //310.15K / 98.6F
|
|
/// Our body temperatue as of the last process, prevents pointless work when handling alerts
|
|
var/old_bodytemperature = 0
|
|
|
|
/// Hunger level of the mob
|
|
var/nutrition = NUTRITION_LEVEL_START_MIN // randomised in Initialize
|
|
/// Satiation level of the mob
|
|
var/satiety = 0//Carbon
|
|
|
|
/// How many ticks this mob has been over reating
|
|
var/overeatduration = 0 // How long this guy is overeating //Carbon
|
|
|
|
/// The last known IP of the client who was in this mob
|
|
var/lastKnownIP = null
|
|
|
|
/// movable atom we are buckled to
|
|
var/atom/movable/buckled = null//Living
|
|
|
|
//Hands
|
|
///What hand is the active hand
|
|
var/active_hand_index = 1
|
|
/**
|
|
* list of items held in hands
|
|
*
|
|
* len = number of hands, eg: 2 nulls is 2 empty hands, 1 item and 1 null is 1 full hand
|
|
* and 1 empty hand.
|
|
*
|
|
* NB: contains nulls!
|
|
*
|
|
* `held_items[active_hand_index]` is the actively held item, but please use
|
|
* [get_active_held_item()][/mob/proc/get_active_held_item] instead, because OOP
|
|
*/
|
|
var/list/held_items = list()
|
|
|
|
//HUD things
|
|
|
|
/// Storage component (for mob inventory)
|
|
var/datum/storage/active_storage
|
|
/// Active hud
|
|
var/datum/hud/hud_used = null
|
|
|
|
/// Is the mob throw intent on
|
|
var/throw_mode = THROW_MODE_DISABLED
|
|
|
|
/// What job does this mob have
|
|
var/job = null//Living
|
|
|
|
/// Can this mob enter shuttles
|
|
var/move_on_shuttle = 1
|
|
|
|
/// bitflags defining which status effects can be inflicted (replaces canknockdown, canstun, etc)
|
|
var/status_flags = CANSTUN|CANKNOCKDOWN|CANUNCONSCIOUS|CANPUSH
|
|
|
|
/// Can they interact with station electronics
|
|
var/has_unlimited_silicon_privilege = FALSE
|
|
|
|
///Calls relay_move() to whatever this is set to when the mob tries to move
|
|
var/atom/movable/remote_control
|
|
|
|
///the current turf being examined in the stat panel
|
|
var/turf/listed_turf = null
|
|
|
|
///The list of people observing this mob.
|
|
var/list/observers = null
|
|
|
|
///List of progress bars this mob is currently seeing for actions
|
|
var/list/progressbars = null //for stacking do_after bars
|
|
|
|
///For storing what do_after's someone has, key = string, value = amount of interactions of that type happening.
|
|
var/list/do_afters
|
|
|
|
///Allows a datum to intercept all click calls this mob is the source of
|
|
var/datum/click_intercept
|
|
|
|
///THe z level this mob is currently registered in
|
|
var/registered_z = null
|
|
|
|
var/memory_throttle_time = 0
|
|
|
|
/// Contains [/atom/movable/screen/alert] only.
|
|
///
|
|
/// On [/mob] so clientless mobs will throw alerts properly.
|
|
var/list/alerts = list()
|
|
var/list/screens = list()
|
|
var/list/client_colours = list()
|
|
var/hud_type = /datum/hud
|
|
|
|
var/datum/focus //What receives our keyboard inputs. src by default
|
|
|
|
/// Used for tracking last uses of emotes for cooldown purposes
|
|
var/list/emotes_used
|
|
|
|
///Whether the mob is updating glide size when movespeed updates or not
|
|
var/updating_glide_size = TRUE
|
|
|
|
///Override for sound_environments. If this is set the user will always hear a specific type of reverb (Instead of the area defined reverb)
|
|
var/sound_environment_override = SOUND_ENVIRONMENT_NONE
|
|
|
|
/// A mock client, provided by tests and friends
|
|
var/datum/client_interface/mock_client
|
|
|
|
var/interaction_range = 0 //how far a mob has to be to interact with something without caring about obsctruction, defaulted to 0 tiles
|
|
|
|
///the icon currently used for the typing indicator's bubble
|
|
var/active_typing_indicator
|
|
///the icon currently used for the thinking indicator's bubble
|
|
var/active_thinking_indicator
|