mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-26 00:51:23 +00:00
e4ca3c8529
* Fake nuclear authentication disks now have a placebo keep_me_secure component (making them more convincing) (#73890) ## About The Pull Request In #73453, we were given the `keep_me_secure` component. Something I think was long overdue, really. However, it came at a terrible price... <details> <summary>The Lore</summary> Tell me, John Assistant with absolutely no disk verifier skillchip, which nuclear authentication disk is real?  The one on the plastitanium glass table?  The one on the titanium glass table?  Or the one on the reinforced plasma glass table?  The one on the plastitanium glass table you say?  B-but how did you know?! </details> tldr: Anyone can tell the real disk apart from fakes because only the real one has the `keep_me_secure` component examine message! This PR fixes that by adding the `keep_me_secure` component to fake disks. It won't actually do anything - and I added a check to `keep_me_secure` so it won't process if there are no callbacks passed, avoiding Free Lag. This just gives the fake disks the same examine message as the disk, so it won't be so obvious. ## Why It's Good For The Game Bugfix good. Futureproofing good. Fake disk noob trap bad. Disk verifier skillchip should actually do something. ## Changelog 🆑 fix: Fake nuclear authentication disks have been updated to include the holographic security sticker found on the real disk, one again making them convincingly real to the average person. code: The keep_me_secured component will now only process if it has at least one callback argument passed. /🆑 * Fake nuclear authentication disks now have a placebo keep_me_secure component (making them more convincing) --------- Co-authored-by: Vladin Heir <44104681+VladinXXV@users.noreply.github.com>
Datum Component System (DCS)
Concept
Loosely adapted from /vg/. This is an entity component system for adding behaviours to datums when inheritance doesn't quite cut it. By using signals and events instead of direct inheritance, you can inject behaviours without hacky overloads. It requires a different method of thinking, but is not hard to use correctly. If a behaviour can have application across more than one thing. Make it generic, make it a component. Atom/mob/obj event? Give it a signal, and forward it's arguments with a SendSignal() call. Now every component that want's to can also know about this happening.