mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-28 18:11:16 +00:00
e7190d1ef4
* Fixes several issues and a runtime with paper cutters (#76131) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Was meant to just fix a runtime in the context screentips for papercutters but now I've got several things fixed: - Fixes context tips runtiming - Fixes some context tips that just didnt ever appear - Fixes the icons not updating when removing papers/blades - Moves the blade to an overlay - Adds a list of blocked paper types that don't fit: paperslips, NSpect inspections, calling cards, pamphlets, and sparring contracts - Fixes papers and blades not actually removing when removed - Fixes being able to add papers when one is already inside <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Fixes https://github.com/tgstation/tgstation/assets/76465278/c30127d3-24b0-4a1d-8272-76af68b24469 <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> 🆑 fix: fixed the context tips on papercutters fix: fixes papercutters not properly updating their icons, removing their stored papers/blades, and eating papers when one is already stored /🆑 <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Fixes several issues and a runtime with paper cutters --------- Co-authored-by: OrionTheFox <76465278+OrionTheFox@users.noreply.github.com>