33961776ce
* Wintercoats can now be zipped and unzipped through alt-click and separates the hood sprites from the jacket sprites (#74886) ## About The Pull Request The title says it all, really. ~~Initially, I was only going to do it for all wintercoats, but then I figured I might as well bring it down to all of `/hooded`, just so other suits could benefit from it, since that behavior came from there anyway. Does that mean that it does nothing for some of them? Yes, it does. Does that justify having another variable to tell whether or not that should be possible? In my humble opinion, not really, but I'm not against it if it's requested.~~ ~~That functionality was intentionally removed from the Void Cloak, as there would be balance implications (since bringing up the hood makes the whole cloak invisible, which you could skirt by just "zipping" it, which also makes it invisible.~~ ~~The sprites were already there, so this change was very simple to do. Simply unties the zipped up look from the fact that the hood is up. However, toggling the hood forces the zipping/unzipping, just so there's no balance implications involved. It's just simpler that way.~~ So, I ended up going back and changing the sprites so that the hoods would no longer be baked into the jacket's sprites, so that they could be done as overlays instead, which ended up solving my problem with hoods not being there on zipped-up versions. For now, it's been made on winter coats only, but it shouldn't be that difficult to bring it back down to the `/hooded` level. I just didn't want to bother touching up the sprites down there, as it already took me like 2-3 hours touching up the sprites of the winter coats alone. I also took the decision to make it so EVA winter coats used the regular winter coat's sprites, because they had special ones that just looked like worse versions of the original, without anything special going on for them. It was just a straight downgrade compared to the base sprite, in my opinion. There's still issues with the custom winter coat, in that the hood isn't made into an overlay for it yet (and that'll require an extra bit of logic to make it work, too), but it was already an issue before, the hood is always present on the current version of the custom winter coat. There's still a handful (sadly, most) of the winter coats that don't properly reflect on their obj sprites when they're opened versus when they're closed, but that's due to an initial spriter oversight, and not to my doing. The open versions were just left as closed on many of them, and I simply don't have the patience nor the appropriate skills to edit that many coats that way. ## Why It's Good For The Game Now you can be stylish with or without the hoodie!    According to ChatGPT, with one small tweak (thanks Opera GX for the suggestion): > Zipped and unzipped through alt-click, winter coats can now be. Hmm, stylishly warm, you shall be. Feel like a Spaceman, you will. Use the Force, to zip and unzip, you must. Look cool, you will. Yes, hmmm. ## Changelog 🆑 GoldenAlpharex, ChatGPT for the first changelog entry (slightly edited) qol: Zipped and unzipped through alt-click, winter coats can now be. Hmm, stylishly warm, you shall be. Feel like a Spaceman, you will. Use the Force, to zip and unzip, you must. Look cool, you will. Yes, hmmm. image: Winter coats no longer have their hood baked into their jacket's sprite, both in item form and when worn. fix: Updated the Icebox EVA winter coats (the Endotherm winter coats) to use the same sprites as the regular winter coats. /🆑 --------- Co-authored-by: san7890 <the@ san7890.com> * Wintercoats can now be zipped and unzipped through alt-click and separates the hood sprites from the jacket sprites * update modular wintercoat.dmi * forgot --------- Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> Co-authored-by: san7890 <the@ san7890.com> Co-authored-by: ghost sheep <sheepwiththemask@gmail.com>
Greyscale Auto-Generated Sprites (GAGS)
If you're wanting to add easy recolors for your sprite then this is the system for you. Features include:
- Multiple color layers so your sprite can be generated from more than one color.
- Mixed greyscale and colored sprite layers; You can choose to only greyscale a part of the sprite or have premade filters applied to layers.
- Blend modes; Instead of just putting layers of sprites on top of eachother you can use the more advanced blend modes.
- Reusable configurations; You can reference greyscale sprites from within the configuration of another, allowing you to have a bunch of styles with minimal additional configuration.
Other Documents
Broad overview
There are three main parts to GAGS that you'll need to be aware of when adding a new greyscale sprite:
- The json configuration
All configuration files can be found in code/datums/greyscale/json_configs and is where you control how your icons are combined together along with the colors specified from in code.
- The dmi file
It contains the sprites that will be used as the basis for the rest of the generation process. You can only have one dmi file specified per configuration but if you want to split up your sprites you can reference other configurations instead.
- The configuration type
This is simply some pointers in the code linking together your dmi and the json configuration.
Json Configuration File
The json is made up of some metadata and a list of layers used while creating the sprite. Inner lists are processed as their own chunk before being applied elsewhere, this is useful when you start using more advanced blend modes. Most of the time though you're just going to want a list of icons overlaid on top of eachother.
{
"icon_state_name": [
{
"type": "reference",
"reference_type": "/datum/greyscale_config/some_other_config",
"blend_mode": "overlay",
"color_ids": [ 1 ]
},
[
{
"type": "icon_state",
"icon_state": "highlights",
"blend_mode": "overlay",
"color_ids": [ 2 ]
},
{
"type": "reference",
"reference_type": "/datum/greyscale_config/sparkle_effect",
"blend_mode": "add"
}
]
]
}
In this example, we start off by creating a sprite specified by a different configuration. The "type" key is required to specify the kind of layer you defining. Once that is done, the next two layers are grouped together, so they will be generated into one sprite before being applied to any sprites outside their group. You can think of it as an order of operations.
The first of the two in the inner group is an "icon_state", this means that the icon will be retrieved from the associated dmi file using the "icon_state" key.
The last layer is another reference type. Note that you don't need to give colors to every layer if the layer does not need any colors applied to it.
"blend_mode" and "color_ids" are special, all layer types have them. The blend mode is what controls how that layer's finished product gets merged together with the rest of the sprite. The color ids control what colors are passed in to the layer.
Once it is done generating it will be placed in an icon file with the icon state of "icon_state_name". You can use any name you like here.
Dmi File
There are no special requirements from the dmi file to work with this system. You just need to specify the icon file in code and the icon_state in the json configuration.
Dm Code
While the amount of dm code required to make a greyscale sprite was minimized as much as possible, some small amount is required anyway if you want anything to use it.
As an example:
/datum/greyscale_config/canister
icon_file = 'icons/obj/atmospherics/canisters/default.dmi'
json_config = 'code/datums/greyscale/json_configs/canister_default.json'
And that's all you need to make it usable by other code:
/obj/machinery/portable_atmospherics/canister
...
greyscale_config = /datum/greyscale_config/canister
greyscale_colors = "#ee4242"
More configurations can be found in code/datums/greyscale/greyscale_configs.dm
If you want your item to be colorable in a vending machine (or other places if there's ever any support added for that), you should do it like this:
/obj/item/clothing/head/beret
...
flags_1 = IS_PLAYER_COLORABLE_1
However, be extremely careful, as this requires that you put all of the object's flags_1 flags in that statement all over again. It's ugly, I know, but there's no
better way to do this with BYOND just yet. You can put multiple flags like this (not real flags):
/obj/item/clothing/head/beret
...
flags_1 = IS_PLAYER_COLORABLE_1 | THIS_IS_A_FAKE_FLAG | THIS_IS_ANOTHER_FAKE_FLAG
Debugging
If you're making a new greyscale sprite you sometimes want to be able to see how layers got generated or maybe you're just tweaking some colors. Rather than rebooting the server with every change there is a greyscale modification menu that can be found in the vv dropdown menu for the greyscale object. Here you can change colors, preview the results, and reload everything from their files.