Files
Bubberstation/code/modules/reagents
SkyratBot 1b18ba29b7 [MIRROR] Fixes silliness involving soup pots clearing ingredients list [MDB IGNORE] (#20700)
* Fixes silliness involving soup pots clearing ingredients list  (#74882)

## About The Pull Request

Fixes #74866

The issue is misleading, it never deleted the disk. The disk remained in
the pot's contents but was no longer tracked as an ingredient, leaving
it stuck

Foolishly I had a case for indestructible things when soup reactions
finished, where it wouldn't delete stuff like the disk.
But I never removed it from the pot. I just nulled the ingredients list.
Oops.

So pots will drop ingredients that fail to cook into anything when the
reaction finishes.

---

Semi-unrelated but stuff like stoves, ovens, and chem heater should
probably `allowdrop() return FALSE`. I cannot think of many (any)
situations where you would want to use `drop_location` from something in
an oven, stove, or heater and actually want those returned rather than
their own loc.

## Why It's Good For The Game

Whoops

## Changelog

🆑 Melbert
fix: Ingredients which fail to react in soup reactions drop when the
reaction finishes as intended
/🆑

* Fixes silliness involving soup pots clearing ingredients list

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2023-04-22 07:36:59 -07:00
..