mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-26 00:51:23 +00:00
ead6759782
## About The Pull Request In PR #76817, the damage reduction for robotic limbs was changed from being flat to being multiplicative in nature. This wasn't supposed to have secondary mechanical effects on robot limbs, but as always a few slipped by. This PR just cleans up a few of these unintended mechanical changes. First of all, the change made robotic limbs not fully immune to space damage. They remained immune to damage from pressure but not damage from temperature. Now people with only robotic limbs are immune to the temperature damage and the moodlets caused by low or high temperature. I have tested it, and it works for people who have all robotic limbs, people who have some robotic limbs and some missing, and even the extreme case of a nugget with H.A.R.S. who has nothing _but_ a robotic chest. Due to technical limitations (`apply_damage` doesn't have a `required_bodytype` argument), people with some robotic limbs and some organic will still take temperature damage on their robotic limbs. Second of all, androids are once again immune to crit damage. Normally, crit damage is just constant oxyloss, but this obviously doesn't work for species that don't breath. Instead, those species take a small amount of brute damage. Prior to the damage reduction change, this meant that Androids were effectively immune to crit damage. Now they're immune once again. Finally, you can now cancel surgery on robotic limbs. I don't think this bug was actually caused by the above PR, but I decided to fix it while I was here. Closes #77033. ## Why It's Good For The Game The damage reduction change was explicitly not intended to make robotic limbs not-spaceproof, so the first change is by definition a bugfix. As far as I know, crit damage being brute for nobreath species is a much more recent change than the existence of androids, so I think that also qualifies as a bugfix. ## Changelog 🆑 fix: Having all augmented limbs will make you properly spaceproof once again. fix: Androids are immune to crit damage again. fix: Surgery on robotic limbs can be canceled. /🆑