mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-29 18:40:42 +00:00
4f23fa137f
## About The Pull Request
1. Replaces all usages of `GLOB.chemical_name_list` with
`GLOB.name2reagent` both of these are lists that store the names of
reagents mapped to their respective typepath so the first list was
redundant. Also now `GLOB.name2reagent` has its names sorted
alphabetically & white space between words and their case preserved.
This means that
- The search button for finding reagents in the chem dispenser
- Adding reagents to the plumbing reaction chamber
- Adding reagents to plumbing chem filter
- Adding whitelist reagents to blood filter
Now **won't** display a list like this(searched for Strong Acid Buffer,
notice all space and case between words are lost)
But **will** instead display this(searched for Strong Acid Buffer,
notice all space and case between words are preserved)
Making these names much more readable.
2. In searching for all use cases of `GLOB.name2reagent` i found it was
used by 2 significant machines, the chem dispenser & portable chem
dispenser. So i took the time to clean up their code(auto doc vars, make
lists static etc etc.) and converted their UI to typescript.
3. Slightly improves performance of plumbing reagent chamber. Makes
lesser loops & hopefully gets better results
## Changelog
🆑
qol: machines/devices that ask you to pick a reagent name from an input
list have their names sorted alphabetically & preserves white space
between words making them more readable.
qol: improves performance of plumbing reaction chamber furthur
code: cleaned up code for portable chem mixer & chem dispenser.
converted their ui to typescript
/🆑