mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-06-05 22:31:04 +01:00
LemonInTheDark
ae5a4f955d
## About The Pull Request Signals were initially only usable with component listeners, which while no longer the case has lead to outdated documentation, names, and a similar location in code. This pr pulls the two apart. Partially because mso thinks we should, but also because they really aren't directly linked anymore, and having them in this midstate just confuses people. [Renames comp_lookup to listen_lookup, since that's what it does](https://github.com/tgstation/tgstation/commit/102b79694fa8eb57ecf7b36032616a9e368ccced) [Moves signal procs over to their own file](https://github.com/tgstation/tgstation/commit/33d07d01fd336726b4f6f6f1b61bb0b3f11a00dc) [Renames the PREQDELETING and QDELETING comsigs to drop the parent bit since they can hook to more then just comps now](https://github.com/tgstation/tgstation/commit/335ea4ad081ec63c42cfa05856e582cca833af6e) [Does something similar to the attackby comsigs (PARENT -> ATOM)](https://github.com/tgstation/tgstation/commit/210e57051df63f88dac3dd83321236da825aae5e) [And finally passes over the examine signals](https://github.com/tgstation/tgstation/commit/65917658fb8a1e7d28ae23c9437a583d646f0302) ## Why It's Good For The Game Code makes more sense, things are better teased apart, s just good imo ## Changelog 🆑 refactor: Pulled apart the last vestiges of names/docs directly linking signals to components /🆑
131 lines
4.3 KiB
Plaintext
131 lines
4.3 KiB
Plaintext
#define UNREADY 0
|
|
#define IDLE 1
|
|
#define READY 2
|
|
|
|
/obj/machinery/plumbing/buffer
|
|
name = "automatic buffer"
|
|
desc = "A chemical holding tank that waits for neighbouring automatic buffers to complete before allowing a withdrawal. Connect/reset by screwdrivering"
|
|
icon_state = "buffer"
|
|
pass_flags_self = PASSMACHINE | LETPASSTHROW // It looks short enough.
|
|
buffer = 200
|
|
///category for plumbing RCD
|
|
category="Synthesizers"
|
|
|
|
var/datum/buffer_net/buffer_net
|
|
var/activation_volume = 100
|
|
var/mode
|
|
|
|
/obj/machinery/plumbing/buffer/Initialize(mapload, bolt, layer)
|
|
. = ..()
|
|
|
|
AddComponent(/datum/component/plumbing/buffer, bolt, layer)
|
|
|
|
/obj/machinery/plumbing/buffer/create_reagents(max_vol, flags)
|
|
. = ..()
|
|
RegisterSignals(reagents, list(COMSIG_REAGENTS_ADD_REAGENT, COMSIG_REAGENTS_NEW_REAGENT, COMSIG_REAGENTS_REM_REAGENT, COMSIG_REAGENTS_DEL_REAGENT, COMSIG_REAGENTS_CLEAR_REAGENTS, COMSIG_REAGENTS_REACTED), PROC_REF(on_reagent_change))
|
|
RegisterSignal(reagents, COMSIG_QDELETING, PROC_REF(on_reagents_del))
|
|
|
|
/// Handles properly detaching signal hooks.
|
|
/obj/machinery/plumbing/buffer/proc/on_reagents_del(datum/reagents/reagents)
|
|
SIGNAL_HANDLER
|
|
UnregisterSignal(reagents, list(COMSIG_REAGENTS_ADD_REAGENT, COMSIG_REAGENTS_NEW_REAGENT, COMSIG_REAGENTS_REM_REAGENT, COMSIG_REAGENTS_DEL_REAGENT, COMSIG_REAGENTS_CLEAR_REAGENTS, COMSIG_REAGENTS_REACTED, COMSIG_QDELETING))
|
|
return NONE
|
|
|
|
/obj/machinery/plumbing/buffer/proc/on_reagent_change()
|
|
SIGNAL_HANDLER
|
|
if(!buffer_net)
|
|
return
|
|
if(reagents.total_volume + CHEMICAL_QUANTISATION_LEVEL >= activation_volume && mode == UNREADY)
|
|
mode = IDLE
|
|
buffer_net.check_active()
|
|
|
|
else if(reagents.total_volume + CHEMICAL_QUANTISATION_LEVEL < activation_volume && mode != UNREADY)
|
|
mode = UNREADY
|
|
buffer_net.check_active()
|
|
|
|
/obj/machinery/plumbing/buffer/update_icon()
|
|
. = ..()
|
|
icon_state = initial(icon_state)
|
|
if(buffer_net)
|
|
switch(mode)
|
|
if(UNREADY)
|
|
icon_state += "_red"
|
|
if(IDLE)
|
|
icon_state += "_yellow"
|
|
if(READY)
|
|
icon_state += "_green"
|
|
|
|
/obj/machinery/plumbing/buffer/proc/attempt_connect()
|
|
|
|
for(var/direction in GLOB.cardinals)
|
|
var/turf/T = get_step(src, direction)
|
|
for(var/atom/movable/movable in T)
|
|
if(istype(movable, /obj/machinery/plumbing/buffer))
|
|
var/obj/machinery/plumbing/buffer/neighbour = movable
|
|
if(neighbour.buffer_net != buffer_net)
|
|
neighbour.buffer_net?.destruct()
|
|
//we could put this on a proc, but its so simple I dont think its worth the overhead
|
|
buffer_net.buffer_list += neighbour
|
|
neighbour.buffer_net = buffer_net
|
|
neighbour.attempt_connect() //technically this would runtime if you made about 200~ buffers
|
|
|
|
add_overlay(icon_state + "_alert")
|
|
addtimer(CALLBACK(src, TYPE_PROC_REF(/atom/, cut_overlay), icon_state + "_alert"), 20)
|
|
|
|
/obj/machinery/plumbing/buffer/attack_hand_secondary(mob/user, modifiers)
|
|
. = ..()
|
|
if(. == SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN)
|
|
return
|
|
|
|
. = SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN
|
|
|
|
var/new_volume = tgui_input_number(user, "Enter new activation threshold", "Beepityboop", activation_volume, buffer)
|
|
if(!new_volume || QDELETED(user) || QDELETED(src) || !user.can_perform_action(src, FORBID_TELEKINESIS_REACH))
|
|
return
|
|
activation_volume = new_volume
|
|
to_chat(user, span_notice("New activation threshold is now [activation_volume]."))
|
|
return
|
|
|
|
/obj/machinery/plumbing/buffer/attackby(obj/item/item, mob/user, params)
|
|
if(item.tool_behaviour == TOOL_SCREWDRIVER)
|
|
to_chat(user, span_notice("You reset the automatic buffer."))
|
|
|
|
//reset the net
|
|
buffer_net?.destruct()
|
|
buffer_net = new()
|
|
LAZYADD(buffer_net.buffer_list, src)
|
|
|
|
attempt_connect()
|
|
else
|
|
return . = ..()
|
|
|
|
/obj/machinery/plumbing/buffer/doMove(destination)
|
|
. = ..()
|
|
buffer_net?.destruct()
|
|
|
|
/datum/buffer_net
|
|
var/list/obj/machinery/plumbing/buffer/buffer_list
|
|
|
|
/datum/buffer_net/proc/destruct()
|
|
for(var/obj/machinery/plumbing/buffer/buffer in buffer_list)
|
|
buffer.buffer_net = null
|
|
buffer_list.Cut()
|
|
qdel(src)
|
|
|
|
/datum/buffer_net/proc/check_active()
|
|
var/ready = TRUE
|
|
for(var/obj/machinery/plumbing/buffer/buffer in buffer_list)
|
|
if(buffer.mode == UNREADY)
|
|
ready = FALSE
|
|
break
|
|
for(var/obj/machinery/plumbing/buffer/buffer in buffer_list)
|
|
if(buffer.mode == READY && !ready)
|
|
buffer.mode = IDLE
|
|
else if(buffer.mode == IDLE && ready)
|
|
buffer.mode = READY
|
|
buffer.update_icon()
|
|
|
|
#undef UNREADY
|
|
#undef IDLE
|
|
#undef READY
|