mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-25 16:45:42 +00:00
ee8226b8a8
* Fixes prefilled drinking glasses, and small carton icon (#72527) Fixes a few drink container issues: - The `/obj/item/reagent_containers/cup/glass/drinkingglass/filled` subtypes runtimed whenever their reagents changed because of the strict way that `/datum/component/takes_reagent_appearance` compares container types. - `/datum/component/takes_reagent_appearance` now allows for an alternate type to check against `glass_style.required_container_type` via a var called `base_container_type`. The filled glasses now set this var to the main drinking glass type. - As well, filled glasses didn't have their appearance set up to match the corresponding glass style. Thus, the `/obj/item/reagent_containers/cup/glass/drinkingglass/filled` type now updates its appearance on initialization. - Seperately, the small carton's appearance broke if you put a reagent in that doesn't match a glass style, reverting to the "water_cup" icon state which doesn't exist in the boxes.dmi file. This is because it was a subtype of sillycup, but there is nothing gained as far as I can see from that type relationship, so the small carton was repathed to `/obj/item/reagent_containers/cup/glass/smallcarton`. * Fixes prefilled drinking glasses, and small carton icon Co-authored-by: Tastyfish <crazychris32@gmail.com>