John Willard ef1316d3ca Removing a job now removes its positions (#82015) ...

## About The Pull Request

I made the error of using the ``JOB_NEW_PLAYER_JOINABLE`` flag to
prevent people from joining as AI, unaware that it only prevents
latejoining as said job (despite ``total_positions`` also a var and
``JOB_HIDE_WHEN_EMPTY`` being a flag that you can change, making this
whole flag pointless).

## Why It's Good For The Game

Closes https://github.com/tgstation/tgstation/issues/82014

## Changelog

🆑
fix: Human AI now closes regular AI job positions.
/🆑

2024-03-16 10:17:21 +01:00

..

actionspeed

…

admin

Add compile option for compiling in MAP_TEST mode, which disables common annoyances when testing new maps (#81697)

2024-03-07 16:57:47 -05:00

antagonists

Posters return to your hand when cut down/not hung up, abductor posters more resilient to wirecutters (#81924)

2024-03-16 02:09:48 +00:00

art

…

assembly

Let's you talk through action figures, plushies, and toy mechs with .l and .r. Also a big clean up of say because its support for non-mobs was lackluster. (#81848)

2024-03-07 09:21:12 -07:00

asset_cache

…

atmospherics

[NO GBP] Several pipe cap visibility fixes (#81999)

2024-03-15 13:46:20 -06:00

autowiki

…

awaymissions

New station trait job: Human AI (#81681)

2024-03-09 23:48:39 +01:00

balloon_alert

…

basketball

…

bitrunning

Bitrunning 1.5: Secondary Objectives (#81828)

2024-03-09 22:42:23 +01:00

buildmode

…

capture_the_flag

New station trait job: Human AI (#81681)

2024-03-09 23:48:39 +01:00

cards

…

cargo

Adds a collar bomb to the black market. (#81898)

2024-03-16 01:37:10 +00:00

chatter

…

client

Feeds OOC messages back to client if blocked in validate_client() (#81769)

2024-03-06 23:13:04 +00:00

clothing

Adds a collar bomb to the black market. (#81898)

2024-03-16 01:37:10 +00:00

deathmatch

[no gbp] Lazy Templates can be configured to Place on Top, deathmatch does this now (#81783)

2024-03-04 13:40:31 +01:00

detectivework

…

discord

…

economy

…

emoji

…

emote_panel

…

error_handler

…

escape_menu

…

events

Fugitive hunter spawn delay works again (#81919)

2024-03-10 23:05:16 +01:00

experisci

…

explorer_drone

…

fishing

Fixes Spontaneous Harddel with Boned Fish Revive Ability (#81959)

2024-03-13 20:28:37 +01:00

flufftext

…

food_and_drinks

General maintenance for grilling related stuff. (#81647)

2024-03-11 02:57:23 +00:00

forensics

Fixes forensics hard del (#81880)

2024-03-08 20:06:30 +01:00

hallucination

Adds and improves logging for various shit. (#81738)

2024-03-10 19:49:26 +00:00

holiday

Adds a small cafeteria behind the right wing shutters of the museum. (#81465)

2024-03-05 18:19:39 -07:00

holodeck

…

hydroponics

Overlay Lighting Color/Intensity Pass (#81425)

2024-03-09 23:57:19 +00:00

instruments

Instrument editor now uses TGUI (#81923)

2024-03-14 18:43:05 +01:00

interview

…

jobs

Removing a job now removes its positions (#82015)

2024-03-16 10:17:21 +01:00

keybindings

…

language

…

library

Small bible / bullet catcher component code cleanup (#81835)

2024-03-05 16:37:48 -07:00

lighting

Remove 2 instances of duplicate argument names (#81757)

2024-03-01 13:52:49 -07:00

logging

Adds logging to SSore_generation on subsystem initialize (#81488)

2024-03-14 21:25:50 +00:00

mafia

…

mapfluff

Adds a small cafeteria behind the right wing shutters of the museum. (#81465)

2024-03-05 18:19:39 -07:00

mapping

…

meteors

Revamps irradiated meteor effects (#81941)

2024-03-13 23:31:18 +00:00

mining

Crushers and PKAs: Coop Upgrades (#81940)

2024-03-14 00:41:56 +00:00

mob

Skateboard tweaks and buffs. (#81928)

2024-03-16 01:37:57 +00:00

mob_spawn

Spider web graphics (#81839)

2024-03-06 16:05:49 -07:00

mod

Adds a collar bomb to the black market. (#81898)

2024-03-16 01:37:10 +00:00

modular_computers

Fix server hang in budgetordering (#81950)

2024-03-12 07:35:04 +13:00

movespeed

Makes Ephedrine not give spasms when holding a small or tiny item in your active hand, Also makes the movement speed scale with purity (#81773)

2024-03-13 02:01:33 +00:00

NTNet

…

pai

Buffs the SC/FISHER Saboteur Handgun. (#81553)

2024-03-13 22:25:29 +00:00

paperwork

Placing things in a paperbin actually plays sounds. (#81974)

2024-03-15 12:06:20 -06:00

photography

Overlay Lighting Color/Intensity Pass (#81425)

2024-03-09 23:57:19 +00:00

plumbing

…

point

…

power

Buffs the SC/FISHER Saboteur Handgun. (#81553)

2024-03-13 22:25:29 +00:00

procedural_mapping

…

projectiles

Crushers and PKAs: Coop Upgrades (#81940)

2024-03-14 00:41:56 +00:00

reagents

Removes a extra assignment (#82007)

2024-03-15 13:48:52 -06:00

recycling

New station trait job: Human AI (#81681)

2024-03-09 23:48:39 +01:00

religion

Overlay Lighting Color/Intensity Pass (#81425)

2024-03-09 23:57:19 +00:00

requests

…

research

[no gbp] fix span type errors with poll alerts (#81979)

2024-03-14 17:36:08 +00:00

security_levels

…

shuttle

New station trait job: Human AI (#81681)

2024-03-09 23:48:39 +01:00

spatial_grid

…

spells

[no GBP] Reference handling for Summon Simians (#81988)

2024-03-14 14:17:46 +01:00

station_goals

…

surgery

Overlay Lighting Color/Intensity Pass (#81425)

2024-03-09 23:57:19 +00:00

tgchat

…

tgs

Automatic TGS DMAPI Update (#81655)

2024-02-29 03:14:55 +00:00

tgui

New station trait job: Human AI (#81681)

2024-03-09 23:48:39 +01:00

tgui_input

Fixes tgui text input trimming the last char if the input hits the max length (#81869)

2024-03-07 21:20:58 -07:00

tgui_panel

…

tooltip

…

transport

New station trait job: Human AI (#81681)

2024-03-09 23:48:39 +01:00

tutorials

…

unit_tests

Adds a persistent piggy bank to the vault. (#81900)

2024-03-14 12:47:30 -05:00

uplink

[NO GBP] Fixes every single uplink getting free cybernetic implants (#81938)

2024-03-10 18:07:54 -05:00

vehicles

Skateboard tweaks and buffs. (#81928)

2024-03-16 01:37:57 +00:00

vending

Adds new vending machine tooltips. (#81918)

2024-03-15 16:32:15 -06:00

visuals

…

wiremod

Let's you talk through action figures, plushies, and toy mechs with .l and .r. Also a big clean up of say because its support for non-mobs was lackluster. (#81848)

2024-03-07 09:21:12 -07:00

zombie

…