mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-17 12:35:26 +00:00
707fc287b4
About The Pull Request
This PR removes intents and replaces them with a combat mode. An explanation of what this means can be found below
Major changes:
Disarm and Grab intents have been removed.
Harm/Help is now combat mode, toggled by F or 4 by default
The context/verb/popup menu now only works when you do shift+right-click
Right click is now disarm, both in and out of combat mode.
Grabbing is now on ctrl-click.
If you're in combat mode, and are currently grabbing/pulling someone, and ctrl-click somewhere else, it will not release the grab (To prevent misclicks)
Minor interaction changes:
Right click to dissasemble tables, racks, filing cabinets (When holding the right tool to do so)
Left click to stunbaton, right click to harmbaton
Right click to tip cows
Right click to malpractice surgery
Right click to hold people at gunpoint (if youre holding a gun)
Why It's Good For The Game
Intents heavily cripple both the code and the UI design of interactions. While I understand that a lot of people will dislike this PR as they are used to intents, they are one of our weakest links in terms of explaining to players how to do specific things, and require a lot more keypresses to do compared to this.
As an example, martial arts can now be done without having to juggle 1 2 3 and 4 to switch intents quickly.
As some of you who saw the first combat mode PR, the context menu used to be disabled in combat mode. In this version it is instead on shift-right click ensuring that you can always use it in the same way.
In this version, combat mode also no longer prevents you from attacking with items when you would so before, as this was something that was commonly complained about.
The full intention of this shift in control scheme is that right click will become "secondary interaction" for items, which prevents some of the awkward juggling we have now with item modes etcetera.
Changelog
cl Qustinnus
add: Intents have been replaced with a combat mode. For more info find the PR here: #56601
/cl
128 lines
3.4 KiB
Plaintext
128 lines
3.4 KiB
Plaintext
///?
|
|
/obj/structure/tank_holder
|
|
name = "tank holder"
|
|
desc = "A metallic frame that can hold tanks and extinguishers."
|
|
icon = 'icons/obj/tank.dmi'
|
|
icon_state = "holder"
|
|
|
|
custom_materials = list(/datum/material/iron = 2000)
|
|
|
|
density = FALSE
|
|
anchored = FALSE
|
|
pass_flags_self = LETPASSTHROW
|
|
max_integrity = 20
|
|
|
|
resistance_flags = FIRE_PROOF
|
|
|
|
/// The stored tank. If this is a path, it gets created into contents at Initialize.
|
|
var/obj/item/tank
|
|
|
|
/obj/structure/tank_holder/Initialize()
|
|
. = ..()
|
|
if(tank)
|
|
var/obj/item/tank_ = new tank(null)
|
|
tank = null
|
|
SEND_SIGNAL(tank_, COMSIG_CONTAINER_TRY_ATTACH, src, null)
|
|
|
|
/obj/structure/tank_holder/Destroy()
|
|
QDEL_NULL(tank)
|
|
return ..()
|
|
|
|
/obj/structure/tank_holder/CanAllowThrough(atom/movable/mover, turf/target)
|
|
. = ..()
|
|
if(istype(mover) && mover.throwing)
|
|
return TRUE
|
|
|
|
/obj/structure/tank_holder/examine(mob/user)
|
|
. = ..()
|
|
. += "<span class='notice'>It is held together by some <b>screws</b>.</span>"
|
|
|
|
/obj/structure/tank_holder/attackby(obj/item/W, mob/living/user, params)
|
|
if(user.combat_mode)
|
|
return ..()
|
|
if(!SEND_SIGNAL(W, COMSIG_CONTAINER_TRY_ATTACH, src, user))
|
|
to_chat(user, "<span class='warning'>[W] does not fit in [src].</span>")
|
|
|
|
/obj/structure/tank_holder/screwdriver_act(mob/living/user, obj/item/I)
|
|
if(..())
|
|
return TRUE
|
|
if(tank)
|
|
return FALSE
|
|
I.play_tool_sound(src)
|
|
deconstruct(TRUE)
|
|
return TRUE
|
|
|
|
/obj/structure/tank_holder/deconstruct(disassembled = TRUE)
|
|
var/atom/Tsec = drop_location()
|
|
new /obj/item/stack/rods(Tsec, 2)
|
|
if(tank)
|
|
tank.forceMove(Tsec)
|
|
after_detach_tank()
|
|
qdel(src)
|
|
|
|
/obj/structure/tank_holder/attack_paw(mob/user)
|
|
return attack_hand(user)
|
|
|
|
/obj/structure/tank_holder/attack_hand(mob/user)
|
|
if(!tank)
|
|
return ..()
|
|
if(!Adjacent(user) || issilicon(user))
|
|
return ..()
|
|
to_chat(user, "<span class='notice'>You take [tank] from [src].</span>")
|
|
add_fingerprint(user)
|
|
tank.add_fingerprint(user)
|
|
user.put_in_hands(tank)
|
|
after_detach_tank()
|
|
|
|
/obj/structure/tank_holder/handle_atom_del(atom/A)
|
|
if(A == tank)
|
|
after_detach_tank()
|
|
return ..()
|
|
|
|
/obj/structure/tank_holder/contents_explosion(severity, target)
|
|
if(tank)
|
|
tank.ex_act(severity, target)
|
|
|
|
/// Call this after taking the tank from contents in order to update references, icon
|
|
/// and density.
|
|
/obj/structure/tank_holder/proc/after_detach_tank()
|
|
tank = null
|
|
density = FALSE
|
|
icon_state = "holder"
|
|
|
|
/obj/structure/tank_holder/oxygen
|
|
icon_state = "holder_oxygen"
|
|
tank = /obj/item/tank/internals/oxygen
|
|
|
|
/obj/structure/tank_holder/anesthetic
|
|
icon_state = "holder_anesthetic"
|
|
tank = /obj/item/tank/internals/anesthetic
|
|
|
|
/obj/structure/tank_holder/oxygen/yellow
|
|
icon_state = "holder_oxygen_f"
|
|
tank = /obj/item/tank/internals/oxygen/yellow
|
|
|
|
/obj/structure/tank_holder/oxygen/red
|
|
icon_state = "holder_oxygen_fr"
|
|
tank = /obj/item/tank/internals/oxygen/red
|
|
|
|
/obj/structure/tank_holder/emergency_oxygen
|
|
icon_state = "holder_emergency"
|
|
tank = /obj/item/tank/internals/emergency_oxygen
|
|
|
|
/obj/structure/tank_holder/emergency_oxygen/engi
|
|
icon_state = "holder_emergency_engi"
|
|
tank = /obj/item/tank/internals/emergency_oxygen/engi
|
|
|
|
/obj/structure/tank_holder/generic
|
|
icon_state = "holder_generic"
|
|
tank = /obj/item/tank/internals/generic
|
|
|
|
/obj/structure/tank_holder/extinguisher
|
|
icon_state = "holder_extinguisher"
|
|
tank = /obj/item/extinguisher
|
|
|
|
/obj/structure/tank_holder/extinguisher/advanced
|
|
icon_state = "holder_foam_extinguisher"
|
|
tank = /obj/item/extinguisher/advanced
|