mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-26 17:11:52 +00:00
64dcf44cc6
This PR changes the message pipeline a little bit to support list-based messages, which can be annotated with custom data. Function signature of to_chat was slightly changed as well:
// Plain text message
to_chat(client,
type = MESSAGE_TYPE_INFO,
text = "foo")
// HTML message
to_chat(client,
type = MESSAGE_TYPE_INFO,
html = "<span class='notice'>foo</span>")
Old to_chat format is still supported, but handle_whitespace, trailing_newline and confidential flags have no effect. confidential flag could still be revived though, if there is enough merit in it, for example to filter out confidential messages when saving a chat log.
The reason for using /list and not /datum, is because lists are plain faster, and there are minimal data transformations - these lists are fed directly to json_encode and sent to tgchat.
Plain text messages do not need to be HTML-escaped, which makes them safer and more performant than HTML messages. Plain text messages can be made interactive (or formatted with CSS) by custom-handling them in javscript based on message type and annotations.
It would be impossible to annotate every single message in the game (at the moment of writing, there are 9447 to_chat calls in the code), but it could be done selectively, for only those messages that are hard to classify by span classes (and there are still A LOT of them).
Please annotate more messages. Thank you.
Fixes #52943
Fixes #52908
Fixes #52816
Changelog
cl
add: tgchat: Unread message count is now smarter and won't increase on other tabs if you have already read the same message in the active tab.
add: tgchat: Admin PMs are now properly annotated and can be filtered into separate tabs.
fix: tgchat: Fix: Highlighted message overlay no longer blocks clicks. Clicking a highlighted (F) link should work as it should.
fix: tgui: Fixed NTOS bluescreen due to calling .includes() on a stylesheet href which could be null on certain browsers.
code: tgchat: Chat schema bumped to version 5. All chat-related settings were reset to avoid breakage.
/cl
54 lines
2.0 KiB
Plaintext
54 lines
2.0 KiB
Plaintext
/**
|
|
* Copyright (c) 2020 Aleksej Komarov
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
/client/var/datum/tgui_panel/tgui_panel
|
|
|
|
/**
|
|
* tgui panel / chat troubleshooting verb
|
|
*/
|
|
/client/verb/fix_chat()
|
|
set name = "Fix chat"
|
|
set category = "OOC"
|
|
var/action
|
|
log_tgui(src, "tgui_panel: Started fixing.")
|
|
// Not initialized
|
|
if(!tgui_panel || !istype(tgui_panel))
|
|
log_tgui(src, "tgui_panel: datum is missing")
|
|
action = alert(src, "tgui panel was not initialized!\nSet it up again?", "", "OK", "Cancel")
|
|
if(action != "OK")
|
|
return
|
|
tgui_panel = new(src)
|
|
tgui_panel.initialize()
|
|
action = alert(src, "Wait a bit and tell me if it's fixed", "", "Fixed", "Nope")
|
|
if(action == "Fixed")
|
|
log_tgui(src, "tgui_panel: Fixed by calling 'new' + 'initialize'")
|
|
return
|
|
// Not ready
|
|
if(!tgui_panel?.is_ready())
|
|
log_tgui(src, "tgui_panel: not ready")
|
|
action = alert(src, "tgui panel looks like it's waiting for something.\nSend it a ping?", "", "OK", "Cancel")
|
|
if(action != "OK")
|
|
return
|
|
tgui_panel.window.send_message("ping", force = TRUE)
|
|
action = alert(src, "Wait a bit and tell me if it's fixed", "", "Fixed", "Nope")
|
|
if(action == "Fixed")
|
|
log_tgui(src, "tgui_panel: Fixed by sending a ping")
|
|
return
|
|
// Catch all solution
|
|
action = alert(src, "Looks like tgui panel was already setup, but we can always try again.\nSet it up again?", "", "OK", "Cancel")
|
|
if(action != "OK")
|
|
return
|
|
tgui_panel.initialize(force = TRUE)
|
|
action = alert(src, "Wait a bit and tell me if it's fixed", "", "Fixed", "Nope")
|
|
if(action == "Fixed")
|
|
log_tgui(src, "tgui_panel: Fixed by calling 'initialize'")
|
|
return
|
|
// Failed to fix
|
|
action = alert(src, "Welp, I'm all out of ideas. Try closing BYOND and reconnecting.\nWe could also disable tgui_panel and re-enable the old UI", "", "Thanks anyways", "Switch to old UI")
|
|
if (action == "Switch to old UI")
|
|
winset(src, "output", "on-show=&is-disabled=0&is-visible=1")
|
|
winset(src, "browseroutput", "is-disabled=1;is-visible=0")
|
|
log_tgui(src, "tgui_panel: Failed to fix.")
|