mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-29 19:11:51 +00:00
6d36e7cd5d
* Fixes syndicate ghost roles not spawning with codespeak language * Fixes related NRI issues as well while we're at it * Fixes a couple issue and adds the new naming scheme * Phonetic alphabet numbers, fixes trailing space in formatting * change to NATO numbers rather than phonetic * final quality sweep * moved this into the proper place * Removes the no longer in use 'rank' var * fixes a runtime * Update modular_skyrat/master_files/code/modules/mob_spawn/mob_spawn.dm Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> * Fixes a mistake * refactor outfit paths * Doc * Fixes ashwalkers sometimes spawning without language * Removes the need for post_transfer_prefs for languages and fixes language prefs not being applied correctly due to a bug Fixes another bug - the innate language (common) was always being applied when a new mob was spawned on the station, but interestingly it works fine for ghost roles. My solution to ensure that things are always set up correctly is to use the proc 'adjust_language_to_prefs' to do just that, and call it at the highest level after a mob spawns. This fixes the bug that was making it so that even if you deselected common from language prefs you'd still get it no matter what. Which honestly I am still fuzzy on the precise cause of because of how much coupling there is between mind code, language holders, and spawning new mobs. The logic of this code is absolutely mental and rather than try to weave things into functions it seems best to just do this instead. Less prone to breakage that way. * Update modular_skyrat/master_files/code/modules/client/preferences/middleware/languages.dm Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com> * Suggestions * A more fitting description for this var * Modifies language perk tooltips to better fit the codebase, refactors do_not_sanitize into a whitelist instead that can be configured for species The Ashwalker tooltip inaccurately listed common as a language they were able to speak. Also slightly changed the wording of the rest of the tooltips to reflect the fact it is possible to disable a species' native tongue via prefs. Refactored the 'do_not_sanitize' var to use a whitelist instead, allowing for more reliable sanitizing and also more configuration for new species to have such features. * rephrasing --------- Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>