mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
79b00baad2
## About The Pull Request
As the title says.
`init_order` is no more, subsystems ordering now depends on their
declared dependencies.
Subsystems can now declare which other subsystems need to init before
them using a list and the subsystem's typepath
I.e.
```dm
dependencies = list(
/datum/controller/subsystem/atoms,
/datum/controller/subsystem/mapping
)
```
The reverse can also be done, if a subsystem must initialize after your
own:
```dm
dependents = list(
/datum/controller/subsystem/atoms
)
```
Cyclical dependencies are not allowed and will throw an error on
initialization if one is found.
There's also a debug tool to visualize the dependency graph, although
it's a bit basic:
Subsystem load ordering can still be controlled using `init_stage`, some
subsystems use this in cases where they must initialize first or last
regardless of dependencies. An error will be thrown if a subsystem has
an `init_stage` before one of their dependencies.
## Why It's Good For The Game
Makes dealing with subsystem dependencies easier, and reduces the chance
of making a dependency error when needing to shift around subsystem
inits.
## Changelog
🆑
refactor: Refactored subsystem initialization
/🆑
56 lines
2.3 KiB
Plaintext
56 lines
2.3 KiB
Plaintext
//Used for active reactions in reagents/equilibrium datums
|
|
|
|
PROCESSING_SUBSYSTEM_DEF(reagents)
|
|
name = "Reagents"
|
|
priority = FIRE_PRIORITY_REAGENTS
|
|
wait = 0.25 SECONDS //You might think that rate_up_lim has to be set to half, but since everything is normalised around seconds_per_tick, it automatically adjusts it to be per second. Magic!
|
|
flags = SS_KEEP_TIMING
|
|
runlevels = RUNLEVEL_GAME | RUNLEVEL_POSTGAME
|
|
init_stage = INITSTAGE_EARLY
|
|
///What time was it when we last ticked
|
|
var/previous_world_time = 0
|
|
|
|
/datum/controller/subsystem/processing/reagents/Initialize()
|
|
//So our first step isn't insane
|
|
previous_world_time = world.time
|
|
///Blacklists these reagents from being added to the master list. the exact type only. Children are not blacklisted.
|
|
GLOB.fake_reagent_blacklist = list(/datum/reagent/medicine/c2, /datum/reagent/medicine, /datum/reagent/reaction_agent)
|
|
//Build GLOB lists - see holder.dm
|
|
build_chemical_reactions_lists()
|
|
|
|
// SKYRAT EDIT ADDITION START
|
|
if(CONFIG_GET(flag/disable_erp_preferences))
|
|
for(var/reaction_path in GLOB.chemical_reactions_list)
|
|
var/datum/chemical_reaction/reaction_datum = GLOB.chemical_reactions_list[reaction_path]
|
|
if(!reaction_datum.erp_reaction)
|
|
continue
|
|
GLOB.chemical_reactions_list -= reaction_path
|
|
for(var/reaction in reaction_datum.required_reagents)
|
|
var/list/reaction_list = GLOB.chemical_reactions_list_reactant_index[reaction]
|
|
if(reaction_list)
|
|
reaction_list -= reaction_datum
|
|
// SKYRAT EDIT ADDITION END
|
|
return SS_INIT_SUCCESS
|
|
|
|
/datum/controller/subsystem/processing/reagents/fire(resumed = FALSE)
|
|
if (!resumed)
|
|
currentrun = processing.Copy()
|
|
//cache for sanic speed (lists are references anyways)
|
|
var/list/current_run = currentrun
|
|
|
|
//Attempt to realtime reactions in a way that doesn't make them overtly dangerous
|
|
var/delta_realtime = (world.time - previous_world_time)/10 //normalise to s from ds
|
|
previous_world_time = world.time
|
|
|
|
while(current_run.len)
|
|
var/datum/thing = current_run[current_run.len]
|
|
current_run.len--
|
|
if(QDELETED(thing))
|
|
stack_trace("Found qdeleted thing in [type], in the current_run list.")
|
|
processing -= thing
|
|
else if(thing.process(delta_realtime) == PROCESS_KILL) //we are realtime
|
|
// fully stop so that a future START_PROCESSING will work
|
|
STOP_PROCESSING(src, thing)
|
|
if (MC_TICK_CHECK)
|
|
return
|