mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 17:52:36 +00:00
79b00baad2
## About The Pull Request
As the title says.
`init_order` is no more, subsystems ordering now depends on their
declared dependencies.
Subsystems can now declare which other subsystems need to init before
them using a list and the subsystem's typepath
I.e.
```dm
dependencies = list(
/datum/controller/subsystem/atoms,
/datum/controller/subsystem/mapping
)
```
The reverse can also be done, if a subsystem must initialize after your
own:
```dm
dependents = list(
/datum/controller/subsystem/atoms
)
```
Cyclical dependencies are not allowed and will throw an error on
initialization if one is found.
There's also a debug tool to visualize the dependency graph, although
it's a bit basic:
Subsystem load ordering can still be controlled using `init_stage`, some
subsystems use this in cases where they must initialize first or last
regardless of dependencies. An error will be thrown if a subsystem has
an `init_stage` before one of their dependencies.
## Why It's Good For The Game
Makes dealing with subsystem dependencies easier, and reduces the chance
of making a dependency error when needing to shift around subsystem
inits.
## Changelog
🆑
refactor: Refactored subsystem initialization
/🆑
22 lines
789 B
Plaintext
22 lines
789 B
Plaintext
/*!
|
|
This subsystem mostly exists to populate and manage the skill singletons.
|
|
*/
|
|
|
|
SUBSYSTEM_DEF(skills)
|
|
name = "Skills"
|
|
flags = SS_NO_FIRE
|
|
///Dictionary of skill.type || skill ref
|
|
var/list/all_skills = list()
|
|
///List of level names with index corresponding to skill level
|
|
var/list/level_names = list("None", "Novice", "Apprentice", "Journeyman", "Expert", "Master", "Legendary") //List of skill level names. Note that indexes can be accessed like so: level_names[SKILL_LEVEL_NOVICE]
|
|
|
|
/datum/controller/subsystem/skills/Initialize()
|
|
InitializeSkills()
|
|
return SS_INIT_SUCCESS
|
|
|
|
///Ran on initialize, populates the skills dictionary
|
|
/datum/controller/subsystem/skills/proc/InitializeSkills()
|
|
for(var/type in GLOB.skill_types)
|
|
var/datum/skill/ref = new type
|
|
all_skills[type] = ref
|