mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
5f18ba4881
## About The Pull Request Upstream now has a system for this, removes all our override code and changes the relevant quirks to use the upstream system instead ## Why It's Good For The Game Fixes #3732 ## Proof Of Testing Tested it on a local with sol weakness, masquerade, and hydrophillic, the latter wasn't selectable unless you were a slime, the former two weren't selectable unless you were a hemophage. Sol weakness was still removed as normal if you turned into a bloodsucker ## Changelog 🆑 fix: fixed species-locked quirks not actually working /🆑
115 lines
4.9 KiB
Plaintext
115 lines
4.9 KiB
Plaintext
/// Ensure every quirk has a unique icon
|
|
/datum/unit_test/quirk_icons
|
|
|
|
/datum/unit_test/quirk_icons/Run()
|
|
var/list/used_icons = list()
|
|
|
|
for (var/datum/quirk/quirk_type as anything in subtypesof(/datum/quirk))
|
|
if (initial(quirk_type.abstract_parent_type) == quirk_type)
|
|
continue
|
|
|
|
var/icon = initial(quirk_type.icon)
|
|
|
|
if (isnull(icon))
|
|
TEST_FAIL("[quirk_type] has no icon!")
|
|
continue
|
|
|
|
if (icon in used_icons)
|
|
TEST_FAIL("[icon] used in both [quirk_type] and [used_icons[icon]]!")
|
|
continue
|
|
|
|
used_icons[icon] = quirk_type
|
|
|
|
// Make sure all quirks start with a description in medical records
|
|
/datum/unit_test/quirk_initial_medical_records
|
|
|
|
/datum/unit_test/quirk_initial_medical_records/Run()
|
|
var/mob/living/carbon/human/patient = allocate(/mob/living/carbon/human/consistent)
|
|
|
|
for(var/datum/quirk/quirk_type as anything in subtypesof(/datum/quirk))
|
|
if (initial(quirk_type.abstract_parent_type) == quirk_type)
|
|
continue
|
|
|
|
if(!isnull(quirk_type.medical_record_text))
|
|
continue
|
|
|
|
//Add quirk to a patient - so we can pass quirks that add a medical record after being assigned someone
|
|
patient.add_quirk(quirk_type)
|
|
|
|
var/datum/quirk/quirk = patient.get_quirk(quirk_type)
|
|
|
|
TEST_ASSERT_NOTNULL(quirk.medical_record_text,"[quirk_type] has no medical record description!")
|
|
|
|
patient.remove_quirk(quirk_type)
|
|
|
|
/// Ensures the blood deficiency quirk updates its mail goodies correctly
|
|
/datum/unit_test/blood_deficiency_mail
|
|
var/list/species_to_test = list(
|
|
/datum/species/human = /obj/item/reagent_containers/blood/o_minus,
|
|
/datum/species/lizard = /obj/item/reagent_containers/blood/lizard,
|
|
/datum/species/ethereal = /obj/item/reagent_containers/blood/ethereal,
|
|
/datum/species/skeleton = null, // Anyone with noblood should not get a blood bag
|
|
/datum/species/jelly = /obj/item/reagent_containers/blood/toxin,
|
|
)
|
|
|
|
/datum/unit_test/blood_deficiency_mail/Run()
|
|
var/mob/living/carbon/human/dummy = allocate(/mob/living/carbon/human/consistent)
|
|
dummy.add_quirk(/datum/quirk/blooddeficiency)
|
|
var/datum/quirk/blooddeficiency/quirk = dummy.get_quirk(/datum/quirk/blooddeficiency)
|
|
|
|
TEST_ASSERT((species_to_test[dummy.dna.species.type] in quirk.mail_goodies), "Blood deficiency quirk did not get the right blood bag in its mail goodies for [dummy.dna.species.type]! \
|
|
It should be getting species_to_test[dummy.dna.species.type]." \
|
|
)
|
|
|
|
for(var/species_type in species_to_test)
|
|
var/last_species = dummy.dna.species.type
|
|
if(species_type == /datum/species/human) // we already tested this above, and setting species again will cause it to randomize
|
|
continue
|
|
dummy.set_species(species_type)
|
|
// Test that the new species has the correct blood bag
|
|
if(!isnull(species_to_test[species_type]))
|
|
TEST_ASSERT((species_to_test[species_type] in quirk.mail_goodies), \
|
|
"Blood deficiency quirk did not update correctly! ([species_type] did not get its blood bag added)")
|
|
TEST_ASSERT_EQUAL(length(quirk.mail_goodies), 1, \
|
|
"Blood deficiency quirk got multiple blood bags for [species_type]!")
|
|
else
|
|
TEST_ASSERT_EQUAL(length(quirk.mail_goodies), 0, \
|
|
"Blood deficiency quirk did not have an empty mail goody list for a noblood species!")
|
|
// Test that we don't have the old species' blood bag
|
|
if(!isnull(species_to_test[last_species]))
|
|
TEST_ASSERT(!(species_to_test[last_species] in quirk.mail_goodies), \
|
|
"Blood deficiency quirk did not update correctly for [species_type]! ([last_species] did not get its blood bag removed)")
|
|
|
|
/// Ensures that all quirks correctly initialized when added
|
|
/datum/unit_test/quirk_validity
|
|
|
|
/datum/unit_test/quirk_validity/Run()
|
|
// Required for language quirks to function properly
|
|
// Assigning this manually as config is empty
|
|
GLOB.uncommon_roundstart_languages = list(/datum/language/uncommon)
|
|
|
|
for (var/datum/quirk/quirk_type as anything in subtypesof(/datum/quirk))
|
|
if (initial(quirk_type.abstract_parent_type) == quirk_type)
|
|
continue
|
|
|
|
var/mob/dead/new_player/abstract_player = allocate(/mob/dead/new_player)
|
|
var/datum/client_interface/roundstart_mock_client = new()
|
|
abstract_player.mock_client = roundstart_mock_client
|
|
roundstart_mock_client.prefs = new(roundstart_mock_client)
|
|
var/mob/living/carbon/human/new_character = allocate(/mob/living/carbon/human/consistent)
|
|
new_character.mind_initialize()
|
|
abstract_player.new_character = new_character
|
|
if (!new_character.add_quirk(quirk_type, roundstart_mock_client))
|
|
TEST_FAIL("Failed to initialize quirk [quirk_type] on a roundstart character!")
|
|
|
|
var/mob/living/carbon/human/latejoin_character = allocate(/mob/living/carbon/human/consistent)
|
|
var/datum/client_interface/latejoin_mock_client = new()
|
|
latejoin_mock_client.prefs = new(latejoin_mock_client)
|
|
latejoin_character.mock_client = latejoin_mock_client
|
|
latejoin_character.mind_initialize()
|
|
if (!latejoin_character.add_quirk(quirk_type, latejoin_mock_client))
|
|
TEST_FAIL("Failed to initialize quirk [quirk_type] on a latejoin character!")
|
|
|
|
// Clean up after ourselves
|
|
GLOB.uncommon_roundstart_languages.Cut()
|