Files
Bubberstation/code/modules/antagonists
SkyratBot b612704f83 [MIRROR] Fix nuclear operative induction implants [MDB IGNORE] (#24845)
* Fix nuclear operative induction implants (#79554)

## About The Pull Request
Fixes #79547

#78597 broke induction implants by replacing the "has antag datum" check
with a "does not have a fake antag datum" check which passes on a null
case. I added an `isnull()` check to cover this.

The introduced `antag_flags` var was by default set to
`FLAG_FAKE_ANTAG`, presumably in error as the only antag datums to
override this are ERT and Valentines and they just set it to
`FLAG_FAKE_ANTAG` anyways. This also means the induction implants ONLY
worked on non-antags and anybody with any antag datum would fail the
implant. I changed the default to `NONE`. This may have some knock-on
effects as `is_special_character()` was returning `FALSE` with any antag
datum (unless allow_fake_antags was passed) but no special role which
this also fixes.
## Why It's Good For The Game
Non-antags can no longer self-antag their way onto a nuclear operative
team and antags can now antag their way onto a nuclear operative team.
## Changelog
🆑
fix: Nuclear operative induction implants now work correctly on
antagonists and fail on non-antagonists
/🆑

* Fix nuclear operative induction implants

---------

Co-authored-by: Isratosh <Isratosh@hotmail.com>
2023-11-07 09:42:02 -05:00
..