Bubberstation

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-03 13:32:17 +00:00

Files

SkyratBot fcc0466084 [MIRROR] Fixes an issue with multiz visholders duplicating [MDB IGNORE] (#19727 )

* Fixes an issue with multiz visholders duplicating (#73835)

## About The Pull Request

I think the inherent issue here has to do with turf refs or something,
but the big problem was I assumed if there was only once source, then
the turf must be new. This was an invalid assumption, since we can add
sources more then once, and | is used

Because of this, each time a shuttle moved, we'd add an extra source for
no reason, and stack extra vis holders. This lead to really bad
clientside lag on some out of repo maps, which is how this issue came to
my attention.

Instead checking if the sources list exists or not solves the problem
pretty handily, so let's do that.

## Why It's Good For The Game

Closes #73834, prevents a potential future OOM

* Fixes an issue with multiz visholders duplicating

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>

2023-03-08 11:39:01 +00:00

__DEFINES

[MOSTLY Modular] Roles and tracking for ghost roles (#19672 )

2023-03-06 08:29:11 -08:00

__HELPERS

[MIRROR] Vote System: Approval Voting [MDB IGNORE] (#19666 )

2023-03-04 17:49:21 -08:00

_globalvars

[NO GBP] Hotfix for the glasses drawing over hats on all snouted mobs (#19573 )

2023-03-01 21:39:15 +00:00

_js

[MIRROR] Adds spaces around logical operators [MDB IGNORE] (#18776 )