mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-24 08:02:57 +00:00
ff6b41aa07
## About The Pull Request - Afterattack is a very simple proc now: All it does is this, and all it's used for is for having a convenient place to put effects an item does after a successful attack (IE, the attack was not blocked)  - An overwhelming majority of afterattack implementations have been moved to `interact_with_atom` or the new `ranged_interact_with_atom` I have manually tested many of the refactored procs but there was 200+ so it's kinda hard ## Why It's Good For The Game Afterattack is one of the worst parts of the attack chain, as it simultaneously serves as a way of doing random interactions NOT AT ALL related to attacks (despite the name) while ALSO serving as the defacto way to do a ranged interaction with an item This means careless coders (most of them) may throw stuff in afterattack without realizing how wide reaching it is, which causes bugs. By making two well defined, separate procs for handing adjacent vs ranged interactions, it becomes WAY WAY WAY more easy to develop for. If you want to do something when you click on something else and you're adjacent, use `interact_with_atom` If you want to do something when you click on something else and you're not adjacent, use 'ranged_interact_with_atom` This does result in some instances of boilerplate as shown here:  But I think it's acceptable, feel free to oppose if you don't I'm sure we can think of another solution ~~Additionally it makes it easier to implement swing combat. That's a bonus I guess~~ ## Changelog 🆑 Melbert refactor: Over 200 item interactions have been refactored to use a newer, easier-to-use system. Report any oddities with using items on other objects you may see (such as surgery, reagent containers like cups and spray bottles, or construction devices), especially using something at range (such as guns or chisels) refactor: Item-On-Modsuit interactions have changed slightly. While on combat mode, you will attempt to "use" the item on the suit instead of inserting it into the suit's storage. This means being on combat mode while the suit's panel is open will block you from inserting items entirely via click (but other methods such as hotkey, clicking on the storage boxes, and mousedrop will still work). refactor: The detective's scanner will now be inserted into storage items if clicked normally, and will scan the storage item if on combat mode /🆑
276 lines
11 KiB
Plaintext
276 lines
11 KiB
Plaintext
#define PAPER_PER_SHEET 10
|
|
|
|
/obj/item/universal_scanner
|
|
name = "universal scanner"
|
|
desc = "A device used to check objects against Nanotrasen exports database, assign price tags, or ready an item for a custom vending machine."
|
|
icon = 'icons/obj/devices/scanner.dmi'
|
|
icon_state = "export scanner"
|
|
worn_icon_state = "electronic"
|
|
inhand_icon_state = "export_scanner"
|
|
lefthand_file = 'icons/mob/inhands/items/devices_lefthand.dmi'
|
|
righthand_file = 'icons/mob/inhands/items/devices_righthand.dmi'
|
|
item_flags = NOBLUDGEON
|
|
w_class = WEIGHT_CLASS_SMALL
|
|
/// Which mode is the scanner currently on?
|
|
var/scanning_mode = SCAN_EXPORTS
|
|
/// A list of all available export scanner modes.
|
|
var/list/scale_mode = list()
|
|
/// The paper currently stored by the export scanner.
|
|
var/paper_count = 10
|
|
/// The maximum paper to be stored by the export scanner.
|
|
var/max_paper_count = 20
|
|
|
|
/// The price of the item used by price tagger mode.
|
|
var/new_custom_price = 1
|
|
|
|
/// The account which is receiving the split profits in sales tagger mode.
|
|
var/datum/bank_account/payments_acc = null
|
|
/// The person who tagged this will receive the sale value multiplied by this number in sales tagger mode.
|
|
var/cut_multiplier = 0.5
|
|
/// Maximum value for cut_multiplier in sales tagger mode.
|
|
var/cut_max = 0.5
|
|
/// Minimum value for cut_multiplier in sales tagger mode.
|
|
var/cut_min = 0.01
|
|
|
|
/obj/item/universal_scanner/Initialize(mapload)
|
|
. = ..()
|
|
scale_mode = sort_list(list(
|
|
"export scanner" = image(icon = src.icon, icon_state = "export scanner"),
|
|
"price tagger" = image(icon = src.icon, icon_state = "price tagger"),
|
|
"sales tagger" = image(icon = src.icon, icon_state = "sales tagger"),
|
|
))
|
|
register_context()
|
|
|
|
/obj/item/universal_scanner/attack_self(mob/user, modifiers)
|
|
. = ..()
|
|
var/choice = show_radial_menu(user, src, scale_mode, custom_check = CALLBACK(src, PROC_REF(check_menu), user), radius = 36, require_near = TRUE)
|
|
if(!choice)
|
|
return FALSE
|
|
if(icon_state == "[choice]")
|
|
return FALSE
|
|
switch(choice)
|
|
if("export scanner")
|
|
scanning_mode = SCAN_EXPORTS
|
|
if("price tagger")
|
|
scanning_mode = SCAN_PRICE_TAG
|
|
if("sales tagger")
|
|
scanning_mode = SCAN_SALES_TAG
|
|
icon_state = "[choice]"
|
|
playsound(src, 'sound/machines/click.ogg', 40, TRUE)
|
|
|
|
/obj/item/universal_scanner/interact_with_atom(atom/interacting_with, mob/living/user, list/modifiers)
|
|
if(!isobj(interacting_with))
|
|
return NONE
|
|
if(scanning_mode == SCAN_EXPORTS)
|
|
export_scan(interacting_with, user)
|
|
return ITEM_INTERACT_SUCCESS
|
|
if(scanning_mode == SCAN_PRICE_TAG)
|
|
price_tag(interacting_with, user)
|
|
return ITEM_INTERACT_SUCCESS
|
|
return NONE
|
|
|
|
/obj/item/universal_scanner/attackby(obj/item/attacking_item, mob/user, params)
|
|
. = ..()
|
|
if(scanning_mode == SCAN_SALES_TAG && isidcard(attacking_item))
|
|
var/obj/item/card/id/potential_acc = attacking_item
|
|
if(potential_acc.registered_account)
|
|
if(payments_acc == potential_acc.registered_account)
|
|
to_chat(user, span_notice("ID card already registered."))
|
|
return
|
|
else
|
|
payments_acc = potential_acc.registered_account
|
|
playsound(src, 'sound/machines/ping.ogg', 40, TRUE)
|
|
to_chat(user, span_notice("[src] registers the ID card. Tag a wrapped item to create a barcode."))
|
|
else if(!potential_acc.registered_account)
|
|
to_chat(user, span_warning("This ID card has no account registered!"))
|
|
return
|
|
if(istype(attacking_item, /obj/item/paper))
|
|
if (!(paper_count >= max_paper_count))
|
|
paper_count += PAPER_PER_SHEET
|
|
qdel(attacking_item)
|
|
if (paper_count >= max_paper_count)
|
|
paper_count = max_paper_count
|
|
to_chat(user, span_notice("[src]'s paper supply is now full."))
|
|
return
|
|
to_chat(user, span_notice("You refill [src]'s paper supply, you have [paper_count] left."))
|
|
else
|
|
to_chat(user, span_notice("[src]'s paper supply is full."))
|
|
|
|
/obj/item/universal_scanner/attack_self_secondary(mob/user, modifiers)
|
|
. = ..()
|
|
if(scanning_mode == SCAN_SALES_TAG)
|
|
if(paper_count <= 0)
|
|
to_chat(user, span_warning("You're out of paper!'."))
|
|
return
|
|
if(!payments_acc)
|
|
to_chat(user, span_warning("You need to swipe [src] with an ID card first."))
|
|
return
|
|
paper_count--
|
|
playsound(src, 'sound/machines/click.ogg', 40, TRUE)
|
|
to_chat(user, span_notice("You print a new barcode."))
|
|
var/obj/item/barcode/new_barcode = new /obj/item/barcode(src)
|
|
new_barcode.payments_acc = payments_acc // The sticker gets the scanner's registered account.
|
|
new_barcode.cut_multiplier = cut_multiplier // Also the registered percent cut.
|
|
user.put_in_hands(new_barcode)
|
|
if(scanning_mode == SCAN_PRICE_TAG)
|
|
if(loc != user)
|
|
to_chat(user, span_warning("You must be holding \the [src] to continue!"))
|
|
return
|
|
var/chosen_price = tgui_input_number(user, "Set price", "Price", new_custom_price)
|
|
if(!chosen_price || QDELETED(user) || QDELETED(src) || !user.can_perform_action(src, FORBID_TELEKINESIS_REACH) || loc != user)
|
|
return
|
|
new_custom_price = chosen_price
|
|
to_chat(user, span_notice("[src] will now give things a [new_custom_price] cr tag."))
|
|
|
|
/obj/item/universal_scanner/CtrlClick(mob/user)
|
|
. = ..()
|
|
if(scanning_mode == SCAN_SALES_TAG)
|
|
payments_acc = null
|
|
to_chat(user, span_notice("You clear the registered account."))
|
|
|
|
/obj/item/universal_scanner/click_alt(mob/user)
|
|
if(!scanning_mode == SCAN_SALES_TAG)
|
|
return CLICK_ACTION_BLOCKING
|
|
var/potential_cut = input("How much would you like to pay out to the registered card?","Percentage Profit ([round(cut_min*100)]% - [round(cut_max*100)]%)") as num|null
|
|
if(!potential_cut)
|
|
cut_multiplier = initial(cut_multiplier)
|
|
cut_multiplier = clamp(round(potential_cut/100, cut_min), cut_min, cut_max)
|
|
to_chat(user, span_notice("[round(cut_multiplier*100)]% profit will be received if a package with a barcode is sold."))
|
|
return CLICK_ACTION_SUCCESS
|
|
|
|
/obj/item/universal_scanner/examine(mob/user)
|
|
. = ..()
|
|
. += span_notice("It has [paper_count]/[max_paper_count] available barcodes. Refill with paper.")
|
|
|
|
if(scanning_mode == SCAN_SALES_TAG)
|
|
. += span_notice("Profit split on sale is currently set to [round(cut_multiplier*100)]%. <b>Alt-click</b> to change.")
|
|
if(payments_acc)
|
|
. += span_notice("<b>Ctrl-click</b> to clear the registered account.")
|
|
|
|
if(scanning_mode == SCAN_PRICE_TAG)
|
|
. += span_notice("The current custom price is set to [new_custom_price] cr. <b>Right-click</b> to change.")
|
|
|
|
/obj/item/universal_scanner/add_context(atom/source, list/context, obj/item/held_item, mob/user)
|
|
switch(scanning_mode)
|
|
if(SCAN_SALES_TAG)
|
|
context[SCREENTIP_CONTEXT_LMB] = "Tag package"
|
|
context[SCREENTIP_CONTEXT_ALT_LMB] = "Change price"
|
|
context[SCREENTIP_CONTEXT_CTRL_LMB] = "Clear target account"
|
|
context[SCREENTIP_CONTEXT_ALT_LMB] = "Change payout %"
|
|
if(SCAN_PRICE_TAG)
|
|
context[SCREENTIP_CONTEXT_LMB] = "Price item"
|
|
context[SCREENTIP_CONTEXT_RMB] = "Set price"
|
|
if(SCAN_EXPORTS)
|
|
context[SCREENTIP_CONTEXT_LMB] = "Scan for export value"
|
|
return CONTEXTUAL_SCREENTIP_SET
|
|
/**
|
|
* Scans an object, target, and provides it's export value based on selling to the cargo shuttle, to mob/user.
|
|
*/
|
|
/obj/item/universal_scanner/proc/export_scan(obj/target, mob/user)
|
|
var/datum/export_report/report = export_item_and_contents(target, dry_run = TRUE)
|
|
var/price = 0
|
|
for(var/exported_datum in report.total_amount)
|
|
price += report.total_value[exported_datum]
|
|
|
|
var/message = "Scanned [target]"
|
|
var/warning = FALSE
|
|
if(length(target.contents))
|
|
message = "Scanned [target] and its contents"
|
|
if(price)
|
|
message += ", total value: <b>[price]</b> credits"
|
|
else
|
|
message += ", no export values"
|
|
warning = TRUE
|
|
if(!report.all_contents_scannable)
|
|
message += " (Undeterminable value detected, final value may differ)"
|
|
message += "."
|
|
else
|
|
if(!report.all_contents_scannable)
|
|
message += ", unable to determine value."
|
|
warning = TRUE
|
|
else if(price)
|
|
message += ", value: <b>[price]</b> credits."
|
|
else
|
|
message += ", no export value."
|
|
warning = TRUE
|
|
if(warning)
|
|
to_chat(user, span_warning(message))
|
|
else
|
|
to_chat(user, span_notice(message))
|
|
|
|
if(price)
|
|
playsound(src, 'sound/machines/terminal_select.ogg', 50, vary = TRUE)
|
|
|
|
if(istype(target, /obj/item/delivery))
|
|
var/obj/item/delivery/parcel = target
|
|
if(!parcel.sticker)
|
|
return
|
|
var/obj/item/barcode/our_code = parcel.sticker
|
|
to_chat(user, span_notice("Export barcode detected! This parcel, upon export, will pay out to [our_code.payments_acc.account_holder], \
|
|
with a [our_code.cut_multiplier * 100]% split to them (already reflected in above recorded value)."))
|
|
|
|
if(istype(target, /obj/item/barcode))
|
|
var/obj/item/barcode/our_code = target
|
|
to_chat(user, span_notice("Export barcode detected! This barcode, if attached to a parcel, will pay out to [our_code.payments_acc.account_holder], \
|
|
with a [our_code.cut_multiplier * 100]% split to them."))
|
|
|
|
if(ishuman(user))
|
|
var/mob/living/carbon/human/scan_human = user
|
|
if(istype(target, /obj/item/bounty_cube))
|
|
var/obj/item/bounty_cube/cube = target
|
|
var/datum/bank_account/scanner_account = scan_human.get_bank_account()
|
|
|
|
if(!istype(get_area(cube), /area/shuttle/supply))
|
|
to_chat(user, span_warning("Shuttle placement not detected. Handling tip not registered."))
|
|
|
|
else if(cube.bounty_handler_account)
|
|
to_chat(user, span_warning("Bank account for handling tip already registered!"))
|
|
|
|
else if(scanner_account)
|
|
cube.AddComponent(/datum/component/pricetag, scanner_account, cube.handler_tip, FALSE)
|
|
|
|
cube.bounty_handler_account = scanner_account
|
|
cube.bounty_handler_account.bank_card_talk("Bank account for [price ? "<b>[price * cube.handler_tip]</b> credit " : ""]handling tip successfully registered.")
|
|
|
|
if(cube.bounty_holder_account != cube.bounty_handler_account) //No need to send a tracking update to the person scanning it
|
|
cube.bounty_holder_account.bank_card_talk("<b>[cube]</b> was scanned in \the <b>[get_area(cube)]</b> by <b>[scan_human] ([scan_human.job])</b>.")
|
|
|
|
else
|
|
to_chat(user, span_warning("Bank account not detected. Handling tip not registered."))
|
|
|
|
/**
|
|
* Scans an object, target, and sets it's custom_price variable to new_custom_price, presenting it to the user.
|
|
*/
|
|
/obj/item/universal_scanner/proc/price_tag(obj/target, mob/user)
|
|
if(isitem(target))
|
|
var/obj/item/selected_target = target
|
|
selected_target.custom_price = new_custom_price
|
|
to_chat(user, span_notice("You set the price of [selected_target] to [new_custom_price] cr."))
|
|
|
|
/**
|
|
* check_menu: Checks if we are allowed to interact with a radial menu
|
|
*
|
|
* Arguments:
|
|
* * user The mob interacting with a menu
|
|
*/
|
|
/obj/item/universal_scanner/proc/check_menu(mob/living/user)
|
|
if(!istype(user))
|
|
return FALSE
|
|
if(user.incapacitated())
|
|
return FALSE
|
|
return TRUE
|
|
|
|
/obj/item/barcode
|
|
name = "barcode tag"
|
|
desc = "A tiny tag, associated with a crewmember's account. Attach to a wrapped item to give that account a portion of the wrapped item's profit."
|
|
icon = 'icons/obj/service/bureaucracy.dmi'
|
|
icon_state = "barcode"
|
|
w_class = WEIGHT_CLASS_TINY
|
|
//All values inherited from the sales tagger it came from.
|
|
///The bank account assigned to pay out to from the sales tagger.
|
|
var/datum/bank_account/payments_acc = null
|
|
///The percentage of profit to give to the payments_acc, from 0 to 1.
|
|
var/cut_multiplier = 0.5
|
|
|
|
#undef PAPER_PER_SHEET
|