mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-21 20:20:33 +01:00
e65a48e91f
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761) Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks. Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work. This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping. To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway. Requested by @optimumtact. Changelog cl admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again. /cl * Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
39 lines
793 B
Plaintext
39 lines
793 B
Plaintext
/datum/component/beauty
|
|
var/beauty = 0
|
|
|
|
/datum/component/beauty/Initialize(beautyamount)
|
|
if(!isatom(parent) || isarea(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
|
|
beauty = beautyamount
|
|
|
|
if(ismovable(parent))
|
|
RegisterSignal(parent, COMSIG_ENTER_AREA, .proc/enter_area)
|
|
RegisterSignal(parent, COMSIG_EXIT_AREA, .proc/exit_area)
|
|
|
|
var/area/A = get_area(parent)
|
|
if(A)
|
|
enter_area(null, A)
|
|
|
|
/datum/component/beauty/proc/enter_area(datum/source, area/A)
|
|
SIGNAL_HANDLER
|
|
|
|
if(A.outdoors)
|
|
return
|
|
A.totalbeauty += beauty
|
|
A.update_beauty()
|
|
|
|
/datum/component/beauty/proc/exit_area(datum/source, area/A)
|
|
SIGNAL_HANDLER
|
|
|
|
if(A.outdoors)
|
|
return
|
|
A.totalbeauty -= beauty
|
|
A.update_beauty()
|
|
|
|
/datum/component/beauty/Destroy()
|
|
. = ..()
|
|
var/area/A = get_area(parent)
|
|
if(A)
|
|
exit_area(null, A)
|