fixes #6599

also small improvements to the loadout system

Signed-off-by: Mloc <colmohici@gmail.com>

code/controllers/master_controller.dm

@@ -121,9 +121,6 @@ datum/controller/game_controller/proc/setup_objects()
 	//Set up spawn points.
 	populate_spawn_points()
 
-	//Set up gear list.
-	populate_gear_list()
-
 	//Set up roundstart seed list.
 	populate_seed_list()
 

code/modules/client/preferences.dm

@@ -276,15 +276,15 @@ datum/preferences
 	dat += "<br><b>Custom Loadout:</b> "
 	var/total_cost = 0
 
-	if(isnull(gear) || !islist(gear)) gear = list()
+	if(!islist(gear)) gear = list()
 
 	if(gear && gear.len)
 		dat += "<br>"
-		for(var/gear_name in gear)
+		for(var/i = 1; i <= gear.len; i++)
-			if(gear_datums[gear_name])
+			var/datum/gear/G = gear_datums[gear[i]]
-				var/datum/gear/G = gear_datums[gear_name]
+			if(G)
 				total_cost += G.cost
-				dat += "[gear_name] <a href='byond://?src=\ref[user];preference=loadout;task=remove;gear=[gear_name]'>\[remove\]</a><br>"
+				dat += "[gear[i]] ([G.cost] points) <a href='byond://?src=\ref[user];preference=loadout;task=remove;gear=[i]'>\[remove\]</a><br>"
 
 		dat += "<b>Used:</b> [total_cost] points."
 	else
@@ -293,7 +293,7 @@ datum/preferences
 	if(total_cost < MAX_GEAR_COST)
 		dat += " <a href='byond://?src=\ref[user];preference=loadout;task=input'>\[add\]</a>"
 		if(gear && gear.len)
-			dat += " <a href='byond://?src=\ref[user];preference=loadout;task=remove'>\[remove\]</a>"
+			dat += " <a href='byond://?src=\ref[user];preference=loadout;task=clear'>\[clear\]</a>"
 
 	dat += "<br><br><b>Occupation Choices</b><br>"
 	dat += "\t<a href='?_src_=prefs;preference=job;task=menu'><b>Set Preferences</b></a><br>"
@@ -874,17 +874,17 @@ datum/preferences
 				total_cost += C.cost
 				if(C && total_cost <= MAX_GEAR_COST)
 					gear += choice
-					user << "\blue Added [choice] for [C.cost] points ([MAX_GEAR_COST - total_cost] points remaining)."
+					user << "<span class='notice'>Added \the '[choice]' for [C.cost] points ([MAX_GEAR_COST - total_cost] points remaining).</span>"
 				else
-					user << "\red That item will exceed the maximum loadout cost of [MAX_GEAR_COST] points."
+					user << "<span class='warning'>Adding \the '[choice]' will exceed the maximum loadout cost of [MAX_GEAR_COST] points.</span>"
 
 		else if(href_list["task"] == "remove")
-			var/to_remove = href_list["gear"]
+			var/i_remove = text2num(href_list["gear"])
-			if(!to_remove) return
+			if(i_remove < 1 || i_remove > gear.len) return
-			for(var/gear_name in gear)
+			gear.Cut(i_remove, i_remove + 1)
-				if(gear_name == to_remove)
+
-					gear -= gear_name
+		else if(href_list["task"] == "clear")
-					break
+			gear.Cut()
 
 	else if(href_list["preference"] == "flavor_text")
 		switch(href_list["task"])

code/modules/client/preferences_gear.dm

@@ -1,9 +1,10 @@
 var/global/list/gear_datums = list()
 
-proc/populate_gear_list()
+/hook/startup/proc/populate_gear_list()
 	for(var/type in typesof(/datum/gear)-/datum/gear)
 		var/datum/gear/G = new type()
 		gear_datums[G.display_name] = G
+	return 1
 
 /datum/gear
 	var/display_name       //Name/index.