From 1706d86e508e982ec068a3dbeb5be32fbf4165c4 Mon Sep 17 00:00:00 2001 From: CHOMPStation2StaffMirrorBot <94713762+CHOMPStation2StaffMirrorBot@users.noreply.github.com> Date: Fri, 26 Sep 2025 06:21:19 -0700 Subject: [PATCH] [MIRROR] Strips byondUI procs not needed for TGUI interaction (#11740) Co-authored-by: Will <7099514+Willburd@users.noreply.github.com> --- .../components/binary_devices/algae_generator_vr.dm | 1 - code/game/machinery/atmoalter/area_atmos_computer.dm | 2 -- code/game/machinery/biogenerator.dm | 1 - code/game/machinery/bioprinter.dm | 1 - code/game/machinery/cloning.dm | 1 - code/game/machinery/partslathe_vr.dm | 2 -- code/game/machinery/portable_turret.dm | 1 - code/game/machinery/suit_storage/suit_cycler.dm | 8 -------- code/game/machinery/suit_storage/suit_storage.dm | 10 ---------- code/game/machinery/telecomms/logbrowser.dm | 1 - code/game/machinery/telecomms/telemonitor.dm | 1 - code/game/objects/stumble_into_vr.dm | 1 - code/modules/mining/machinery/machine_processing.dm | 2 -- code/modules/mining/machinery/machine_stacking.dm | 3 --- code/modules/power/port_gen.dm | 1 - code/modules/reagents/machinery/alembic.dm | 2 -- code/modules/reagents/machinery/grinder.dm | 2 -- code/modules/reagents/machinery/injector_maker.dm | 1 - code/modules/resleeving/machines.dm | 4 ---- 19 files changed, 45 deletions(-) diff --git a/code/ATMOSPHERICS/components/binary_devices/algae_generator_vr.dm b/code/ATMOSPHERICS/components/binary_devices/algae_generator_vr.dm index a06851a52c..ac22d2db69 100644 --- a/code/ATMOSPHERICS/components/binary_devices/algae_generator_vr.dm +++ b/code/ATMOSPHERICS/components/binary_devices/algae_generator_vr.dm @@ -257,7 +257,6 @@ S.use(1) count++ user.visible_message("\The [user] inserts [S.name] into \the [src].", span_notice("You insert [count] [S.name] into \the [src].")) - updateUsrDialog(user) else to_chat(user, span_warning("\The [src] cannot hold more [S.name].")) return 1 diff --git a/code/game/machinery/atmoalter/area_atmos_computer.dm b/code/game/machinery/atmoalter/area_atmos_computer.dm index 0aa54b412b..e4e9c96c61 100644 --- a/code/game/machinery/atmoalter/area_atmos_computer.dm +++ b/code/game/machinery/atmoalter/area_atmos_computer.dm @@ -105,7 +105,6 @@ /obj/machinery/computer/area_atmos/proc/scanscrubbers_user(mob/user) //Used when the user is in the UI and scans for scrubbers. scanscrubbers() - updateUsrDialog(user) // The one that only works in the same map area /obj/machinery/computer/area_atmos/area @@ -125,7 +124,6 @@ /obj/machinery/computer/area_atmos/area/scanscrubbers_user(mob/user) //Used when the user is in the UI and scans for scrubbers. scanscrubbers() - updateUsrDialog(user) /obj/machinery/computer/area_atmos/area/validscrubber(var/obj/machinery/portable_atmospherics/powered/scrubber/huge/scrubber) if(!istype(scrubber)) diff --git a/code/game/machinery/biogenerator.dm b/code/game/machinery/biogenerator.dm index 154e870387..acdedc7a23 100644 --- a/code/game/machinery/biogenerator.dm +++ b/code/game/machinery/biogenerator.dm @@ -247,7 +247,6 @@ user.remove_from_mob(O) O.loc = src beaker = O - updateUsrDialog(user) else if(processing) to_chat(user, span_notice("\The [src] is currently processing.")) else if(istype(O, /obj/item/storage/bag/plants)) diff --git a/code/game/machinery/bioprinter.dm b/code/game/machinery/bioprinter.dm index 32326ecba0..8ea4b049aa 100644 --- a/code/game/machinery/bioprinter.dm +++ b/code/game/machinery/bioprinter.dm @@ -81,7 +81,6 @@ /obj/machinery/organ_printer/attackby(var/obj/item/O, var/mob/user) if(default_deconstruction_screwdriver(user, O)) - updateUsrDialog(user) return if(default_deconstruction_crowbar(user, O)) return diff --git a/code/game/machinery/cloning.dm b/code/game/machinery/cloning.dm index fb14f1713a..b35286efc5 100644 --- a/code/game/machinery/cloning.dm +++ b/code/game/machinery/cloning.dm @@ -279,7 +279,6 @@ return 0 connected.temp = "[name] : [message]" - connected.updateUsrDialog() return 1 /obj/machinery/clonepod/RefreshParts() diff --git a/code/game/machinery/partslathe_vr.dm b/code/game/machinery/partslathe_vr.dm index 138378519b..12e1021522 100644 --- a/code/game/machinery/partslathe_vr.dm +++ b/code/game/machinery/partslathe_vr.dm @@ -110,7 +110,6 @@ copy_board = O O.forceMove(src) user.visible_message("[user] inserts [O] into \the [src]'s circuit reader.", span_notice("You insert [O] into \the [src]'s circuit reader.")) - updateUsrDialog(user) return if(try_load_materials(user, O)) return @@ -136,7 +135,6 @@ count++ user.visible_message("[user] inserts [S.name] into \the [src].", span_notice("You insert [count] [S.name] into \the [src].")) flick("partslathe-load-[S.material.name]", src) - updateUsrDialog(user) else to_chat(user, span_warning("\The [src] cannot hold more [S.name].")) return 1 diff --git a/code/game/machinery/portable_turret.dm b/code/game/machinery/portable_turret.dm index 182bfa9858..7a5be3a990 100644 --- a/code/game/machinery/portable_turret.dm +++ b/code/game/machinery/portable_turret.dm @@ -536,7 +536,6 @@ if(allowed(user)) locked = !locked to_chat(user, span_notice("Controls are now [locked ? "locked" : "unlocked"].")) - updateUsrDialog(user) else to_chat(user, span_notice("Access denied.")) diff --git a/code/game/machinery/suit_storage/suit_cycler.dm b/code/game/machinery/suit_storage/suit_cycler.dm index 6dcdf53778..71e4d435cb 100644 --- a/code/game/machinery/suit_storage/suit_cycler.dm +++ b/code/game/machinery/suit_storage/suit_cycler.dm @@ -174,15 +174,12 @@ GLOBAL_LIST_EMPTY(suit_cycler_typecache) add_fingerprint(user) qdel(G) - updateUsrDialog(user) - return else if(I.has_tool_quality(TOOL_SCREWDRIVER)) panel_open = !panel_open playsound(src, I.usesound, 50, 1) to_chat(user, "You [panel_open ? "open" : "close"] the maintenance panel.") - updateUsrDialog(user) return else if(istype(I,/obj/item/clothing/head/helmet/space/void) && !istype(I, /obj/item/clothing/head/helmet/space/rig)) @@ -220,7 +217,6 @@ GLOBAL_LIST_EMPTY(suit_cycler_typecache) helmet = I update_icon() - updateUsrDialog(user) return else if(istype(I,/obj/item/clothing/suit/space/void)) @@ -260,7 +256,6 @@ GLOBAL_LIST_EMPTY(suit_cycler_typecache) suit = I update_icon() - updateUsrDialog(user) return ..() @@ -276,7 +271,6 @@ GLOBAL_LIST_EMPTY(suit_cycler_typecache) emagged = 1 safeties = 0 req_access = list() - updateUsrDialog(user) return 1 /obj/machinery/suit_cycler/attack_hand(mob/user as mob) @@ -479,7 +473,6 @@ GLOBAL_LIST_EMPTY(suit_cycler_typecache) icon_state = initial(icon_state) active = 0 playsound(src, 'sound/machines/boobeebeep.ogg', 50) - updateUsrDialog(user) /obj/machinery/suit_cycler/proc/repair_suit() if(!suit || !suit.damage || !suit.can_breach) @@ -517,7 +510,6 @@ GLOBAL_LIST_EMPTY(suit_cycler_typecache) occupant = null add_fingerprint(user) - updateUsrDialog(user) update_icon() return diff --git a/code/game/machinery/suit_storage/suit_storage.dm b/code/game/machinery/suit_storage/suit_storage.dm index a96a3ebd8c..dfc6042343 100644 --- a/code/game/machinery/suit_storage/suit_storage.dm +++ b/code/game/machinery/suit_storage/suit_storage.dm @@ -263,7 +263,6 @@ if(OCCUPANT && !islocked) islocked = 1 //Let's lock it for good measure update_icon() - updateUsrDialog(user) var/i //our counter for(i=0,i<4,i++) @@ -302,7 +301,6 @@ eject_occupant(OCCUPANT) //Mixing up these two lines causes bug. DO NOT DO IT. isUV = 0 //Cycle ends update_icon() - updateUsrDialog(user) return /obj/machinery/suit_storage_unit/proc/cycletimeleft() @@ -343,7 +341,6 @@ return eject_occupant(usr) add_fingerprint(usr) - updateUsrDialog(usr) update_icon() return @@ -375,7 +372,6 @@ update_icon() add_fingerprint(usr) - updateUsrDialog(usr) return else OCCUPANT = null //Testing this as a backup sanity test @@ -389,7 +385,6 @@ panelopen = !panelopen playsound(src, I.usesound, 100, 1) to_chat(user, span_notice("You [panelopen ? "open up" : "close"] the unit's maintenance panel.")) - updateUsrDialog(user) return if(istype(I, /obj/item/grab)) var/obj/item/grab/G = I @@ -417,7 +412,6 @@ add_fingerprint(user) qdel(G) - updateUsrDialog(user) update_icon() return return @@ -433,7 +427,6 @@ S.loc = src SUIT = S update_icon() - updateUsrDialog(user) return if(istype(I,/obj/item/clothing/head/helmet)) if(!isopen) @@ -447,7 +440,6 @@ H.loc = src HELMET = H update_icon() - updateUsrDialog(user) return if(istype(I,/obj/item/clothing/mask)) if(!isopen) @@ -461,10 +453,8 @@ M.loc = src MASK = M update_icon() - updateUsrDialog(user) return update_icon() - updateUsrDialog(user) return diff --git a/code/game/machinery/telecomms/logbrowser.dm b/code/game/machinery/telecomms/logbrowser.dm index 4bc122db31..50fa71c34f 100644 --- a/code/game/machinery/telecomms/logbrowser.dm +++ b/code/game/machinery/telecomms/logbrowser.dm @@ -149,7 +149,6 @@ playsound(src, 'sound/effects/sparks4.ogg', 75, 1) emagged = 1 to_chat(user, span_notice("You you disable the security protocols")) - updateUsrDialog(user) return 1 /obj/machinery/computer/telecomms/server/proc/set_temp(var/text, var/color = "average") diff --git a/code/game/machinery/telecomms/telemonitor.dm b/code/game/machinery/telecomms/telemonitor.dm index 162924335a..5554178ec3 100644 --- a/code/game/machinery/telecomms/telemonitor.dm +++ b/code/game/machinery/telecomms/telemonitor.dm @@ -121,7 +121,6 @@ playsound(src, 'sound/effects/sparks4.ogg', 75, 1) emagged = 1 to_chat(user, span_notice("You you disable the security protocols")) - src.updateUsrDialog(user) return 1 /obj/machinery/computer/telecomms/monitor/proc/set_temp(var/text, var/color = "average") diff --git a/code/game/objects/stumble_into_vr.dm b/code/game/objects/stumble_into_vr.dm index 8253e38d33..1d9a6bc54d 100644 --- a/code/game/objects/stumble_into_vr.dm +++ b/code/game/objects/stumble_into_vr.dm @@ -134,7 +134,6 @@ isopen = 0 update_icon() add_fingerprint(M) - updateUsrDialog(M) M.stop_flying() /obj/machinery/vending/stumble_into(mob/living/M) diff --git a/code/modules/mining/machinery/machine_processing.dm b/code/modules/mining/machinery/machine_processing.dm index 393db9ab58..5a2d694cf5 100644 --- a/code/modules/mining/machinery/machine_processing.dm +++ b/code/modules/mining/machinery/machine_processing.dm @@ -341,8 +341,6 @@ else continue - console.updateUsrDialog() - #undef PROCESS_NONE #undef PROCESS_SMELT #undef PROCESS_COMPRESS diff --git a/code/modules/mining/machinery/machine_stacking.dm b/code/modules/mining/machinery/machine_stacking.dm index e080f2e9da..b89a33d583 100644 --- a/code/modules/mining/machinery/machine_stacking.dm +++ b/code/modules/mining/machinery/machine_stacking.dm @@ -129,7 +129,4 @@ var/stacktype = stack_paths[sheet] new stacktype (get_turf(output), stack_amt) stack_storage[sheet] -= stack_amt - - if(console) - console.updateUsrDialog() return diff --git a/code/modules/power/port_gen.dm b/code/modules/power/port_gen.dm index fb6e2b2c9a..fcdefef69c 100644 --- a/code/modules/power/port_gen.dm +++ b/code/modules/power/port_gen.dm @@ -278,7 +278,6 @@ to_chat(user, span_notice("You add [amount] sheet\s to the [src.name].")) sheets += amount addstack.use(amount) - updateUsrDialog(user) return else if(!active) if(O.has_tool_quality(TOOL_WRENCH)) diff --git a/code/modules/reagents/machinery/alembic.dm b/code/modules/reagents/machinery/alembic.dm index 9257456893..f493644633 100644 --- a/code/modules/reagents/machinery/alembic.dm +++ b/code/modules/reagents/machinery/alembic.dm @@ -44,7 +44,6 @@ O.loc = src update_icon() to_chat(user, span_notice("You place the [O] in the alembic.")) - src.updateUsrDialog(user) return else if(istype(O,/obj/item/potion_base)) if(base_reagent != 0 ) @@ -56,7 +55,6 @@ O.loc = src update_icon() to_chat(user, span_notice("You place the [O] in the alembic.")) - src.updateUsrDialog(user) return else to_chat(user, span_warning("This item is no use in the alembic.")) diff --git a/code/modules/reagents/machinery/grinder.dm b/code/modules/reagents/machinery/grinder.dm index 3f1312f70a..480c449eb0 100644 --- a/code/modules/reagents/machinery/grinder.dm +++ b/code/modules/reagents/machinery/grinder.dm @@ -75,7 +75,6 @@ user.drop_item() O.loc = src update_icon() - updateUsrDialog(user) return 0 if(holdingitems && holdingitems.len >= limit) @@ -106,7 +105,6 @@ else to_chat(user, "You fill \the [src] from \the [O].") - src.updateUsrDialog(user) return 0 if(istype(O,/obj/item/gripper)) diff --git a/code/modules/reagents/machinery/injector_maker.dm b/code/modules/reagents/machinery/injector_maker.dm index 42ae73e13c..099773f6c1 100644 --- a/code/modules/reagents/machinery/injector_maker.dm +++ b/code/modules/reagents/machinery/injector_maker.dm @@ -68,7 +68,6 @@ user.drop_item() O.loc = src update_icon() - src.updateUsrDialog(user) return 0 diff --git a/code/modules/resleeving/machines.dm b/code/modules/resleeving/machines.dm index d0a3f1ac81..a954a3ae43 100644 --- a/code/modules/resleeving/machines.dm +++ b/code/modules/resleeving/machines.dm @@ -273,7 +273,6 @@ else to_chat(user, "\the [src] cannot hold more [S.name].") - updateUsrDialog(user) return /obj/machinery/transhuman/synthprinter/update_icon() @@ -379,7 +378,6 @@ var/mob/M = G.affecting if(put_mob(M)) qdel(G) - src.updateUsrDialog(user) return //Don't call up else we'll get attack messsages if(istype(W, /obj/item/paicard/sleevecard)) var/obj/item/paicard/sleevecard/C = W @@ -415,10 +413,8 @@ if(put_mob(O)) if(O == user) - updateUsrDialog(user) visible_message("[user] climbs into \the [src].") else - updateUsrDialog(user) visible_message("[user] puts [O] into \the [src].") add_fingerprint(user)