From 1e09111bca27ed98b69e161cbc2b6c53afde7faf Mon Sep 17 00:00:00 2001
From: Aroliacue <96730930+Aroliacue@users.noreply.github.com>
Date: Tue, 7 Nov 2023 22:37:46 +1000
Subject: [PATCH] Ports Old Citcode Storage Reach (#7182)

---
 code/__defines/{inventory_sizes.dm => inventory_storage.dm} | 5 +++++
 code/_onclick/click.dm                                      | 6 +++---
 code/modules/detectivework/tools/evidencebag.dm             | 2 +-
 vorestation.dme                                             | 2 +-
 4 files changed, 10 insertions(+), 5 deletions(-)
 rename code/__defines/{inventory_sizes.dm => inventory_storage.dm} (87%)

diff --git a/code/__defines/inventory_sizes.dm b/code/__defines/inventory_storage.dm
similarity index 87%
rename from code/__defines/inventory_sizes.dm
rename to code/__defines/inventory_storage.dm
index d6474a7399..359108bce2 100644
--- a/code/__defines/inventory_sizes.dm
+++ b/code/__defines/inventory_storage.dm
@@ -23,3 +23,8 @@
 #define INVENTORY_STANDARD_SPACE	ITEMSIZE_COST_NORMAL * 7 // 28
 #define INVENTORY_DUFFLEBAG_SPACE	ITEMSIZE_COST_NORMAL * 9 // 36
 #define INVENTORY_BOX_SPACE			ITEMSIZE_COST_SMALL * 7 // 14
+
+// CHOMPedit start.
+//this all needs a refactor to tg storage but for now...
+#define MAX_STORAGE_REACH 2		//maximum you can reach down to grab things from storage.
+// CHOMPedit end.
diff --git a/code/_onclick/click.dm b/code/_onclick/click.dm
index b4486fc712..5104ca2173 100644
--- a/code/_onclick/click.dm
+++ b/code/_onclick/click.dm
@@ -100,7 +100,7 @@
 	//Atoms on your person
 	// A is your location but is not a turf; or is on you (backpack); or is on something on you (box in backpack); sdepth is needed here because contents depth does not equate inventory storage depth.
 	var/sdepth = A.storage_depth(src)
-	if((!isturf(A) && A == loc) || (sdepth != -1 && sdepth <= 1))
+	if((!isturf(A) && A == loc) || (sdepth <= MAX_STORAGE_REACH)) // CHOMPedit: Boxes can be interacted with inside of larger inventories.
 		if(W)
 			var/resolved = W.resolve_attackby(A, src, click_parameters = params)
 			if(!resolved && A && W)
@@ -132,7 +132,7 @@
 	//Atoms on turfs (not on your person)
 	// A is a turf or is on a turf, or in something on a turf (pen in a box); but not something in something on a turf (pen in a box in a backpack)
 	sdepth = A.storage_depth_turf()
-	if(isturf(A) || isturf(A.loc) || (sdepth != -1 && sdepth <= 1))
+	if(isturf(A) || isturf(A.loc) || (sdepth <= MAX_STORAGE_REACH)) // CHOMPedit: Storage reach depth.
 		if(A.Adjacent(src) || (W && W.attack_can_reach(src, A, W.reach)) ) // see adjacent.dm
 			if(W)
 				// Return 1 in attackby() to prevent afterattack() effects (when safely moving items for example)
@@ -378,4 +378,4 @@
 				usr.face_atom(T)
 				return 1
 			T.Click(location, control, params)
-	return 1
\ No newline at end of file
+	return 1
diff --git a/code/modules/detectivework/tools/evidencebag.dm b/code/modules/detectivework/tools/evidencebag.dm
index 57802eed18..7e0950b650 100644
--- a/code/modules/detectivework/tools/evidencebag.dm
+++ b/code/modules/detectivework/tools/evidencebag.dm
@@ -27,7 +27,7 @@
 		//If it isn't on the floor. Do some checks to see if it's in our hands or a box. Otherwise give up.
 		if(istype(I.loc,/obj/item/weapon/storage))	//in a container.
 			var/sdepth = I.storage_depth(user)
-			if (sdepth == -1 || sdepth > 1)
+			if (sdepth > MAX_STORAGE_REACH) // CHOMPedit: Storage reach depth.
 				return	//too deeply nested to access
 
 			var/obj/item/weapon/storage/U = I.loc
diff --git a/vorestation.dme b/vorestation.dme
index 6799a01ef4..f9f2ce530c 100644
--- a/vorestation.dme
+++ b/vorestation.dme
@@ -55,7 +55,7 @@
 #include "code\__defines\input.dm"
 #include "code\__defines\instruments.dm"
 #include "code\__defines\integrated_circuits.dm"
-#include "code\__defines\inventory_sizes.dm"
+#include "code\__defines\inventory_storage.dm"
 #include "code\__defines\is_helpers.dm"
 #include "code\__defines\items_clothing.dm"
 #include "code\__defines\lighting.dm"