cyberpresidentvanellope/CHOMPStation2
1
0
Fork 0
mirror of https://github.com/CHOMPStation2/CHOMPStation2.git synced 2025-12-11 10:43:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Reduce Lists Memory usage, update CI (#10929)

Browse Source
This commit is contained in:
Cameron Lennox
2025-05-19 15:00:24 -04:00
committed by GitHub
parent f4895e74e9
commit 209934afa8
18 changed files with 122 additions and 201 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
code/_onclick/hud/alert.dm
View File

@@ -18,7 +18,7 @@
return
var/obj/screen/alert/alert
if(alerts[category])
if(LAZYACCESS(alerts, category))
alert = alerts[category]
if(new_master && new_master != alert.master)
WARNING("[src] threw alert [category] with new_master [new_master] while already having that alert with master [alert.master]")
@@ -47,7 +47,7 @@
alert.icon_state = "[initial(alert.icon_state)][severity]"
alert.severity = severity
alerts[category] = alert
LAZYSET(alerts, category, alert)
if(client && hud_used)
hud_used.reorganize_alerts()
alert.transform = matrix(32, 6, MATRIX_TRANSLATE)
@@ -59,16 +59,16 @@
return alert
/mob/proc/alert_timeout(obj/screen/alert/alert, category)
if(alert.timeout && alerts[category] == alert && world.time >= alert.timeout)
if(alert.timeout && LAZYACCESS(alerts, category) == alert && world.time >= alert.timeout)
clear_alert(category)
// Proc to clear an existing alert.
/mob/proc/clear_alert(category)
var/obj/screen/alert/alert = alerts[category]
var/obj/screen/alert/alert = LAZYACCESS(alerts, category)
if(!alert)
return 0
alerts -= category
LAZYREMOVE(alerts, category)
if(client && hud_used)
hud_used.reorganize_alerts()
client.screen -= alert
@@ -434,10 +434,10 @@ so as to remain in compliance with the most up-to-date laws."
/datum/hud/proc/reorganize_alerts()
var/list/alerts = mymob.alerts
if(!hud_shown)
for(var/i = 1, i <= alerts.len, i++)
mymob.client.screen -= alerts[alerts[i]]
return 1
for(var/i = 1, i <= alerts.len, i++)
for(var/i in 1 to length(alerts))
mymob?.client?.screen -= alerts[alerts[i]]
return TRUE
for(var/i in 1 to length(alerts))
var/obj/screen/alert/alert = alerts[alerts[i]]
if(alert.icon_state in cached_icon_states(ui_style))
@@ -467,7 +467,7 @@ so as to remain in compliance with the most up-to-date laws."
return 1
/mob
var/list/alerts = list() // contains /obj/screen/alert only // On /mob so clientless mobs will throw alerts properly
var/list/alerts = null // contains /obj/screen/alert only // On /mob so clientless mobs will throw alerts properly
/obj/screen/alert/Click(location, control, params)
if(!usr || !usr.client)

11
code/_onclick/hud/fullscreen.dm
View File

@@ -1,15 +1,16 @@
/mob
var/list/screens = list()
var/list/screens = null
/mob/proc/set_fullscreen(condition, screen_name, screen_type, arg)
condition ? overlay_fullscreen(screen_name, screen_type, arg) : clear_fullscreen(screen_name)
/mob/proc/overlay_fullscreen(category, type, severity)
var/obj/screen/fullscreen/screen = screens[category]
var/obj/screen/fullscreen/screen = LAZYACCESS(screens, category)
if (!screen || screen.type != type)
// needs to be recreated
clear_fullscreen(category, FALSE)
screens[category] = screen = new type()
screen = new type()
LAZYSET(screens, category, screen)
else if ((!severity || severity == screen.severity) && (!client || screen.screen_loc != "CENTER-7,CENTER-7" || screen.view == client.view))
// doesn't need to be updated
return screen
@@ -23,11 +24,11 @@
return screen
/mob/proc/clear_fullscreen(category, animated = 10)
var/obj/screen/fullscreen/screen = screens[category]
var/obj/screen/fullscreen/screen = LAZYACCESS(screens, category)
if(!screen)
return
screens -= category
LAZYREMOVE(screens, category)
if(animated)
spawn(0)