Merge pull request #1668 from VOREStation/aro-roundquit

Adds 'Quit This Round' verb for ghosts

code/modules/mob/dead/observer/free_vr.dm

@@ -0,0 +1,68 @@
+var/global/list/prevent_respawns = list()
+
+/hook/death/proc/quit_notify(mob/dead)
+	if(ishuman(dead))
+		to_chat(dead,"<span class='notice'>You're dead! If you don't intend to continue playing this round as this character, please use the <b>Quit This Round</b> verb in the OOC tab to free your job slot.</span>")
+
+	return TRUE
+
+/mob/observer/dead/verb/cleanup()
+	set name = "Quit This Round"
+	set category = "OOC"
+	set desc = "Free your job slot, remove yourself from the manifest, and prevent respawning as this character for this round."
+
+	var/confirm = alert("This will free up your job slot, remove you from the manifest, and prevent you from respawning with this character for the round. You can rejoin as another \
+	character if you like. Do this now?","Quit This Round","Quit Round","Cancel")
+	if(confirm != "Quit Round")
+		return
+
+	//Why are you clicking this button?
+	if(!mind || !mind.assigned_role)
+		to_chat(src,"<span class='warning'>Either you haven't played this round, or you already used this verb.</span>")
+		return
+
+	//Add them to the nope list
+	prevent_respawns += mind.name
+
+	//Update any existing objectives involving this mob.
+	for(var/datum/objective/O in all_objectives)
+		if(O.target == src.mind)
+			if(O.owner && O.owner.current)
+				to_chat(O.owner.current,"<span class='warning'>You get the feeling your target is no longer within your reach...</span>")
+			qdel(O)
+
+	//Resleeving cleanup
+	if(src.mind.name in transcore.backed_up)
+		var/datum/transhuman/mind_record/MR = transcore.backed_up[src.mind.name]
+		transcore.stop_backup(MR)
+	if(src.mind.name in transcore.body_scans) //This uses mind names to avoid people cryo'ing a printed body to delete body scans.
+		var/datum/transhuman/body_record/BR = transcore.body_scans[src.mind.name]
+		transcore.remove_body(BR)
+
+	//Job slot cleanup
+	var/job = src.mind.assigned_role
+	job_master.FreeRole(job)
+
+	//Their objectives cleanup
+	if(src.mind.objectives.len)
+		qdel(src.mind.objectives)
+		src.mind.special_role = null
+
+	//Cut the PDA manifest (ugh)
+	if(PDA_Manifest.len)
+		PDA_Manifest.Cut()
+	for(var/datum/data/record/R in data_core.medical)
+		if((R.fields["name"] == src.real_name))
+			qdel(R)
+	for(var/datum/data/record/T in data_core.security)
+		if((T.fields["name"] == src.real_name))
+			qdel(T)
+	for(var/datum/data/record/G in data_core.general)
+		if((G.fields["name"] == src.real_name))
+			qdel(G)
+
+	//This removes them from being 'active' list on join screen
+	src.mind.assigned_role = null
+
+	//Feedback
+	to_chat(src,"<span class='notice'>Your job has been free'd up, and you can rejoin as another character or quit. Thanks for using this verb, it helps the server!</span>")

code/modules/mob/dead/observer/observer.dm

@@ -255,6 +255,11 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
 	if(mind.current.key && copytext(mind.current.key,1,2)!="@")	//makes sure we don't accidentally kick any clients
 		usr << "<span class='warning'>Another consciousness is in your body... it is resisting you.</span>"
 		return
+	//VOREStation Add
+	if(prevent_respawns.Find(mind.name))
+		to_chat(usr,"<span class='warning'>You already quit this round as this character, sorry!</span>")
+		return
+	//VOREStation Add End
 	if(mind.current.ajourn && mind.current.stat != DEAD) //check if the corpse is astral-journeying (it's client ghosted using a cultist rune).
 		var/found_rune
 		for(var/obj/effect/rune/R in mind.current.loc)   //whilst corpse is alive, we can only reenter the body if it's on the rune

code/modules/mob/new_player/new_player_vr.dm

@@ -3,7 +3,12 @@
 
 	//No OOC notes
 	if (config.allow_Metadata && client && client.prefs && (isnull(client.prefs.metadata) || length(client.prefs.metadata) < 15))
-		src << "<span class='warning'>Please set informative OOC notes related to ERP preferences. Set them using the 'OOC Notes' button on the 'General' tab in character setup.</span>"
+		to_chat(src,"<span class='warning'>Please set informative OOC notes related to ERP preferences. Set them using the 'OOC Notes' button on the 'General' tab in character setup.</span>")
+		pass = FALSE
+
+	//Are they on the VERBOTEN LIST?
+	if (prevent_respawns.Find(client.prefs.real_name))
+		to_chat(src,"<span class='warning'>You've already quit the round as this character. You can't go back now that you've free'd your job slot. Play another character, or wait for the next round.</span>")
 		pass = FALSE
 
 	//Custom species checks
@@ -12,7 +17,7 @@
 		//Didn't name it
 		if(!client.prefs.custom_species)
 			pass = FALSE
-			src << "<span class='warning'>You have to name your custom species. Do this on the VORE tab in character setup.</span>"
+			to_chat(src,"<span class='warning'>You have to name your custom species. Do this on the VORE tab in character setup.</span>")
 
 		//Check traits/costs
 		var/list/megalist = client.prefs.pos_traits + client.prefs.neu_traits + client.prefs.neg_traits
@@ -25,7 +30,7 @@
 			//A trait was removed from the game
 			if(isnull(cost))
 				pass = FALSE
-				src << "<span class='warning'>Your custom species is not playable. One or more traits appear to have been removed from the game or renamed. Enter character setup to correct this.</span>"
+				to_chat(src,"<span class='warning'>Your custom species is not playable. One or more traits appear to have been removed from the game or renamed. Enter character setup to correct this.</span>")
 				break
 			else
 				points_left -= traits_costs[T]
@@ -33,7 +38,7 @@
 		//Went into negatives
 		if(points_left < 0 || traits_left < 0)
 			pass = FALSE
-			src << "<span class='warning'>Your custom species is not playable. Reconfigure your traits on the VORE tab.</span>"
+			to_chat(src,"<span class='warning'>Your custom species is not playable. Reconfigure your traits on the VORE tab.</span>")
 
 	//Final popup notice
 	if (!pass)