[MIRROR] var/global/list -> GLOB. conversion (#11193)

Co-authored-by: Cameron Lennox <killer65311@gmail.com>
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>

code/game/objects/items/devices/ai_detector.dm

@@ -37,7 +37,7 @@
 	var/mob/living/carrier = isliving(loc) ? loc : null
 
 	// First, let's check if any AIs are actively tracking them.
-	for(var/mob/living/silicon/ai/AI in silicon_mob_list)
+	for(var/mob/living/silicon/ai/AI in GLOB.silicon_mob_list)
 		if(carrier && AI.cameraFollow == carrier)
 			if(!carrier.tracking_status()) // Successful tracking returns a 0, so we need to invert it.
 				return PROXIMITY_TRACKING

code/game/objects/items/devices/communicator/UI_tgui.dm

@@ -384,7 +384,7 @@
 				log_pda("(COMM: [src]) sent \"[text]\" to [exonet.get_atom_from_address(their_address)]", ui.user)
 				var/obj/item/communicator/comm = exonet.get_atom_from_address(their_address)
 				to_chat(ui.user, span_notice("[icon2html(src, ui.user.client)] Sent message to [istype(comm, /obj/item/communicator) ? comm.owner : comm.name], <b>\"[text]\"</b> (<a href='byond://?src=\ref[src];action=Reply;target=\ref[exonet.get_atom_from_address(comm.exonet.address)]'>Reply</a>)"))
-				for(var/mob/M in player_list)
+				for(var/mob/M in GLOB.player_list)
 					if(M.stat == DEAD && M.client?.prefs?.read_preference(/datum/preference/toggle/ghost_ears))
 						if(isnewplayer(M) || M.forbid_seeing_deadchat)
 							continue

code/game/objects/items/devices/communicator/communicator.dm

@@ -2,8 +2,6 @@
 //
 // Allows ghosts to roleplay with crewmembers without having to commit to joining the round, and also allows communications between two communicators.
 
-var/global/list/obj/item/communicator/all_communicators = list() //Don't change this to GLOBAL_LIST_EMPTY_TYPED(all_communicators, /obj/item/communicator) for now. Sortatoms goes berserk.
-
 // List of core tabs the communicator can switch to
 #define HOMETAB 1
 #define PHONTAB 2
@@ -100,7 +98,7 @@ var/global/list/obj/item/communicator/all_communicators = list() //Don't change
 /obj/item/communicator/Initialize(mapload)
 	. = ..()
 	all_communicators += src
-	all_communicators = sortAtom(all_communicators)
+	all_communicators = sort_names(all_communicators)
 	node = get_exonet_node()
 	START_PROCESSING(SSobj, src)
 	camera = new(src)
@@ -276,7 +274,7 @@ var/global/list/obj/item/communicator/all_communicators = list() //Don't change
 		if(!comm || !comm.exonet || !comm.exonet.address || comm.exonet.address == src.exonet.address) //Don't add addressless devices, and don't add ourselves.
 			continue
 		src.known_devices |= comm
-	for(var/mob/observer/dead/O in dead_mob_list)
+	for(var/mob/observer/dead/O in GLOB.dead_mob_list)
 		if(!O.client || O.client.prefs.communicator_visibility == 0)
 			continue
 		src.known_devices |= O
@@ -416,7 +414,7 @@ var/global/list/obj/item/communicator/all_communicators = list() //Don't change
 	//Clean up references that might point at us
 	all_communicators -= src
 	STOP_PROCESSING(SSobj, src)
-	listening_objects.Remove(src)
+	GLOB.listening_objects.Remove(src)
 	QDEL_NULL(camera)
 	QDEL_NULL(exonet)
 

code/game/objects/items/devices/communicator/helper.dm

@@ -171,7 +171,7 @@
 // Weaker than what PDAs appear to do, but as of 7/1/2018 PDA secbot access is nonfunctional
 /obj/item/commcard/proc/get_sec_bot_access()
 	var/sec_bots[0]
-	for(var/mob/living/bot/secbot/S in mob_list)
+	for(var/mob/living/bot/secbot/S in GLOB.mob_list)
 		// Get new bot
 		var/status[0]
 		status[++status.len] = list("tab" = "Name", "val" = sanitize(S.name))
@@ -312,7 +312,7 @@
 				janidata[++janidata.len] = list("field" = apply_text_macros("\proper [C.name]"), "val" = span_yellow("[T.x], [T.y], [using_map.get_zlevel_name(T.z)]"))
 
 	// Cleanbots
-	for(var/mob/living/bot/cleanbot/B in living_mob_list)
+	for(var/mob/living/bot/cleanbot/B in GLOB.living_mob_list)
 		var/turf/T = get_turf(B)
 		if(isturf(T) )//&& T.z in using_map.get_map_levels(userloc, FALSE))
 			var/textout = ""

code/game/objects/items/devices/communicator/messaging.dm

@@ -128,7 +128,7 @@
 	if (usr != src)
 		return //something is terribly wrong
 
-	for(var/mob/living/L in mob_list) //Simple check so you don't have dead people calling.
+	for(var/mob/living/L in GLOB.mob_list) //Simple check so you don't have dead people calling.
 		if(src.client.prefs.real_name == L.real_name)
 			to_chat(src, span_danger("Your identity is already present in the game world.  Please load in a different character first."))
 			return
@@ -160,7 +160,7 @@
 			to_chat(src, span_notice("You have sent '[text_message]' to [chosen_communicator]."))
 			exonet_messages.Add(span_bold("To [chosen_communicator]:") + "<br>[text_message]")
 			log_pda("(DCOMM: [src]) sent \"[text_message]\" to [chosen_communicator]", src)
-			for(var/mob/M in player_list)
+			for(var/mob/M in GLOB.player_list)
 				if(M.stat == DEAD && M.client?.prefs?.read_preference(/datum/preference/toggle/ghost_ears))
 					if(isnewplayer(M) || M.forbid_seeing_deadchat)
 						continue

code/game/objects/items/devices/communicator/phone.dm

@@ -5,7 +5,7 @@
 	if(!comm || !istype(comm)) return
 
 	communicating |= comm
-	listening_objects |= src
+	GLOB.listening_objects |= src
 	update_icon()
 
 // Proc: del_communicating()
@@ -73,7 +73,7 @@
 	new_voice.mind = candidate.mind			//Transfer the mind, if any.
 	new_voice.ckey = candidate.ckey			//Finally, bring the client over.
 	voice_mobs.Add(new_voice)
-	listening_objects |= src
+	GLOB.listening_objects |= src
 
 	var/obj/screen/blackness = new() 	//Makes a black screen, so the candidate can't see what's going on before actually 'connecting' to the communicator.
 	blackness.screen_loc = ui_entire_screen
@@ -139,7 +139,7 @@
 			comm.end_video()
 
 	if(voice_mobs.len == 0 && communicating.len == 0)
-		listening_objects.Remove(src)
+		GLOB.listening_objects.Remove(src)
 
 // Proc: request()
 // Parameters: 1 (candidate - the ghost or communicator wanting to call the device)
@@ -294,7 +294,7 @@
 		to_chat(src, span_danger("You have used the antagHUD and cannot respawn or use communicators!"))
 		return
 
-	for(var/mob/living/L in mob_list) //Simple check so you don't have dead people calling.
+	for(var/mob/living/L in GLOB.mob_list) //Simple check so you don't have dead people calling.
 		if(src.client.prefs.real_name == L.real_name)
 			to_chat(src, span_danger("Your identity is already present in the game world.  Please load in a different character first."))
 			return

code/game/objects/items/devices/defib.dm

@@ -488,10 +488,10 @@
 	add_attack_logs(user,H,"Shocked using [name]")
 
 /obj/item/shockpaddles/proc/make_alive(mob/living/carbon/human/M) //This revives the mob
-	dead_mob_list.Remove(M)
-	if((M in living_mob_list) || (M in dead_mob_list))
+	GLOB.dead_mob_list.Remove(M)
+	if((M in GLOB.living_mob_list) || (M in GLOB.dead_mob_list))
 		WARNING("Mob [M] was defibbed but already in the living or dead list still!")
-	living_mob_list += M
+	GLOB.living_mob_list += M
 
 	M.timeofdeath = 0
 	M.set_stat(UNCONSCIOUS) //Life() can bring them back to consciousness if it needs to.

code/game/objects/items/devices/paicard.dm

@@ -1,23 +1,3 @@
-var/global/list/radio_channels_by_freq = list(
-	num2text(PUB_FREQ) = CHANNEL_COMMON,
-	num2text(AI_FREQ)  = CHANNEL_AI_PRIVATE,
-	num2text(ENT_FREQ) = CHANNEL_ENTERTAINMENT,
-	num2text(ERT_FREQ) = CHANNEL_RESPONSE_TEAM,
-	num2text(COMM_FREQ)= CHANNEL_COMMAND,
-	num2text(ENG_FREQ) = CHANNEL_ENGINEERING,
-	num2text(MED_FREQ) = CHANNEL_MEDICAL,
-	num2text(MED_I_FREQ)=CHANNEL_MEDICAL_1,
-	num2text(BDCM_FREQ) =CHANNEL_BODYCAM, // CHOMPEdit
-	num2text(SEC_FREQ) = CHANNEL_SECURITY,
-	num2text(SEC_I_FREQ)=CHANNEL_SECURITY_1,
-	num2text(SCI_FREQ) = CHANNEL_SCIENCE,
-	num2text(SUP_FREQ) = CHANNEL_SUPPLY,
-	num2text(SRV_FREQ) = CHANNEL_SERVICE,
-	num2text(EXP_FREQ) = CHANNEL_EXPLORATION
-	)
-
-GLOBAL_LIST_BOILERPLATE(all_pai_cards, /obj/item/paicard)
-
 /obj/item/paicard
 	name = "personal AI device"
 	icon = 'icons/obj/pda.dmi'
@@ -74,7 +54,7 @@ GLOBAL_LIST_BOILERPLATE(all_pai_cards, /obj/item/paicard)
 		to_chat(user,span_warning("You cannot join a pAI card when you are banned from playing as a pAI."))
 		return
 
-	for(var/ourkey in paikeys)
+	for(var/ourkey in GLOB.paikeys)
 		if(ourkey == user.ckey)
 			to_chat(user, span_warning("You can't just rejoin any old pAI card!!! Your card still exists."))
 			return
@@ -97,14 +77,14 @@ GLOBAL_LIST_BOILERPLATE(all_pai_cards, /obj/item/paicard)
 			var/obj/item/paicard/typeb/card = new(location)
 			var/mob/living/silicon/pai/new_pai = new(card)
 			new_pai.key = user.key
-			paikeys |= new_pai.ckey
+			GLOB.paikeys |= new_pai.ckey
 			card.setPersonality(new_pai)
 			new_pai.SetName(actual_pai_name)
 		else
 			var/obj/item/paicard/card = new(location)
 			var/mob/living/silicon/pai/new_pai = new(card)
 			new_pai.key = user.key
-			paikeys |= new_pai.ckey
+			GLOB.paikeys |= new_pai.ckey
 			card.setPersonality(new_pai)
 			new_pai.SetName(actual_pai_name)
 
@@ -113,7 +93,7 @@ GLOBAL_LIST_BOILERPLATE(all_pai_cards, /obj/item/paicard)
 			var/obj/item/paicard/typeb/card = new(location)
 			var/mob/living/silicon/pai/new_pai = new(card)
 			new_pai.key = user.key
-			paikeys |= new_pai.ckey
+			GLOB.paikeys |= new_pai.ckey
 			card.setPersonality(new_pai)
 			if(!new_pai.savefile_load(new_pai))
 				var/pai_name = tgui_input_text(new_pai, "Choose your character's name", "Character Name")
@@ -125,7 +105,7 @@ GLOBAL_LIST_BOILERPLATE(all_pai_cards, /obj/item/paicard)
 			var/obj/item/paicard/card = new(location)
 			var/mob/living/silicon/pai/new_pai = new(card)
 			new_pai.key = user.key
-			paikeys |= new_pai.ckey
+			GLOB.paikeys |= new_pai.ckey
 			card.setPersonality(new_pai)
 			if(!new_pai.savefile_load(new_pai))
 				var/pai_name = tgui_input_text(new_pai, "Choose your character's name", "Character Name")
@@ -520,7 +500,7 @@ GLOBAL_LIST_BOILERPLATE(all_pai_cards, /obj/item/paicard)
 	channels = list()
 
 	for(var/internal_chan in internal_channels)
-		var/ch_name = radio_channels_by_freq[internal_chan]
+		var/ch_name = GLOB.radio_channels_by_freq[internal_chan]
 		if(has_channel_access(card.pai, internal_chan))
 			channels += ch_name
 			channels[ch_name] = 1

code/game/objects/items/devices/paicard_vr.dm

@@ -1,4 +1,4 @@
-var/global/list/paikeys = list()
+GLOBAL_LIST_EMPTY(paikeys)
 
 /obj/item/paicard
 	var/panel_open = FALSE

code/game/objects/items/devices/pipe_painter.dm

@@ -11,7 +11,7 @@
 /obj/item/pipe_painter/Initialize(mapload)
 	. = ..()
 	modes = new()
-	for(var/C in pipe_colors)
+	for(var/C in GLOB.pipe_colors)
 		modes += "[C]"
 	mode = pick(modes)
 
@@ -23,7 +23,7 @@
 		return
 	var/obj/machinery/atmospherics/pipe/P = A
 
-	P.change_color(pipe_colors[mode])
+	P.change_color(GLOB.pipe_colors[mode])
 
 /obj/item/pipe_painter/attack_self(mob/user as mob)
 	var/new_mode = tgui_input_list(user, "Which colour do you want to use?", "Pipe painter", modes)

code/game/objects/items/devices/radio/intercom.dm

@@ -94,7 +94,7 @@
 
 /obj/item/radio/intercom/department/medbay/Initialize(mapload)
 	. = ..()
-	internal_channels = default_medbay_channels.Copy()
+	internal_channels = GLOB.default_medbay_channels.Copy()
 
 /obj/item/radio/intercom/department/security/Initialize(mapload)
 	. = ..()

code/game/objects/items/devices/radio/jammer.dm

@@ -1,4 +1,4 @@
-var/global/list/active_radio_jammers = list()
+GLOBAL_LIST_EMPTY(active_radio_jammers)
 
 /proc/is_jammed(var/obj/radio)
 	var/turf/Tr = get_turf(radio)
@@ -9,7 +9,7 @@ var/global/list/active_radio_jammers = list()
 	if(our_area.no_comms)
 		return TRUE
 
-	for(var/obj/item/radio_jammer/J as anything in active_radio_jammers)
+	for(var/obj/item/radio_jammer/J as anything in GLOB.active_radio_jammers)
 		var/turf/Tj = get_turf(J)
 
 		if(J.on && Tj.z == Tr.z) //If we're on the same Z, it's worth checking.
@@ -52,7 +52,7 @@ var/global/list/active_radio_jammers = list()
 	if(user)
 		to_chat(user,span_warning("\The [src] deactivates."))
 	STOP_PROCESSING(SSobj, src)
-	active_radio_jammers -= src
+	GLOB.active_radio_jammers -= src
 	on = FALSE
 	update_icon()
 
@@ -60,7 +60,7 @@ var/global/list/active_radio_jammers = list()
 	if(user)
 		to_chat(user,span_notice("\The [src] is now active."))
 	START_PROCESSING(SSobj, src)
-	active_radio_jammers += src
+	GLOB.active_radio_jammers += src
 	on = TRUE
 	update_icon()
 

code/game/objects/items/devices/radio/radio.dm

@@ -1,29 +1,4 @@
 #define CANBROADCAST_INNERBOX 0.7071067811865476	//This is sqrt(2)/2
-// Access check is of the type requires one. These have been carefully selected to avoid allowing the janitor to see channels he shouldn't
-var/global/list/default_internal_channels = list(
-	num2text(PUB_FREQ) = list(),
-	num2text(AI_FREQ)  = list(access_synth),
-	num2text(ENT_FREQ) = list(),
-	num2text(ERT_FREQ) = list(access_cent_specops),
-	num2text(COMM_FREQ)= list(access_heads),
-	num2text(ENG_FREQ) = list(access_engine_equip, access_atmospherics),
-	num2text(MED_FREQ) = list(access_medical_equip),
-	num2text(MED_I_FREQ)=list(access_medical_equip),
-	num2text(BDCM_FREQ) =list(access_security), // CHOMPEdit
-
-	num2text(SEC_FREQ) = list(access_security),
-	num2text(SEC_I_FREQ)=list(access_security),
-	num2text(SCI_FREQ) = list(access_tox, access_robotics, access_xenobiology),
-	num2text(SUP_FREQ) = list(access_cargo, access_mining_station),
-	num2text(SRV_FREQ) = list(access_janitor, access_library, access_hydroponics, access_bar, access_kitchen),
-	num2text(EXP_FREQ) = list(access_explorer, access_pilot) //CHOMP explo keep
-)
-
-var/global/list/default_medbay_channels = list(
-	num2text(PUB_FREQ) = list(),
-	num2text(MED_FREQ) = list(),
-	num2text(MED_I_FREQ) = list()
-)
 
 /obj/item/radio
 	icon = 'icons/obj/radio_vr.dmi'
@@ -85,8 +60,8 @@ var/global/list/default_medbay_channels = list(
 		secure_radio_connections[ch_name] = radio_controller.add_object(src, radiochannels[ch_name],  RADIO_CHAT)
 
 	wires = new(src)
-	internal_channels = default_internal_channels.Copy()
-	listening_objects += src
+	internal_channels = GLOB.default_internal_channels.Copy()
+	GLOB.listening_objects += src
 
 	if(bluespace_radio && (bs_tx_preload_id || bs_rx_preload_id))
 		return INITIALIZE_HINT_LATELOAD
@@ -130,7 +105,7 @@ var/global/list/default_medbay_channels = list(
 /obj/item/radio/Destroy()
 	qdel(wires)
 	wires = null
-	listening_objects -= src
+	GLOB.listening_objects -= src
 	if(radio_controller)
 		radio_controller.remove_object(src, frequency)
 		for (var/ch_name in channels)
@@ -768,7 +743,7 @@ GLOBAL_DATUM(autospeaker, /mob/living/silicon/ai/announcer)
 
 /obj/item/radio/phone/medbay/Initialize(mapload)
 	. = ..()
-	internal_channels = default_medbay_channels.Copy()
+	internal_channels = GLOB.default_medbay_channels.Copy()
 
 /obj/item/radio/proc/can_broadcast_to()
 	var/list/output = list()

code/game/objects/items/devices/radio/radio_vr.dm

@@ -12,7 +12,7 @@
 
 /obj/item/radio/emergency/Initialize(mapload)
 	. = ..()
-	internal_channels = default_medbay_channels.Copy()
+	internal_channels = GLOB.default_medbay_channels.Copy()
 
 
 

code/game/objects/items/devices/scanners/sleevemate.dm

@@ -197,7 +197,7 @@ var/global/mob/living/carbon/human/dummy/mannequin/sleevemate_mob
 		return
 
 	var/target_ref = href_list["target"]
-	var/mob/living/target = locate(target_ref) in mob_list
+	var/mob/living/target = locate(target_ref) in GLOB.mob_list
 	if(!target)
 		to_chat(usr,span_warning("Unable to operate on that target."))
 		return

code/game/objects/items/devices/t_scanner.dm

@@ -1,4 +1,4 @@
-#define OVERLAY_CACHE_LEN 50
+#define overlay_cache_LEN 50
 
 /obj/item/t_scanner
 	name = "\improper T-ray scanner"
@@ -18,8 +18,6 @@
 	var/client/user_client //since making sure overlays are properly added and removed is pretty important, so we track the current user explicitly
 	var/flicker = 0
 
-	var/global/list/overlay_cache = list() //cache recent overlays
-
 	pickup_sound = 'sound/items/pickup/device.ogg'
 	drop_sound = 'sound/items/drop/device.ogg'
 
@@ -82,8 +80,8 @@
 /obj/item/t_scanner/proc/get_overlay(obj/scanned)
 	//Use a cache so we don't create a whole bunch of new images just because someone's walking back and forth in a room.
 	//Also means that images are reused if multiple people are using t-rays to look at the same objects.
-	if(scanned in overlay_cache)
-		. = overlay_cache[scanned]
+	if(scanned in GLOB.overlay_cache)
+		. = GLOB.overlay_cache[scanned]
 	else
 		var/image/I = image(loc = scanned, icon = scanned.icon, icon_state = scanned.icon_state, layer = HUD_LAYER)
 
@@ -98,9 +96,9 @@
 		. = I
 
 	// Add it to cache, cutting old entries if the list is too long
-	overlay_cache[scanned] = .
-	if(overlay_cache.len > OVERLAY_CACHE_LEN)
-		overlay_cache.Cut(1, overlay_cache.len-OVERLAY_CACHE_LEN-1)
+	GLOB.overlay_cache[scanned] = .
+	if(GLOB.overlay_cache.len > overlay_cache_LEN)
+		GLOB.overlay_cache.Cut(1, GLOB.overlay_cache.len-overlay_cache_LEN-1)
 
 /obj/item/t_scanner/proc/get_scanned_objects(var/scan_dist)
 	. = list()
@@ -152,4 +150,4 @@
 	scan_range = 7
 
 
-#undef OVERLAY_CACHE_LEN
+#undef overlay_cache_LEN

code/game/objects/items/devices/taperecorder.dm

@@ -26,13 +26,13 @@
 	if(ispath(mytape))
 		mytape = new mytape(src)
 		update_icon()
-	listening_objects += src
+	GLOB.listening_objects += src
 
 /obj/item/taperecorder/empty
 	mytape = null
 
 /obj/item/taperecorder/Destroy()
-	listening_objects -= src
+	GLOB.listening_objects -= src
 	if(mytape)
 		qdel(mytape)
 		mytape = null

code/game/objects/items/devices/translator.dm

@@ -24,13 +24,13 @@
 				return
 			else
 				listening = 1
-				listening_objects |= src
+				GLOB.listening_objects |= src
 				if(mult_icons)
 					icon_state = "[initial(icon_state)]1"
 				to_chat(user, span_notice("You enable \the [src], translating into [langset.name]."))
 	else	//Turning OFF
 		listening = 0
-		listening_objects -= src
+		GLOB.listening_objects -= src
 		langset = null
 		icon_state = "[initial(icon_state)]"
 		to_chat(user, span_notice("You disable \the [src]."))

code/game/objects/items/devices/tvcamera.dm

@@ -16,10 +16,10 @@
 
 /obj/item/tvcamera/Initialize(mapload)
 	. = ..()
-	listening_objects += src
+	GLOB.listening_objects += src
 
 /obj/item/tvcamera/Destroy()
-	listening_objects -= src
+	GLOB.listening_objects -= src
 	qdel(camera)
 	qdel(radio)
 	camera = null
@@ -180,10 +180,10 @@
 
 /obj/item/clothing/accessory/bodycam/Initialize(mapload)
 	. = ..()
-	listening_objects += src
+	GLOB.listening_objects += src
 
 /obj/item/clothing/accessory/bodycam/Destroy()
-	listening_objects -= src
+	GLOB.listening_objects -= src
 	qdel(bcamera)
 	qdel(bradio)
 	bcamera = null