From 65354508d7ff8cc2b658a47f48845d0df61326b1 Mon Sep 17 00:00:00 2001 From: Atlantiscze Date: Thu, 17 Jul 2014 16:46:05 +0200 Subject: [PATCH 01/13] Fixes incorrect units in Radiocarbon Spectrometer's GUI. 1 GHz = 1 000 MHz = 1 000 000 kHz --- nano/templates/geoscanner.tmpl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/nano/templates/geoscanner.tmpl b/nano/templates/geoscanner.tmpl index d3205e2ebe..1f8e1e0600 100644 --- a/nano/templates/geoscanner.tmpl +++ b/nano/templates/geoscanner.tmpl @@ -87,14 +87,14 @@ Used In File(s): \code\modules\research\xenoarchaeology\machinery\geosample_scan {{:maser_wavelength}} MHz
- {{:~link('-2 KHz', null, {'maserWavelength' : -2}, null)}} - {{:~link('-1 KHz', null, {'maserWavelength' : -1}, null)}} - {{:~link('-0.5 KHz', null, {'maserWavelength' : -0.5}, null)}} + {{:~link('-2 GHz', null, {'maserWavelength' : -2}, null)}} + {{:~link('-1 GHz', null, {'maserWavelength' : -1}, null)}} + {{:~link('-0.5 GHz', null, {'maserWavelength' : -0.5}, null)}}
- {{:~link('+0.5 KHz', null, {'maserWavelength' : 0.5}, null)}} - {{:~link('+1 KHz', null, {'maserWavelength' : 1}, null)}} - {{:~link('+2 KHz', null, {'maserWavelength' : 2}, null)}} + {{:~link('+0.5 GHz', null, {'maserWavelength' : 0.5}, null)}} + {{:~link('+1 GHz', null, {'maserWavelength' : 1}, null)}} + {{:~link('+2 GHz', null, {'maserWavelength' : 2}, null)}}
From 3209cb49a6fa55d09843061c57df3f26eaf73b95 Mon Sep 17 00:00:00 2001 From: mwerezak Date: Thu, 17 Jul 2014 19:30:00 -0400 Subject: [PATCH 02/13] Removes Rootspeak from AI and robot languages --- code/modules/mob/living/silicon/ai/ai.dm | 1 - code/modules/mob/living/silicon/robot/robot_modules.dm | 1 - 2 files changed, 2 deletions(-) diff --git a/code/modules/mob/living/silicon/ai/ai.dm b/code/modules/mob/living/silicon/ai/ai.dm index b34f7aa641..71267a4d45 100644 --- a/code/modules/mob/living/silicon/ai/ai.dm +++ b/code/modules/mob/living/silicon/ai/ai.dm @@ -100,7 +100,6 @@ var/list/ai_list = list() add_language("Siik'maas", 0) add_language("Siik'tajr", 0) add_language("Skrellian", 0) - add_language("Rootspeak", 0) add_language("Tradeband", 1) add_language("Gutter", 0) diff --git a/code/modules/mob/living/silicon/robot/robot_modules.dm b/code/modules/mob/living/silicon/robot/robot_modules.dm index 0eadb02860..728c6d2b79 100644 --- a/code/modules/mob/living/silicon/robot/robot_modules.dm +++ b/code/modules/mob/living/silicon/robot/robot_modules.dm @@ -47,7 +47,6 @@ R.add_language("Siik'maas", 0) R.add_language("Siik'tajr", 0) R.add_language("Skrellian", 0) - R.add_language("Rootspeak", 0) R.add_language("Tradeband", 0) R.add_language("Gutter", 0) From 21b274208698b51263868ff50e8f887f0af1d4c4 Mon Sep 17 00:00:00 2001 From: mwerezak Date: Thu, 17 Jul 2014 19:59:07 -0400 Subject: [PATCH 03/13] Adds default values for some docking tags Simplifies the mapping of docking controllers by cutting down on the number of tags needed to be entered. --- .../game/machinery/embedded_controller/airlock_program.dm | 8 ++++---- .../embedded_controller/simple_docking_controller.dm | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/code/game/machinery/embedded_controller/airlock_program.dm b/code/game/machinery/embedded_controller/airlock_program.dm index 29b93b3583..627f9844a3 100644 --- a/code/game/machinery/embedded_controller/airlock_program.dm +++ b/code/game/machinery/embedded_controller/airlock_program.dm @@ -35,10 +35,10 @@ if (istype(M, /obj/machinery/embedded_controller/radio/airlock)) //if our controller is an airlock controller than we can auto-init our tags var/obj/machinery/embedded_controller/radio/airlock/controller = M - tag_exterior_door = controller.tag_exterior_door - tag_interior_door = controller.tag_interior_door - tag_airpump = controller.tag_airpump - tag_chamber_sensor = controller.tag_chamber_sensor + tag_exterior_door = controller.tag_exterior_door? controller.tag_exterior_door : "[id_tag]_outer" + tag_interior_door = controller.tag_interior_door? controller.tag_interior_door : "[id_tag]_inner" + tag_airpump = controller.tag_airpump? controller.tag_airpump : "[id_tag]_pump" + tag_chamber_sensor = controller.tag_chamber_sensor? controller.tag_chamber_sensor : "[id_tag]_sensor" tag_exterior_sensor = controller.tag_exterior_sensor tag_interior_sensor = controller.tag_interior_sensor memory["secure"] = controller.tag_secure diff --git a/code/game/machinery/embedded_controller/simple_docking_controller.dm b/code/game/machinery/embedded_controller/simple_docking_controller.dm index 877247799b..a8a4ad490f 100644 --- a/code/game/machinery/embedded_controller/simple_docking_controller.dm +++ b/code/game/machinery/embedded_controller/simple_docking_controller.dm @@ -58,7 +58,7 @@ if (istype(M, /obj/machinery/embedded_controller/radio/simple_docking_controller)) var/obj/machinery/embedded_controller/radio/simple_docking_controller/controller = M - tag_door = controller.tag_door + tag_door = controller.tag_door? controller.tag_door : "[id_tag]_hatch" spawn(10) signal_door("update") //signals connected doors to update their status From 3ea7e0ce3cd14fbbd06d8330e51f9a07a070e2ad Mon Sep 17 00:00:00 2001 From: mwerezak Date: Thu, 17 Jul 2014 20:07:13 -0400 Subject: [PATCH 04/13] Adds a name for the escape pod controller --- .../embedded_controller/escape_pod_docking_controller.dm | 1 + 1 file changed, 1 insertion(+) diff --git a/code/game/machinery/embedded_controller/escape_pod_docking_controller.dm b/code/game/machinery/embedded_controller/escape_pod_docking_controller.dm index f84fbf0b32..5034859128 100644 --- a/code/game/machinery/embedded_controller/escape_pod_docking_controller.dm +++ b/code/game/machinery/embedded_controller/escape_pod_docking_controller.dm @@ -1,5 +1,6 @@ //This controller goes on the escape pod itself /obj/machinery/embedded_controller/radio/simple_docking_controller/escape_pod + name = "escape pod controller" var/datum/shuttle/ferry/escape_pod/pod /obj/machinery/embedded_controller/radio/simple_docking_controller/escape_pod/ui_interact(mob/user, ui_key = "main", var/datum/nanoui/ui = null) From 7361c7da45c03f92e9bf4b5a9fb47d62e66782a5 Mon Sep 17 00:00:00 2001 From: mwerezak Date: Thu, 17 Jul 2014 21:55:05 -0400 Subject: [PATCH 05/13] Loosens the undocking requirements for airlocks --- .../embedded_controller/airlock_docking_controller.dm | 4 +++- .../machinery/embedded_controller/airlock_program.dm | 10 ++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/code/game/machinery/embedded_controller/airlock_docking_controller.dm b/code/game/machinery/embedded_controller/airlock_docking_controller.dm index 0e9877d797..6edf07e221 100644 --- a/code/game/machinery/embedded_controller/airlock_docking_controller.dm +++ b/code/game/machinery/embedded_controller/airlock_docking_controller.dm @@ -108,7 +108,9 @@ //are we ready for undocking? /datum/computer/file/embedded_program/docking/airlock/ready_for_undocking() - return airlock_program.check_doors_secured() + var/ext_closed = airlock_program.check_exterior_door_secured() + var/int_closed = airlock_program.check_interior_door_secured() + return (ext_closed || int_closed) //An airlock controller to be used by the airlock-based docking port controller. //Same as a regular airlock controller but allows disabling of the regular airlock functions when docking diff --git a/code/game/machinery/embedded_controller/airlock_program.dm b/code/game/machinery/embedded_controller/airlock_program.dm index 627f9844a3..3d7d306df3 100644 --- a/code/game/machinery/embedded_controller/airlock_program.dm +++ b/code/game/machinery/embedded_controller/airlock_program.dm @@ -248,9 +248,15 @@ return (state == STATE_WAIT && target_state == TARGET_NONE) //are the doors closed and locked? +/datum/computer/file/embedded_program/airlock/proc/check_exterior_door_secured() + return (memory["exterior_status"]["state"] == "closed" && memory["exterior_status"]["lock"] == "locked") + +/datum/computer/file/embedded_program/airlock/proc/check_interior_door_secured() + return (memory["interior_status"]["state"] == "closed" && memory["interior_status"]["lock"] == "locked") + /datum/computer/file/embedded_program/airlock/proc/check_doors_secured() - var/ext_closed = (memory["exterior_status"]["state"] == "closed" && memory["exterior_status"]["lock"] == "locked") - var/int_closed = (memory["interior_status"]["state"] == "closed" && memory["interior_status"]["lock"] == "locked") + var/ext_closed = check_exterior_door_secured() + var/int_closed = check_interior_door_secured() return (ext_closed && int_closed) /datum/computer/file/embedded_program/airlock/proc/signalDoor(var/tag, var/command) From 9401dcf13c9f062011e9308e665748e9b2ad9110 Mon Sep 17 00:00:00 2001 From: Zuhayr Date: Fri, 18 Jul 2014 19:13:24 +0930 Subject: [PATCH 06/13] Fixes bug with drone Bump() check They can now use teleporters, hand tele portals and the disposals chute. --- code/modules/mob/living/silicon/robot/drone/drone.dm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/modules/mob/living/silicon/robot/drone/drone.dm b/code/modules/mob/living/silicon/robot/drone/drone.dm index 228337db11..0ab4e42028 100644 --- a/code/modules/mob/living/silicon/robot/drone/drone.dm +++ b/code/modules/mob/living/silicon/robot/drone/drone.dm @@ -317,10 +317,10 @@ if (!yes || ( \ !istype(AM,/obj/machinery/door) && \ !istype(AM,/obj/machinery/recharge_station) && \ - !istype(AM,/obj/machinery/disposal/deliveryChute && \ + !istype(AM,/obj/machinery/disposal/deliveryChute) && \ !istype(AM,/obj/machinery/teleport/hub) && \ !istype(AM,/obj/effect/portal) - ))) return + )) return ..() return From 4fdcbd1c5e796ebf6952f5122161a529643fd387 Mon Sep 17 00:00:00 2001 From: Mloc Date: Fri, 18 Jul 2014 13:39:05 +0100 Subject: [PATCH 07/13] add map step_[xy] check to travis --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 87eeb862d5..f8f1c71ba7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,4 +17,5 @@ install: - cd .. script: + - ! grep -q 'step_[xy]' maps/tgstation2.dmm - DreamMaker baystation12.dme From 29598c4ef661af2696c4b297b08debf980551d74 Mon Sep 17 00:00:00 2001 From: PsiOmega Date: Fri, 18 Jul 2014 14:46:17 +0200 Subject: [PATCH 08/13] Removes all step_? instances, including those with default values, to allow the new Travis-check to pass. --- maps/tgstation2.dmm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maps/tgstation2.dmm b/maps/tgstation2.dmm index 4318e1b6ff..d7b9db15d2 100644 --- a/maps/tgstation2.dmm +++ b/maps/tgstation2.dmm @@ -8437,7 +8437,7 @@ "dgm" = (/obj/structure/cable{d1 = 1; d2 = 2; icon_state = "1-2"},/obj/machinery/light/small{dir = 8},/turf/simulated/floor{icon_state = "floorgrime"},/area/engine/engine_eva_maintenance) "dgn" = (/obj/machinery/alarm{dir = 8; icon_state = "alarm0"; pixel_x = 24},/turf/simulated/floor{dir = 6; icon_state = "whitegreen"},/area/rnd/xenobiology/xenoflora) "dgo" = (/turf/simulated/floor{dir = 2; icon_state = "whitegreen"},/area/rnd/xenobiology/xenoflora) -"dgp" = (/obj/structure/cable{d1 = 1; d2 = 2; icon_state = "1-2"},/obj/machinery/door_control{desc = "A remote control-switch for Surgery."; id = "Surgery"; name = "Surgery"; normaldoorcontrol = 1; pixel_x = -24; pixel_y = 8; range = 3; step_x = 0; step_y = 0},/turf/simulated/floor{dir = 9; icon_state = "blue"},/area/medical/surgeryprep) +"dgp" = (/obj/structure/cable{d1 = 1; d2 = 2; icon_state = "1-2"},/obj/machinery/door_control{desc = "A remote control-switch for Surgery."; id = "Surgery"; name = "Surgery"; normaldoorcontrol = 1; pixel_x = -24; pixel_y = 8; range = 3},/turf/simulated/floor{dir = 9; icon_state = "blue"},/area/medical/surgeryprep) "dgq" = (/obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{dir = 4},/turf/simulated/floor{dir = 4; icon_state = "whitegreen"},/area/rnd/xenobiology/xenoflora_storage) "dgr" = (/obj/machinery/atmospherics/pipe/simple/hidden/supply,/obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{dir = 4},/turf/simulated/floor{icon_state = "white"},/area/rnd/xenobiology/xenoflora_storage) "dgs" = (/obj/machinery/door/poddoor{density = 0; icon_state = "pdoor0"; id = "Biohazard"; name = "Biohazard Shutter"; opacity = 0},/obj/machinery/atmospherics/pipe/simple/hidden/scrubbers{dir = 4},/turf/simulated/floor{icon_state = "white"},/area/rnd/xenobiology) From 65083d8536b5d50ad028752284088db6bdca0181 Mon Sep 17 00:00:00 2001 From: Mloc Date: Fri, 18 Jul 2014 13:47:59 +0100 Subject: [PATCH 09/13] hopefully fix travis stripping ! --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index f8f1c71ba7..5895a706b1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,5 +17,5 @@ install: - cd .. script: - - ! grep -q 'step_[xy]' maps/tgstation2.dmm + - (! grep -q 'step_[xy]' maps/tgstation2.dmm) - DreamMaker baystation12.dme From 9b71eb1fe6d7105ed7b1a37c537861d1c2ae55d0 Mon Sep 17 00:00:00 2001 From: mwerezak Date: Fri, 18 Jul 2014 11:40:49 -0400 Subject: [PATCH 10/13] Removes organ_failure random event --- baystation12.dme | 1 - code/modules/events/organ_failure.dm | 44 ---------------------------- 2 files changed, 45 deletions(-) delete mode 100644 code/modules/events/organ_failure.dm diff --git a/baystation12.dme b/baystation12.dme index de02865c78..365ed1718b 100644 --- a/baystation12.dme +++ b/baystation12.dme @@ -835,7 +835,6 @@ #include "code\modules\events\money_hacker.dm" #include "code\modules\events\money_lotto.dm" #include "code\modules\events\money_spam.dm" -#include "code\modules\events\organ_failure.dm" #include "code\modules\events\prison_break.dm" #include "code\modules\events\radiation_storm.dm" #include "code\modules\events\rogue_drones.dm" diff --git a/code/modules/events/organ_failure.dm b/code/modules/events/organ_failure.dm deleted file mode 100644 index f51c463328..0000000000 --- a/code/modules/events/organ_failure.dm +++ /dev/null @@ -1,44 +0,0 @@ -datum/event/organ_failure - var/severity = 1 - -datum/event/organ_failure/setup() - announceWhen = rand(0, 300) - endWhen = announceWhen + 1 - severity = rand(1, 3) - -datum/event/organ_failure/announce() - command_alert("Confirmed outbreak of level [rand(3,7)] biohazard aboard [station_name()]. All personnel must contain the outbreak.", "Biohazard Alert") - world << sound('sound/AI/outbreak5.ogg') - -datum/event/organ_failure/start() - var/list/candidates = list() //list of candidate keys - for(var/mob/living/carbon/human/G in player_list) - if(G.mind && G.mind.current && G.mind.current.stat != DEAD && G.health > 70 && G.internal_organs) - candidates += G - if(!candidates.len) return - candidates = shuffle(candidates)//Incorporating Donkie's list shuffle - - while(severity > 0 && candidates.len) - var/mob/living/carbon/human/C = candidates[1] - - var/acute = prob(15) - if (prob(75)) - //internal organ infection - var/datum/organ/internal/I = pick(C.internal_organs) - - if (acute) - I.germ_level = max(INFECTION_LEVEL_TWO, I.germ_level) - else - I.germ_level = max(rand(INFECTION_LEVEL_ONE,INFECTION_LEVEL_ONE*2), I.germ_level) - else - //external organ infection - var/datum/organ/external/O = pick(C.organs) - - if (acute) - O.germ_level = max(INFECTION_LEVEL_TWO, O.germ_level) - else - O.germ_level = max(rand(INFECTION_LEVEL_ONE,INFECTION_LEVEL_ONE*2), O.germ_level) - - C.bad_external_organs |= O - - severity-- From 98259688804d5d197e5a83ba160ccbaf163a2237 Mon Sep 17 00:00:00 2001 From: mwerezak Date: Fri, 18 Jul 2014 12:02:39 -0400 Subject: [PATCH 11/13] Fixes lingering reference to organ_failure --- code/modules/events/event_dynamic.dm | 1 - 1 file changed, 1 deletion(-) diff --git a/code/modules/events/event_dynamic.dm b/code/modules/events/event_dynamic.dm index 3db6f6137f..7ca50ad9eb 100644 --- a/code/modules/events/event_dynamic.dm +++ b/code/modules/events/event_dynamic.dm @@ -76,7 +76,6 @@ var/list/event_last_fired = list() possibleEvents[/datum/event/radiation_storm] = active_with_role["Medical"] * 10 possibleEvents[/datum/event/spontaneous_appendicitis] = active_with_role["Medical"] * 10 possibleEvents[/datum/event/viral_infection] = active_with_role["Medical"] * 10 - possibleEvents[/datum/event/organ_failure] = active_with_role["Medical"] * 50 possibleEvents[/datum/event/prison_break] = active_with_role["Security"] * 50 if(active_with_role["Security"] > 0) From b3a99cefcfb7533ba0687bf81ce915b5397dd9f5 Mon Sep 17 00:00:00 2001 From: mwerezak Date: Fri, 18 Jul 2014 12:07:43 -0400 Subject: [PATCH 12/13] Fixes #5666 --- code/game/verbs/ooc.dm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/code/game/verbs/ooc.dm b/code/game/verbs/ooc.dm index cead05c53e..ecae608f32 100644 --- a/code/game/verbs/ooc.dm +++ b/code/game/verbs/ooc.dm @@ -131,9 +131,12 @@ var/global/normal_ooc_colour = "#002eb8" var/list/heard = get_mobs_in_view(7, src.mob) var/mob/S = src.mob + var/display_name = S.key if(S.stat != DEAD) display_name = S.name + + // Handle non-admins for(var/mob/M in heard) if(!M.client) continue @@ -149,6 +152,12 @@ var/global/normal_ooc_colour = "#002eb8" else display_name = holder.fakekey C << "LOOC: [display_name]: [msg]" + + // Now handle admins + display_name = S.key + if(S.stat != DEAD) + display_name = "[S.name]/([S.key])" + for(var/client/C in admins) if(C.prefs.toggles & CHAT_LOOC) var/prefix = "(R)LOOC" From ccc73ddf69c20039e6aed9912c16b2e3027dc986 Mon Sep 17 00:00:00 2001 From: Mloc-Hibernia Date: Fri, 18 Jul 2014 21:08:01 +0000 Subject: [PATCH 13/13] modularize ban system Signed-off-by: Mloc-Hibernia --- code/modules/admin/IsBanned.dm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/code/modules/admin/IsBanned.dm b/code/modules/admin/IsBanned.dm index 9548c279a0..59e4182ac5 100644 --- a/code/modules/admin/IsBanned.dm +++ b/code/modules/admin/IsBanned.dm @@ -1,3 +1,4 @@ +#ifndef OVERRIDE_BAN_SYSTEM //Blocks an attempt to connect before even creating our client datum thing. world/IsBanned(key,address,computer_id) if(ckey(key) in admin_datums) @@ -79,3 +80,6 @@ world/IsBanned(key,address,computer_id) if (failedip) message_admins("[key] has logged in with a blank ip in the ban check.") return ..() //default pager ban stuff +#endif +#undef OVERRIDE_BAN_SYSTEM +