Corrects return values for the Topic procs of several computers and some other machines as well.

This commit is contained in:
mwerezak
2015-02-25 21:32:35 -05:00
parent a910986ed4
commit 6d15809768
40 changed files with 43 additions and 42 deletions

View File

@@ -204,7 +204,7 @@
/obj/machinery/atmospherics/binary/passive_gate/Topic(href,href_list) /obj/machinery/atmospherics/binary/passive_gate/Topic(href,href_list)
if(..()) return if(..()) return 1
if(href_list["toggle_valve"]) if(href_list["toggle_valve"])
unlocked = !unlocked unlocked = !unlocked

View File

@@ -190,7 +190,7 @@ Thus, the two variables affect pump operation are set in New():
return return
/obj/machinery/atmospherics/binary/pump/Topic(href,href_list) /obj/machinery/atmospherics/binary/pump/Topic(href,href_list)
if(..()) return if(..()) return 1
if(href_list["power"]) if(href_list["power"])
use_power = !use_power use_power = !use_power

View File

@@ -155,7 +155,7 @@
return null return null
/obj/machinery/atmospherics/omni/filter/Topic(href, href_list) /obj/machinery/atmospherics/omni/filter/Topic(href, href_list)
if(..()) return if(..()) return 1
switch(href_list["command"]) switch(href_list["command"])
if("power") if("power")
if(!configuring) if(!configuring)

View File

@@ -172,7 +172,7 @@
return data return data
/obj/machinery/atmospherics/omni/mixer/Topic(href, href_list) /obj/machinery/atmospherics/omni/mixer/Topic(href, href_list)
if(..()) return if(..()) return 1
switch(href_list["command"]) switch(href_list["command"])
if("power") if("power")

View File

@@ -199,7 +199,7 @@
/obj/machinery/atmospherics/trinary/filter/Topic(href, href_list) // -- TLE /obj/machinery/atmospherics/trinary/filter/Topic(href, href_list) // -- TLE
if(..()) if(..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)
if(href_list["filterset"]) if(href_list["filterset"])

View File

@@ -156,7 +156,7 @@
return return
/obj/machinery/atmospherics/trinary/mixer/Topic(href,href_list) /obj/machinery/atmospherics/trinary/mixer/Topic(href,href_list)
if(..()) return if(..()) return 1
if(href_list["power"]) if(href_list["power"])
use_power = !use_power use_power = !use_power
if(href_list["set_press"]) if(href_list["set_press"])

View File

@@ -93,6 +93,8 @@
ui.set_auto_update(1) ui.set_auto_update(1)
/obj/machinery/atmospherics/unary/freezer/Topic(href, href_list) /obj/machinery/atmospherics/unary/freezer/Topic(href, href_list)
if(..())
return 1
if(href_list["toggleStatus"]) if(href_list["toggleStatus"])
use_power = !use_power use_power = !use_power
update_icon() update_icon()
@@ -107,7 +109,6 @@
set_power_level(new_setting) set_power_level(new_setting)
add_fingerprint(usr) add_fingerprint(usr)
return 1
/obj/machinery/atmospherics/unary/freezer/process() /obj/machinery/atmospherics/unary/freezer/process()
..() ..()

View File

@@ -113,6 +113,8 @@
ui.set_auto_update(1) ui.set_auto_update(1)
/obj/machinery/atmospherics/unary/heater/Topic(href, href_list) /obj/machinery/atmospherics/unary/heater/Topic(href, href_list)
if(..())
return 1
if(href_list["toggleStatus"]) if(href_list["toggleStatus"])
use_power = !use_power use_power = !use_power
update_icon() update_icon()
@@ -127,7 +129,6 @@
set_power_level(new_setting) set_power_level(new_setting)
add_fingerprint(usr) add_fingerprint(usr)
return 1
//upgrading parts //upgrading parts
/obj/machinery/atmospherics/unary/heater/RefreshParts() /obj/machinery/atmospherics/unary/heater/RefreshParts()

View File

@@ -302,6 +302,7 @@ update_flag
/obj/machinery/portable_atmospherics/canister/Topic(href, href_list) /obj/machinery/portable_atmospherics/canister/Topic(href, href_list)
//Do not use "if(..()) return" here, canisters will stop working in unpowered areas like space or on the derelict. // yeah but without SOME sort of Topic check any dick can mess with them via exploits as he pleases -walter0o //Do not use "if(..()) return" here, canisters will stop working in unpowered areas like space or on the derelict. // yeah but without SOME sort of Topic check any dick can mess with them via exploits as he pleases -walter0o
//First comment might be outdated.
if (!istype(src.loc, /turf)) if (!istype(src.loc, /turf))
return 0 return 0

View File

@@ -110,7 +110,7 @@
onclose(user, "lockdown") onclose(user, "lockdown")
Topic(href, href_list) Topic(href, href_list)
..() if(..()) return 1
if( href_list["close"] ) if( href_list["close"] )
usr << browse(null, "window=lockdown") usr << browse(null, "window=lockdown")

View File

@@ -148,7 +148,7 @@
/obj/machinery/computer/med_data/Topic(href, href_list) /obj/machinery/computer/med_data/Topic(href, href_list)
if(..()) if(..())
return return 1
if (!( data_core.general.Find(src.active1) )) if (!( data_core.general.Find(src.active1) ))
src.active1 = null src.active1 = null

View File

@@ -158,7 +158,7 @@
/obj/machinery/computer/pod/Topic(href, href_list) /obj/machinery/computer/pod/Topic(href, href_list)
if(..()) if(..())
return return 1
if((usr.contents.Find(src) || (in_range(src, usr) && istype(loc, /turf))) || (istype(usr, /mob/living/silicon))) if((usr.contents.Find(src) || (in_range(src, usr) && istype(loc, /turf))) || (istype(usr, /mob/living/silicon)))
usr.set_machine(src) usr.set_machine(src)
if(href_list["power"]) if(href_list["power"])

View File

@@ -120,7 +120,7 @@
Topic(href, href_list) Topic(href, href_list)
..() if(..()) return 1
if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr)) if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr))
usr << browse(null, "window=infra") usr << browse(null, "window=infra")
onclose(usr, "infra") onclose(usr, "infra")

View File

@@ -129,7 +129,7 @@
Topic(href, href_list) Topic(href, href_list)
..() if(..()) return 1
if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr)) if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr))
usr << browse(null, "window=prox") usr << browse(null, "window=prox")
onclose(usr, "prox") onclose(usr, "prox")

View File

@@ -70,7 +70,7 @@
Topic(href, href_list) Topic(href, href_list)
..() if(..()) return 1
if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr)) if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr))
usr << browse(null, "window=radio") usr << browse(null, "window=radio")

View File

@@ -83,7 +83,7 @@
Topic(href, href_list) Topic(href, href_list)
..() if(..()) return 1
if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr)) if(!usr.canmove || usr.stat || usr.restrained() || !in_range(loc, usr))
usr << browse(null, "window=timer") usr << browse(null, "window=timer")
onclose(usr, "timer") onclose(usr, "timer")

View File

@@ -213,6 +213,7 @@
onclose(user,"fscanner") onclose(user,"fscanner")
/obj/machinery/computer/forensic_scanning/Topic(href,href_list) /obj/machinery/computer/forensic_scanning/Topic(href,href_list)
if(..()) return 1
switch(href_list["operation"]) switch(href_list["operation"])
if("login") if("login")
var/mob/M = usr var/mob/M = usr

View File

@@ -106,7 +106,7 @@ var/global/list/holodeck_programs = list(
/obj/machinery/computer/HolodeckControl/Topic(href, href_list) /obj/machinery/computer/HolodeckControl/Topic(href, href_list)
if(..()) if(..())
return return 1
if((usr.contents.Find(src) || (in_range(src, usr) && istype(src.loc, /turf))) || (istype(usr, /mob/living/silicon))) if((usr.contents.Find(src) || (in_range(src, usr) && istype(src.loc, /turf))) || (istype(usr, /mob/living/silicon)))
usr.set_machine(src) usr.set_machine(src)

View File

@@ -67,7 +67,7 @@
/obj/machinery/mineral/processing_unit_console/Topic(href, href_list) /obj/machinery/mineral/processing_unit_console/Topic(href, href_list)
if(..()) if(..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)

View File

@@ -43,7 +43,7 @@
/obj/machinery/mineral/stacking_unit_console/Topic(href, href_list) /obj/machinery/mineral/stacking_unit_console/Topic(href, href_list)
if(..()) if(..())
return return 1
if(href_list["change_stack"]) if(href_list["change_stack"])
var/choice = input("What would you like to set the stack amount to?") as null|anything in list(1,5,10,20,50) var/choice = input("What would you like to set the stack amount to?") as null|anything in list(1,5,10,20,50)

View File

@@ -116,7 +116,7 @@
/obj/machinery/mineral/mint/Topic(href, href_list) /obj/machinery/mineral/mint/Topic(href, href_list)
if(..()) if(..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)
if(processing==1) if(processing==1)

View File

@@ -62,7 +62,7 @@
/obj/item/weapon/moneybag/Topic(href, href_list) /obj/item/weapon/moneybag/Topic(href, href_list)
if(..()) if(..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)
if(href_list["remove"]) if(href_list["remove"])

View File

@@ -59,7 +59,7 @@
/obj/machinery/computer/engines/Topic(href, href_list) /obj/machinery/computer/engines/Topic(href, href_list)
if(..()) if(..())
return return 1
if(href_list["state"]) if(href_list["state"])
state = href_list["state"] state = href_list["state"]

View File

@@ -110,7 +110,7 @@
/obj/machinery/computer/helm/Topic(href, href_list) /obj/machinery/computer/helm/Topic(href, href_list)
if(..()) if(..())
return return 1
if (!linked) if (!linked)
return return

View File

@@ -113,7 +113,7 @@
/obj/machinery/computer/shuttle_control/explore/Topic(href, href_list) /obj/machinery/computer/shuttle_control/explore/Topic(href, href_list)
if(..()) if(..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)

View File

@@ -42,7 +42,7 @@
/obj/item/weapon/gun/energy/temperature/Topic(href, href_list) /obj/item/weapon/gun/energy/temperature/Topic(href, href_list)
if (..()) if (..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)

View File

@@ -165,6 +165,7 @@
return 0 return 0
/obj/item/weapon/gun/projectile/dartgun/Topic(href, href_list) /obj/item/weapon/gun/projectile/dartgun/Topic(href, href_list)
if(..()) return 1
src.add_fingerprint(usr) src.add_fingerprint(usr)
if(href_list["stop_mix"]) if(href_list["stop_mix"])
var/index = text2num(href_list["stop_mix"]) var/index = text2num(href_list["stop_mix"])

View File

@@ -162,7 +162,7 @@ won't update every console in existence) but it's more of a hassle to do. Also,
/obj/machinery/computer/rdconsole/Topic(href, href_list) /obj/machinery/computer/rdconsole/Topic(href, href_list)
if(..()) if(..())
return return 1
add_fingerprint(usr) add_fingerprint(usr)

View File

@@ -205,7 +205,7 @@
/obj/machinery/computer/rdservercontrol/Topic(href, href_list) /obj/machinery/computer/rdservercontrol/Topic(href, href_list)
if(..()) if(..())
return return 1
add_fingerprint(usr) add_fingerprint(usr)
usr.set_machine(src) usr.set_machine(src)

View File

@@ -181,6 +181,7 @@ datum/genesequence
onclose(user, "reconstitutor") onclose(user, "reconstitutor")
/obj/machinery/computer/reconstitutor/animal/Topic(href, href_list) /obj/machinery/computer/reconstitutor/animal/Topic(href, href_list)
if(..()) return 1
if(href_list["clone"]) if(href_list["clone"])
var/sequence_num = text2num(href_list["sequence_num"]) var/sequence_num = text2num(href_list["sequence_num"])
var/datum/genesequence/cloned_genesequence = completed_genesequences[sequence_num] var/datum/genesequence/cloned_genesequence = completed_genesequences[sequence_num]
@@ -201,10 +202,9 @@ datum/genesequence
pod1.biomass -= CLONE_BIOMASS pod1.biomass -= CLONE_BIOMASS
else else
usr << "\red \icon[src] Unable to locate cloning pod!" usr << "\red \icon[src] Unable to locate cloning pod!"
else
..()
/obj/machinery/computer/reconstitutor/Topic(href, href_list) /obj/machinery/computer/reconstitutor/Topic(href, href_list)
if(..()) return 1
if(href_list["insertpos"]) if(href_list["insertpos"])
//world << "inserting gene for genesequence [href_list["insertgenome"]] at pos [text2num(href_list["insertpos"])]" //world << "inserting gene for genesequence [href_list["insertgenome"]] at pos [text2num(href_list["insertpos"])]"
var/sequence_num = text2num(href_list["sequence_num"]) var/sequence_num = text2num(href_list["sequence_num"])
@@ -252,9 +252,6 @@ datum/genesequence
usr.unset_machine(src) usr.unset_machine(src)
usr << browse(null, "window=reconstitutor") usr << browse(null, "window=reconstitutor")
else
..()
/obj/machinery/computer/reconstitutor/proc/scan_fossil(var/obj/item/weapon/fossil/scan_fossil) /obj/machinery/computer/reconstitutor/proc/scan_fossil(var/obj/item/weapon/fossil/scan_fossil)
//see whether we accept these kind of fossils //see whether we accept these kind of fossils
if(accepted_fossil_types.len && !accepted_fossil_types.Find(scan_fossil.type)) if(accepted_fossil_types.len && !accepted_fossil_types.Find(scan_fossil.type))

View File

@@ -43,7 +43,7 @@
ui.set_auto_update(1) ui.set_auto_update(1)
/obj/machinery/embedded_controller/radio/simple_docking_controller/escape_pod/Topic(href, href_list) /obj/machinery/embedded_controller/radio/simple_docking_controller/escape_pod/Topic(href, href_list)
if(..()) //I hate this "return 1 to indicate they are not allowed to use the controller" crap, but not sure how else to do it without being able to call machinery/Topic() directly. if(..())
return 1 return 1
if("manual_arm") if("manual_arm")

View File

@@ -67,7 +67,7 @@
/obj/machinery/computer/shuttle_control/Topic(href, href_list) /obj/machinery/computer/shuttle_control/Topic(href, href_list)
if(..()) if(..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)

View File

@@ -221,7 +221,7 @@
/obj/machinery/computer/shuttle_control/emergency/Topic(href, href_list) /obj/machinery/computer/shuttle_control/emergency/Topic(href, href_list)
if(..()) if(..())
return return 1
if(href_list["removeid"]) if(href_list["removeid"])
var/dna_hash = href_list["removeid"] var/dna_hash = href_list["removeid"]

View File

@@ -78,7 +78,7 @@
/obj/machinery/computer/shuttle_control/multi/Topic(href, href_list) /obj/machinery/computer/shuttle_control/multi/Topic(href, href_list)
if(..()) if(..())
return return 1
usr.set_machine(src) usr.set_machine(src)
src.add_fingerprint(usr) src.add_fingerprint(usr)

View File

@@ -92,7 +92,7 @@
isolate() isolate()
/obj/machinery/computer/centrifuge/Topic(href, href_list) /obj/machinery/computer/centrifuge/Topic(href, href_list)
if (..()) return 0 if (..()) return 1
var/mob/user = usr var/mob/user = usr
var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main") var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main")

View File

@@ -80,7 +80,7 @@
/obj/machinery/computer/curer/Topic(href, href_list) /obj/machinery/computer/curer/Topic(href, href_list)
if(..()) if(..())
return return 1
usr.machine = src usr.machine = src
if (href_list["antibody"]) if (href_list["antibody"])
@@ -91,7 +91,6 @@
src.add_fingerprint(usr) src.add_fingerprint(usr)
src.updateUsrDialog() src.updateUsrDialog()
return
/obj/machinery/computer/curer/proc/createcure(var/obj/item/weapon/reagent_containers/container) /obj/machinery/computer/curer/proc/createcure(var/obj/item/weapon/reagent_containers/container)

View File

@@ -122,7 +122,7 @@
nanomanager.update_uis(src) nanomanager.update_uis(src)
/obj/machinery/computer/diseasesplicer/Topic(href, href_list) /obj/machinery/computer/diseasesplicer/Topic(href, href_list)
if(..()) return 0 if(..()) return 1
var/mob/user = usr var/mob/user = usr
var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main") var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main")

View File

@@ -139,7 +139,7 @@
nanomanager.update_uis(src) nanomanager.update_uis(src)
/obj/machinery/disease2/incubator/Topic(href, href_list) /obj/machinery/disease2/incubator/Topic(href, href_list)
if (..()) return 0 if (..()) return 1
var/mob/user = usr var/mob/user = usr
var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main") var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main")

View File

@@ -120,7 +120,7 @@
update_icon() update_icon()
/obj/machinery/disease2/isolator/Topic(href, href_list) /obj/machinery/disease2/isolator/Topic(href, href_list)
if (..()) return 0 if (..()) return 1
var/mob/user = usr var/mob/user = usr
var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main") var/datum/nanoui/ui = nanomanager.get_open_ui(user, src, "main")

View File

@@ -73,7 +73,7 @@
/obj/item/weapon/virusdish/Topic(href, href_list) /obj/item/weapon/virusdish/Topic(href, href_list)
. = ..() . = ..()
if(.) return if(.) return 1
if(href_list["info"]) if(href_list["info"])
usr << browse(info, "window=info_\ref[src]") usr << browse(info, "window=info_\ref[src]")