Version hell warnings

code/game/world.dm

@@ -1,4 +1,4 @@
-#define RECOMMENDED_VERSION 501
+#define RECOMMENDED_VERSION 513
 /world/New()
 	world_startup_time = world.timeofday
 	rollover_safety_date = world.realtime - world.timeofday // 00:00 today (ish, since floating point error with world.realtime) of today

code/modules/mob/new_player/login.dm

@@ -49,3 +49,41 @@ var/obj/effect/lobby_image = new /obj/effect/lobby_image
 		if(client)
 			handle_privacy_poll()
 			client.playtitlemusic()
+			version_warnings()
+
+/mob/new_player/proc/version_warnings()
+	var/problems // string to store message to present to player as a problem
+	
+	// TODO: Move this to a config file at some point maybe? What would the structure of that look like?
+	switch(client.byond_build)
+		// http://www.byond.com/forum/post/2711510
+		// http://www.byond.com/forum/post/2711506
+		// http://www.byond.com/forum/post/2711626
+		// http://www.byond.com/forum/post/2711748
+		if(1562 to 1563)
+			problems = "frequent known crashes related to animations"
+		
+		// Don't have a thread, just a lot of player reports.
+		if(1564)
+			if(world.byond_build == 1564)
+				problems = "random network disconnects on this version of BYOND server"
+			else if(world.byond_build < 1564)
+				problems = "crashes related to animations on this version of BYOND server"
+			else
+				problems = "potential network disconnects. If you experience some, try another version"
+
+	if(problems)
+		// To get attention
+		var/message = "Your BYOND client version ([client.byond_version].[client.byond_build]) has known issues: [problems]. See the chat window for other version options."
+		tgui_alert_async(src, message, "BYOND Client Version Warning")
+
+		// So we can be more wordy and give links.
+		to_chat(src, "<span class='danger'>Your client version has known issues.</span> Please consider using a different version: <a href='http://www.byond.com/download/build/'>http://www.byond.com/download/build/</a>.")
+		var/chat_message = ""
+		if(config.suggested_byond_version)
+			chat_message += "We suggest using version [config.suggested_byond_version]."
+			if(config.suggested_byond_build)
+				chat_message += "[config.suggested_byond_build]."
+			chat_message += " If you find this version doesn't work for you, let us know."
+		to_chat(src, chat_message)
+		to_chat(src, "Tip: You can always use the '.zip' versions of BYOND and keep multiple versions in folders wherever you want, rather than uninstalling/reinstalling. Just make sure BYOND is *really* closed (check your system tray for the icon) before starting a different version.")

config/alienwhitelist.txt

@@ -60,3 +60,11 @@ xioen - Xenochimera
 xonkon - Protean
 zalvine - Shadekin Empathy
 zammyman215 - Vox
+<<<<<<< HEAD
+||||||| parent of ceb722ae02... Merge pull request #11511 from VOREStation/Arokha/versionhell
+zeracyfr - Xenochimera
+spirit1299 - Black-Eyed Shadekin
+=======
+zeracyfr - Xenochimera
+spirit1299 - Black-Eyed Shadekin
+>>>>>>> ceb722ae02... Merge pull request #11511 from VOREStation/Arokha/versionhell

config/example/config.txt

@@ -587,4 +587,17 @@ DEFIB_TIMER 60
 # REQUIRED: url (str), title (str), duration (num, in DS)
 # SUGGESTED: artist (str), genre (str)
 # OPTIONAL: secret (bool), lobby (bool)
+<<<<<<< HEAD
 #JUKEBOX_TRACK_FILES config/jukebox.json;config/jukebox_private.json
+||||||| parent of ceb722ae02... Merge pull request #11511 from VOREStation/Arokha/versionhell
+#JUKEBOX_TRACK_FILES config/jukebox.json;config/jukebox_private.json
+JUKEBOX_TRACK_FILES config/jukebox.json
+=======
+#JUKEBOX_TRACK_FILES config/jukebox.json;config/jukebox_private.json
+JUKEBOX_TRACK_FILES config/jukebox.json
+
+# Suggested BYOND client version (major component, e.g. 514)
+#SUGGESTED_BYOND_VERSION 514
+# Suggested BYOND client build (minor component, e.g. 1560)
+#SUGGESTED_BYOND_BUILD 1561
+>>>>>>> ceb722ae02... Merge pull request #11511 from VOREStation/Arokha/versionhell