cyberpresidentvanellope/CHOMPStation2
1
0
Fork 0
mirror of https://github.com/CHOMPStation2/CHOMPStation2.git synced 2026-08-21 20:27:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Move autolathe design datums to techweb datums (#12565)

Browse Source 
Co-authored-by: Will <7099514+Willburd@users.noreply.github.com>
Co-authored-by: Cameron Lennox <killer65311@gmail.com>
This commit is contained in:
CHOMPStation2StaffMirrorBot
2026-03-21 03:53:42 -04:00
committed by GitHub
co-authored by Will Cameron Lennox
parent b61399d8e7
commit 90d7e7d352
137 changed files with 6181 additions and 1794 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/construction_tests.dm
+39
View File
@@ -9,3 +9,42 @@
failed = TRUE
if(failed)
TEST_FAIL("Mech Construction - A construction datum had incorrect data.")
/datum/unit_test/all_machine_circuits_must_be_printable/Run()
// get a list of all construction frames that automatically populate their circuitboard, we don't need to test for these
var/list/prepopulated_circuits = list()
for(var/datum/frame/frame_types/path as anything in subtypesof(/datum/frame/frame_types))
var/obj/item/circuitboard/circuit = initial(path.circuit)
if(!circuit)
continue
prepopulated_circuits |= circuit
// Get all machines with circuitboards
var/list/all_circuitboard_machines = list()
for(var/obj/machinery/path as anything in subtypesof(/obj/machinery))
var/obj/item/circuitboard/circuit = initial(path.circuit)
if(!circuit)
continue
all_circuitboard_machines |= circuit
// Check all circuits that are need has a techweb design
all_circuitboard_machines -= prepopulated_circuits
for(var/id in SSresearch.techweb_designs)
var/datum/design_techweb/design = SSresearch.techweb_designs[id]
if(!(design.build_path in subtypesof(/obj/item/circuitboard)))
continue
all_circuitboard_machines -= design.build_path
var/failed = FALSE
if(length(all_circuitboard_machines))
for(var/obj/item/circuitboard/circuit as anything in all_circuitboard_machines)
if(ispath(circuit))
if(initial(circuit.hidden)) // Intentionally not meant to show up on station
continue
TEST_NOTICE(src, "[circuit] - Missing a circuit from techweb. Ensure a techweb entry exists, or [circuit.build_path] will not be constructable in round.")
else
TEST_NOTICE(src, "[circuit] - is a LEGACY STRING and must be converted to a path!!!")
failed = TRUE
if(failed)
TEST_FAIL("missing circuitboard print recipies.")
code/modules/unit_tests/material_tests.dm
+40
View File
@@ -14,3 +14,43 @@
if(length(failures))
TEST_FAIL("[length(failures)] material\s had missing name strings: [english_list(failures)].")
/datum/unit_test/all_sheets_must_be_printable_from_autolathe
/datum/unit_test/all_sheets_must_be_printable_from_autolathe/Run()
// Get the materials all the sheets can be broken down into
var/list/needed_materials = list()
for(var/path in subtypesof(/obj/item/stack))
var/obj/item/stack/material/sheet = new path()
var/list/get_mats = sheet.get_material_composition()
for(var/mat in get_mats)
needed_materials |= mat
qdel(sheet)
// Then get the sheets those materials are represented by
var/list/required_sheets = list()
for(var/datum/material/mat in needed_materials)
if(!mat || !mat.stack_type)
continue
required_sheets |= mat.stack_type
// Get all material sheet printing recipies in the autolathe
var/list/sheet_print_designs = list()
for(var/id in SSresearch.techweb_designs)
var/datum/design_techweb/design = SSresearch.techweb_designs[id]
if(!(design.build_type & AUTOLATHE))
continue
if(!(design.build_path in subtypesof(/obj/item/stack/material)))
continue
sheet_print_designs |= design.build_path
// Check all sheets for EXISTANCE
var/failed = FALSE
for(var/sheet in required_sheets)
if(sheet in sheet_print_designs)
continue
failed = TRUE
TEST_NOTICE(src, "[sheet] - Missing an autolathe design, all material sheets must be printable, or materials can get stuck in the lathe forever")
if(failed)
TEST_FAIL("materials missing autolathe print recipies.")
code/modules/unit_tests/techwebs.dm
+57 -3
View File
@@ -35,21 +35,30 @@
TEST_NOTICE(src, "TECHWEB NODE - [node.type] did not have any research_costs set.")
failed = TRUE
// Must have category set
if(!length(node.category))
TEST_NOTICE(src, "TECHWEB NODE - [node.type] did not have a category set.")
failed = TRUE
// Must have valid designs
if(!node.design_ids)
if(!length(node.design_ids))
TEST_NOTICE(src, "TECHWEB NODE - [node.type] does not have any design_ids.")
failed = TRUE
else
for(var/design in node.design_ids)
if(design in used_designs)
TEST_NOTICE(src, "TECHWEB NODE - [node.type] has an already in use design_id: \"[design]\"")
failed = TRUE
used_designs += design
if(!SSresearch.techweb_designs[design])
if(!(design in SSresearch.techweb_designs))
TEST_NOTICE(src, "TECHWEB NODE - [node.type] has a non-existant design_id: \"[design]\"")
failed = TRUE
// Must have valid prereqs
if(node.prereq_ids.len)
for(var/req in node.prereq_ids)
if(!SSresearch.techweb_nodes[req])
if(!(req in SSresearch.techweb_nodes))
TEST_NOTICE(src, "TECHWEB NODE - [node.type] has a non-existant prereq_id: \"[req]\"")
failed = TRUE
@@ -82,6 +91,25 @@
TEST_NOTICE(src, "TECHWEB NODE - [node.type] costs less to make then the previous node, must always be at least the same or more expensive. ours lowest is \[[current_cost]\], prereq lowest is \[[prereq_currentcost]\]. Lesser costs than the previous node is only allowed if the node has a required experiment.")
failed = TRUE
// forbid designs with RND_CATEGORY_INITIAL in non-starting nodes
for(var/design_id in node.design_ids)
var/datum/design_techweb/design = SSresearch.techweb_designs[design_id]
if((RND_CATEGORY_INITIAL in design.category))
TEST_NOTICE(src, "TECHWEB NODE - [node.type]'s [design_id] is flagged as RND_CATEGORY_INITIAL in a non-starting techweb node.")
failed = TRUE
else
// if we have prereqs we did something wrong
if(length(node.prereq_ids))
TEST_NOTICE(src, "TECHWEB NODE - [node.type] is a starting node, but has prereq_ids assigned.")
failed = TRUE
// starting nodes need to have all design inside it flagged with RND_CATEGORY_INITIAL
for(var/design_id in node.design_ids)
var/datum/design_techweb/design = SSresearch.techweb_designs[design_id]
if(!(RND_CATEGORY_INITIAL in design.category))
TEST_NOTICE(src, "TECHWEB NODE - [node.type]'s [design_id] was part of a starting node, but is not category tagged RND_CATEGORY_INITIAL.")
failed = TRUE
// Each design
var/used_design_paths = list()
for(var/design_id in SSresearch.techweb_designs)
@@ -89,6 +117,13 @@
if(design.id == DESIGN_ID_IGNORE)
continue
/* Later
// Must have desc
if(!design.desc)
TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] did not have a description.")
failed = TRUE
*/
// Must all be accessible by science
if(!(design.departmental_flags & DEPARTMENT_BITFLAG_SCIENCE))
TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] was not flagged for science department, all designs must be accessible by science.")
@@ -98,10 +133,29 @@
if(!(design.id in used_designs))
TEST_NOTICE(src, "TECHWEB DESIGN - WARNING [design.type] is orphaned and not accessible from any techweb node. Is this intended?")
// Design must have materials
if(!length(design.materials))
TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] has no materials assigned.")
failed = TRUE
else
for(var/mat in design.materials)
var/datum/material/mat_datum = get_material_by_name(mat)
if(!mat_datum)
TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] had a non-existant material assigned \"[mat]\".")
failed = TRUE
else
var/amount = design.materials[mat]
if(!amount)
TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] assigned material \"[mat]\" had no amount specified, or a negative amount.")
failed = TRUE
// Design must produce something
if(!design.build_path)
TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] did not have a build_path.")
failed = TRUE
else if(design.build_path in subtypesof(/obj/machinery))
TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] had a buildpath that directly prints a machine: \"[design.build_path]\"")
failed = TRUE
// Design must be a unique path produced
if(design.build_path in used_design_paths)