cyberpresidentvanellope/CHOMPStation2
1
0
Fork 0
mirror of https://github.com/CHOMPStation2/CHOMPStation2.git synced 2026-08-30 08:39:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] fix some remote view component desyncs and crashes (#11814)

Browse Source 
Co-authored-by: Will <7099514+Willburd@users.noreply.github.com>
This commit is contained in:
CHOMPStation2StaffMirrorBot
2025-10-14 22:12:34 +02:00
committed by GitHub
co-authored by Will
parent b47246cc56
commit 9e39f50248
18 changed files with 65 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/components/remote_view.dm
+8 -2
View File
@@ -191,8 +191,9 @@
host_mob.toggle_zoom_hud()
host_item.zoom = FALSE
// return view offset
host_mob.client.pixel_x = 0
host_mob.client.pixel_y = 0
if(host_mob.client)
host_mob.client.pixel_x = 0
host_mob.client.pixel_y = 0
host_mob.handle_vision()
// decouple
UnregisterSignal(host_item, COMSIG_QDELETING)
@@ -257,6 +258,9 @@
view_coordinator.look(host_mob)
LAZYDISTINCTADD(viewers, WEAKREF(host_mob))
RegisterSignal(view_coordinator, COMSIG_REMOTE_VIEW_CLEAR, PROC_REF(handle_endview))
// If you get this crash, it's because check_eye() in look() failed
if(!parent)
CRASH("Remoteview failed, look() cancelled view during component Initilize. Usually this is caused by check_eye().")
/datum/component/remote_view/viewer_managed/Destroy(force)
UnregisterSignal(view_coordinator, COMSIG_REMOTE_VIEW_CLEAR)
@@ -298,6 +302,8 @@
if(!host_mob)
return
if(isturf(host_mob.loc))
if(oldloc == remote_view_target)
needs_to_decouple = TRUE
decouple_view_to_turf( host_mob, host_mob.loc)
return