cyberpresidentvanellope/CHOMPStation2
1
0
Fork 0
mirror of https://github.com/CHOMPStation2/CHOMPStation2.git synced 2025-12-10 02:09:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable bicon() icon object cache, and create text tag cache

Browse Source
This commit is contained in:
Aronai Sieyes
2020-03-01 15:02:08 -05:00
parent 974eaccdaa
commit a5af4695fc
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
code/_helpers/text.dm
View File

@@ -301,12 +301,15 @@ proc/TextPreview(var/string,var/len=40)
//For generating neat chat tag-images //For generating neat chat tag-images
//The icon var could be local in the proc, but it's a waste of resources //The icon var could be local in the proc, but it's a waste of resources
// to always create it and then throw it out. // to always create it and then throw it out.
/var/icon/text_tag_icons = new('./icons/chattags.dmi') /var/icon/text_tag_icons = 'icons/chattags.dmi'
/var/list/text_tag_cache = list()
/proc/create_text_tag(var/tagname, var/tagdesc = tagname, var/client/C = null) /proc/create_text_tag(var/tagname, var/tagdesc = tagname, var/client/C = null)
if(!(C && C.is_preference_enabled(/datum/client_preference/chat_tags))) if(!(C && C.is_preference_enabled(/datum/client_preference/chat_tags)))
return tagdesc return tagdesc
var/icon/tag = icon(text_tag_icons.icon, tagname) if(!text_tag_cache[tagname])
return bicon(tag,TRUE,"text_tag") //"<IMG src='\ref[text_tag_icons.icon]' class='text_tag' iconstate='[tagname]'" + (tagdesc ? " alt='[tagdesc]'" : "") + ">" var/icon/tag = icon(text_tag_icons, tagname)
text_tag_cache[tagname] = bicon(tag, TRUE, "text_tag")
return text_tag_cache[tagname]
/proc/contains_az09(var/input) /proc/contains_az09(var/input)
for(var/i=1, i<=length(input), i++) for(var/i=1, i<=length(input), i++)

7
code/modules/vchat/vchat_client.dm
View File

@@ -244,10 +244,11 @@ GLOBAL_DATUM_INIT(iconCache, /savefile, new("data/iconCache.sav")) //Cache of ic
var/static/list/bicon_cache = list() var/static/list/bicon_cache = list()
if (isicon(obj)) if (isicon(obj))
if (!bicon_cache["\ref[obj]"]) // Doesn't exist yet, make it. //Icon refs get reused all the time especially on temporarily made ones like chat tags, too difficult to cache.
bicon_cache["\ref[obj]"] = icon2base64(obj) //if (!bicon_cache["\ref[obj]"]) // Doesn't exist yet, make it.
//bicon_cache["\ref[obj]"] = icon2base64(obj)
return "<img [class] src='data:image/png;base64,[bicon_cache["\ref[obj]"]]'>" return "<img [class] src='data:image/png;base64,[icon2base64(obj)]'>"
// Either an atom or somebody fucked up and is gonna get a runtime, which I'm fine with. // Either an atom or somebody fucked up and is gonna get a runtime, which I'm fine with.
var/atom/A = obj var/atom/A = obj