From b4e6b4e2048cb21b5aa7a6842f92a9ce5f978373 Mon Sep 17 00:00:00 2001 From: GinjaNinja32 Date: Wed, 13 Aug 2014 09:41:38 +0100 Subject: [PATCH] Fixes not checking proximity argument --- code/game/objects/items/devices/modkit.dm | 6 +++++- code/game/objects/items/devices/pipe_painter.dm | 5 ++++- code/game/objects/items/devices/scanners.dm | 4 +++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/code/game/objects/items/devices/modkit.dm b/code/game/objects/items/devices/modkit.dm index a1de93987f..02d11f2251 100644 --- a/code/game/objects/items/devices/modkit.dm +++ b/code/game/objects/items/devices/modkit.dm @@ -14,7 +14,10 @@ /obj/item/clothing/suit/space/rig ) -/obj/item/device/modkit/afterattack(obj/O, mob/user as mob) +/obj/item/device/modkit/afterattack(obj/O, mob/user as mob, proximity) + if(!proximity) + return + if (!target_species) return //it shouldn't be null, okay? @@ -38,6 +41,7 @@ var/in_list = (target_species in I.species_restricted) if (excluding ^ in_list) user << "[I] is already modified." + return if(!isturf(O.loc)) user << "[O] must be safely placed on the ground for modification." diff --git a/code/game/objects/items/devices/pipe_painter.dm b/code/game/objects/items/devices/pipe_painter.dm index 3a062adca4..5d900fb3e7 100644 --- a/code/game/objects/items/devices/pipe_painter.dm +++ b/code/game/objects/items/devices/pipe_painter.dm @@ -6,7 +6,10 @@ var/list/modes = list("grey","red","blue","cyan","green","yellow","purple") var/mode = "grey" -/obj/item/device/pipe_painter/afterattack(atom/A, mob/user as mob) +/obj/item/device/pipe_painter/afterattack(atom/A, mob/user as mob, proximity) + if(!proximity) + return + if(!istype(A,/obj/machinery/atmospherics/pipe) || istype(A,/obj/machinery/atmospherics/pipe/tank) || istype(A,/obj/machinery/atmospherics/pipe/vent) || istype(A,/obj/machinery/atmospherics/pipe/simple/heat_exchanging) || istype(A,/obj/machinery/atmospherics/pipe/simple/insulated) || !in_range(user, A)) return var/obj/machinery/atmospherics/pipe/P = A diff --git a/code/game/objects/items/devices/scanners.dm b/code/game/objects/items/devices/scanners.dm index 441dee233a..ffffe00490 100644 --- a/code/game/objects/items/devices/scanners.dm +++ b/code/game/objects/items/devices/scanners.dm @@ -386,7 +386,9 @@ REAGENT SCANNER var/details = 0 var/recent_fail = 0 -/obj/item/device/reagent_scanner/afterattack(obj/O, mob/user as mob) +/obj/item/device/reagent_scanner/afterattack(obj/O, mob/user as mob, proximity) + if(!proximity) + return if (user.stat) return if (!(istype(user, /mob/living/carbon/human) || ticker) && ticker.mode.name != "monkey")