Tg panel patch 2 (#8085)

Co-authored-by: Cadyn Bombaci <cadynspacetechguy@gmail.com>

code/controllers/subsystems/plants.dm

@@ -150,7 +150,7 @@ SUBSYSTEM_DEF(plants)
 
 // Debug for testing seed genes.
 /client/proc/show_plant_genes()
-	set category = "Debug"
+	set category = "Debug.Investigate" //CHOMPEdit
 	set name = "Show Plant Genes"
 	set desc = "Prints the round's plant gene masks."
 

code/controllers/subsystems/server_maint_ch.dm

@@ -0,0 +1,115 @@
+#define PING_BUFFER_TIME 25
+
+SUBSYSTEM_DEF(server_maint)
+	name = "Server Tasks"
+	wait = 6
+	flags = SS_POST_FIRE_TIMING
+	priority = FIRE_PRIORITY_SERVER_MAINT
+	init_order = INIT_ORDER_SERVER_MAINT
+	//init_stage = INITSTAGE_EARLY
+	runlevels = RUNLEVEL_LOBBY | RUNLEVELS_DEFAULT
+	var/list/currentrun
+	///Associated list of list names to lists to clear of nulls
+	var/list/lists_to_clear
+	///Delay between list clearings in ticks
+	var/delay = 5
+	var/cleanup_ticker = 0
+
+/*/datum/controller/subsystem/server_maint/PreInit()
+	world.hub_password = "" *///quickly! before the hubbies see us.
+
+/datum/controller/subsystem/server_maint/Initialize()
+	if (fexists("tmp/"))
+		fdel("tmp/")
+	//if (CONFIG_GET(flag/hub))
+		//world.update_hub_visibility(TRUE)
+	//Keep in mind, because of how delay works adding a list here makes each list take wait * delay more time to clear
+	//Do it for stuff that's properly important, and shouldn't have null checks inside its other uses
+	lists_to_clear = list(
+		"player_list" = global.player_list,
+		"mob_list" = global.mob_list,
+		"living_mob_list" = global.living_mob_list,
+		"dead_mob_list" = global.dead_mob_list,
+		"observer_mob_list" = global.observer_mob_list,
+		"listening_objects" = global.listening_objects,
+		"human_mob_list" = global.human_mob_list,
+		"silicon_mob_list" = global.silicon_mob_list,
+		"ai_list" = global.ai_list,
+		//"keyloop_list" = global.keyloop_list, //A null here will cause new clients to be unable to move. totally unacceptable
+	)
+
+	/*var/datum/tgs_version/tgsversion = world.TgsVersion()
+	if(tgsversion)
+		SSblackbox.record_feedback("text", "server_tools", 1, tgsversion.raw_parameter)*/
+
+	return SS_INIT_SUCCESS
+
+/datum/controller/subsystem/server_maint/fire(resumed = FALSE)
+	if(!resumed)
+		if(list_clear_nulls(GLOB.clients))
+			log_world("Found a null in clients list!")
+		src.currentrun = GLOB.clients.Copy()
+
+		var/position_in_loop = (cleanup_ticker / delay) + 1	 //Index at 1, thanks byond
+
+		if(!(position_in_loop % 1)) //If it's a whole number
+			var/listname = lists_to_clear[position_in_loop]
+			if(list_clear_nulls(lists_to_clear[listname]))
+				log_world("Found a null in [listname]!")
+
+		cleanup_ticker++
+
+		var/amount_to_work = length(lists_to_clear)
+		if(cleanup_ticker >= amount_to_work * delay) //If we've already done a loop, reset
+			cleanup_ticker = 0
+
+	var/list/currentrun = src.currentrun
+	//var/round_started = SSticker.HasRoundStarted()
+
+	//var/kick_inactive = CONFIG_GET(flag/kick_inactive)
+	//var/afk_period
+	//if(kick_inactive)
+		//afk_period = CONFIG_GET(number/afk_period)
+	for(var/I in currentrun)
+		var/client/C = I
+		//handle kicking inactive players
+		/*if(round_started && kick_inactive && !C.holder && C.is_afk(afk_period))
+			var/cmob = C.mob
+			if (!isnewplayer(cmob) || !SSticker.queued_players.Find(cmob))
+				log_access("AFK: [key_name(C)]")
+				to_chat(C, span_userdanger("You have been inactive for more than [DisplayTimeText(afk_period)] and have been disconnected.</span><br><span class='danger'>You may reconnect via the button in the file menu or by <b><u><a href='byond://winset?command=.reconnect'>clicking here to reconnect</a></u></b>."))
+				QDEL_IN(C, 1) //to ensure they get our message before getting disconnected
+				continue*/
+
+		if (!(!C || world.time - C.connection_time < PING_BUFFER_TIME || C.inactivity >= (wait-1)))
+			winset(C, null, "command=.update_ping+[num2text(world.time+world.tick_lag*TICK_USAGE_REAL/100, 32)]")
+
+		if (MC_TICK_CHECK) //one day, when ss13 has 1000 people per server, you guys are gonna be glad I added this tick check
+			return
+
+/datum/controller/subsystem/server_maint/Shutdown()
+	if (fexists("tmp/"))
+		fdel("tmp/")
+	//kick_clients_in_lobby(span_boldannounce("The round came to an end with you in the lobby."), TRUE) //second parameter ensures only afk clients are kicked
+	var/server = null//CONFIG_GET(string/server) todo properly later once config controller is updated
+	for(var/thing in GLOB.clients)
+		if(!thing)
+			continue
+		var/client/C = thing
+		C?.tgui_panel?.send_roundrestart()
+		if(server) //if you set a server location in config.txt, it sends you there instead of trying to reconnect to the same world address. -- NeoFite
+			C << link("byond://[server]")
+
+/*
+/datum/controller/subsystem/server_maint/proc/UpdateHubStatus()
+	if(!CONFIG_GET(flag/hub) || !CONFIG_GET(number/max_hub_pop))
+		return FALSE //no point, hub / auto hub controls are disabled
+
+	var/max_pop = CONFIG_GET(number/max_hub_pop)
+
+	if(GLOB.clients.len > max_pop)
+		world.update_hub_visibility(FALSE)
+	else
+		world.update_hub_visibility(TRUE)
+*/
+#undef PING_BUFFER_TIME

code/controllers/subsystems/statpanel_ch.dm

@@ -135,8 +135,7 @@ SUBSYSTEM_DEF(statpanels)
 
 	target.stat_panel.send_message("update_stat", list(
 		global_data = global_data,
-		//ping_str = "Ping: [round(target.lastping, 1)]ms (Average: [round(target.avgping, 1)]ms)",
-		ping_str = "Ping: -- Not Available --",
+		ping_str = "Ping: [round(target.lastping, 1)]ms (Average: [round(target.avgping, 1)]ms)",
 		other_str = target.mob?.get_status_tab_items(),
 	))
 

code/controllers/subsystems/vote.dm

@@ -399,7 +399,7 @@ SUBSYSTEM_DEF(vote)
 	usr.client.vote()
 
 /client/verb/vote()
-	set category = "OOC"
+	set category = "OOC.Game" //CHOMPEdit
 	set name = "Vote"
 
 	if(SSvote)