From 5dbafd224bb4f17035648600b96fea4dc6afa213 Mon Sep 17 00:00:00 2001 From: Cyrelius <69184203+Cyrelius@users.noreply.github.com> Date: Fri, 2 Jul 2021 19:46:12 -0700 Subject: [PATCH 1/4] Darksight minor changes Adding the full range, without Virgo's insistence on the flash vulnerability, which is stupid, as we already have that in negative traits that you're likely to take with this anyway. Cost is still appropriate. --- .../carbon/human/species/station/traits_vr/positive.dm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm index 7810b5904f..ab5b26775d 100644 --- a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm +++ b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm @@ -46,15 +46,15 @@ /datum/trait/positive/darksight name = "Darksight" - desc = "Allows you to see a short distance in the dark and 10% more susceptible to flashes." //CHOMP Edit + desc = "Allows you to see a short distance in the dark." //CHOMP Edit: we've already got the flash vulnerability in a negative trait, it's not needed here also. cost = 1 - var_changes = list("darksight" = 3) //CHOMP Edit + var_changes = list("darksight" = 4) //CHOMP Edit /datum/trait/positive/darksight_plus name = "Darksight (Major)" - desc = "Allows you to see in the dark for almost the whole screen and 20% more susceptible to flashes." //CHOMP Edit + desc = "Allows you to see in the dark for the whole screen." //CHOMP Edit: we've already got the flash vulnerability in a negative trait, it's not needed here also. cost = 2 - var_changes = list("darksight" = 6) //CHOMP Edit + var_changes = list("darksight" = 8) //CHOMP Edit /datum/trait/positive/melee_attack name = "Sharp Melee" From cb8f9b50fd7985d1d454aebbce43a8a5645f171e Mon Sep 17 00:00:00 2001 From: Cyrelius <69184203+Cyrelius@users.noreply.github.com> Date: Sun, 4 Jul 2021 09:02:01 -0700 Subject: [PATCH 2/4] Revert "Darksight minor changes" --- .../carbon/human/species/station/traits_vr/positive.dm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm index ab5b26775d..7810b5904f 100644 --- a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm +++ b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm @@ -46,15 +46,15 @@ /datum/trait/positive/darksight name = "Darksight" - desc = "Allows you to see a short distance in the dark." //CHOMP Edit: we've already got the flash vulnerability in a negative trait, it's not needed here also. + desc = "Allows you to see a short distance in the dark and 10% more susceptible to flashes." //CHOMP Edit cost = 1 - var_changes = list("darksight" = 4) //CHOMP Edit + var_changes = list("darksight" = 3) //CHOMP Edit /datum/trait/positive/darksight_plus name = "Darksight (Major)" - desc = "Allows you to see in the dark for the whole screen." //CHOMP Edit: we've already got the flash vulnerability in a negative trait, it's not needed here also. + desc = "Allows you to see in the dark for almost the whole screen and 20% more susceptible to flashes." //CHOMP Edit cost = 2 - var_changes = list("darksight" = 8) //CHOMP Edit + var_changes = list("darksight" = 6) //CHOMP Edit /datum/trait/positive/melee_attack name = "Sharp Melee" From d36589b610c452cd30a225d84530ecb8fe8c6320 Mon Sep 17 00:00:00 2001 From: Cyrelius <69184203+Cyrelius@users.noreply.github.com> Date: Sun, 4 Jul 2021 09:16:16 -0700 Subject: [PATCH 3/4] DarkSight changes Bumping darksight's range up one, and major darksight's up two. --- .../living/carbon/human/species/station/traits_vr/positive.dm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm index 54c09e7b9b..171ded07f8 100644 --- a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm +++ b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive.dm @@ -40,7 +40,7 @@ desc = "Decreases your susceptibility to electric shocks by a 50% amount." //CHOMP Edit cost = 3 //Let us not forget this effects tasers! var_changes = list("siemens_coefficient" = 0.5) //CHOMP Edit - +/* //Chompedit, moving to Positive_ch.dm so it wont be messed with from upstream /datum/trait/positive/darksight name = "Darksight" desc = "Allows you to see a short distance in the dark and 10% more susceptible to flashes." //CHOMP Edit @@ -52,7 +52,7 @@ desc = "Allows you to see in the dark for almost the whole screen and 20% more susceptible to flashes." //CHOMP Edit cost = 2 var_changes = list("darksight" = 6) //CHOMP Edit - +*/ /datum/trait/positive/melee_attack name = "Sharp Melee" desc = "Provides sharp melee attacks that do slightly more damage." From 8bbf812913815fc58e0308d17549064a0a79d669 Mon Sep 17 00:00:00 2001 From: Cyrelius <69184203+Cyrelius@users.noreply.github.com> Date: Sun, 4 Jul 2021 09:22:15 -0700 Subject: [PATCH 4/4] Re-add darksight to Positive_ch.dm --- .../human/species/station/traits_vr/positive_ch.dm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive_ch.dm b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive_ch.dm index 3550b88d87..2d02d2a442 100644 --- a/code/modules/mob/living/carbon/human/species/station/traits_vr/positive_ch.dm +++ b/code/modules/mob/living/carbon/human/species/station/traits_vr/positive_ch.dm @@ -4,6 +4,18 @@ cost = 2 var_changes = list("num_alternate_languages" = 12) +/datum/trait/positive/darksight + name = "Darksight" + desc = "Allows you to see a short distance in the dark." + cost = 1 + var_changes = list("darksight" = 4) //CHOMP Edit + +/datum/trait/positive/darksight_plus + name = "Darksight, Major" + desc = "Allows you to see in the dark for the whole screen." + cost = 2 + var_changes = list("darksight" = 8) + /datum/trait/positive/densebones name = "Dense bones" desc = "Your bones (or robotic limbs) are more dense or stronger then what is considered normal. It is much harder to fracture your bones, yet pain from fractures is much more intense."