[MANUAL MIRROR] Port OD Pragma Lints (#17171) (#10255)

Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>

code/game/antagonist/antagonist_print.dm

@@ -51,7 +51,7 @@
 
 /datum/antagonist/proc/print_player_lite(var/datum/mind/ply)
 	var/role = ply.assigned_role ? "\improper[ply.assigned_role]" : "\improper[ply.special_role]"
-	var/text = "<br>" + span_bold("[ply.name]") + " (" + span_bold("[ply.key]") + ") as \a " + span_bold("[role]") + " ("
+	var/text = "<br>" + span_bold("[ply.name]") + " (" + span_bold("[ply.key]") + ") as " + span_bold("\a [role]") + " ("
 	if(ply.current)
 		if(ply.current.stat == DEAD)
 			text += "died"

code/game/dna/dna2_domutcheck.dm

@@ -19,7 +19,7 @@
 		if(!M || !M.dna)
 			return
 		if(gene.block)
-			if(gene.name in M.active_genes || gene.flags & GENE_ALWAYS_ACTIVATE)
+			if((gene.name in M.active_genes) || gene.flags & GENE_ALWAYS_ACTIVATE)
 				enabled_genes.Add(gene)
 			else
 				disabled_genes.Add(gene)

code/game/dna/dna_modifier.dm

@@ -298,7 +298,6 @@
 					ex_act(severity)
 				qdel(src)
 				return
-		else
 	return
 
 /obj/machinery/computer/scan_consolenew
@@ -356,7 +355,6 @@
 			if(prob(50))
 				qdel(src)
 				return
-		else
 	return
 
 /obj/machinery/computer/scan_consolenew/Initialize()

code/game/gamemodes/events/holidays/Holidays.dm

@@ -266,7 +266,7 @@ var/global/list/Holiday = list() //Holidays are lists now, so we can have more t
 			for(var/blurb in holiday_blurbs)
 				to_world(span_filter_system(span_blue("<div align='center'>[blurb]</div>")))
 		switch(Holiday)			//special holidays
-			if("Easter")
+			//if("Easter")
 				//do easter stuff
 			if("Christmas Eve","Christmas")
 				Christmas_Game_Start()
@@ -278,7 +278,7 @@ var/global/list/Holiday = list() //Holidays are lists now, so we can have more t
 	if(isemptylist(Holiday))
 		return 0
 	switch(Holiday)			//special holidays
-		if("Easter")		//I'll make this into some helper procs at some point
+		//if("Easter")		//I'll make this into some helper procs at some point
 /*			var/list/turf/simulated/floor/Floorlist = list()
 			for(var/turf/simulated/floor/T)
 				if(T.contents)

code/game/gamemodes/events/power_failure.dm

@@ -7,7 +7,7 @@
 
 	for(var/obj/machinery/power/smes/S in GLOB.smeses)
 		var/area/current_area = get_area(S)
-		if(current_area.type in skipped_areas || !(S.z in using_map.station_levels))
+		if((current_area.type in skipped_areas) || !(S.z in using_map.station_levels))
 			continue
 		S.last_charge			= S.charge
 		S.last_output_attempt	= S.output_attempt
@@ -33,7 +33,7 @@
 			C.cell.charge = C.cell.maxcharge
 	for(var/obj/machinery/power/smes/S in GLOB.smeses)
 		var/area/current_area = get_area(S)
-		if(current_area.type in skipped_areas || isNotStationLevel(S.z))
+		if((current_area.type in skipped_areas) || isNotStationLevel(S.z))
 			continue
 		S.charge = S.last_charge
 		S.output_attempt = S.last_output_attempt

code/game/machinery/OpTable.dm

@@ -39,7 +39,6 @@
 		if(3.0)
 			if(prob(25))
 				density = FALSE
-		else
 	return
 
 /obj/machinery/optable/attack_hand(mob/user as mob)

code/game/machinery/adv_med.dm

@@ -161,7 +161,6 @@
 				//SN src = null
 				qdel(src)
 				return
-		else
 	return
 
 /obj/machinery/bodyscanner/tgui_host(mob/user)
@@ -628,7 +627,6 @@
 				//SN src = null
 				qdel(src)
 				return
-		else
 	return
 
 /obj/machinery/body_scanconsole/proc/findscanner()

code/game/machinery/cloning.dm

@@ -440,7 +440,6 @@
 					ex_act(severity)
 				qdel(src)
 				return
-		else
 	return
 
 /obj/machinery/clonepod/update_icon()

code/game/machinery/computer/computer.dm

@@ -56,7 +56,6 @@
 				for(var/x in verbs)
 					src.verbs -= x
 				set_broken()
-		else
 	return
 
 /obj/machinery/computer/bullet_act(var/obj/item/projectile/Proj)

code/game/machinery/doors/door_vr.dm

@@ -85,7 +85,7 @@
 
 		var/obj/item/weldingtool/welder = I.get_welder()
 		if(welder.remove_fuel(0,user))
-			to_chat(user, span_notice("You start weld \the plasteel into place."))
+			to_chat(user, span_notice("You start welding the plasteel into place."))
 			playsound(src, welder.usesound, 50, 1)
 			if(do_after(user, 10 * welder.toolspeed) && welder && welder.isOn())
 				to_chat(user, span_notice("You finish reinforcing \the [src]."))

code/game/machinery/machinery.dm

@@ -196,7 +196,6 @@ Class Procs:
 			if(prob(25))
 				fall_apart(severity)
 				return
-		else
 	return
 
 /obj/machinery/vv_edit_var(var/var_name, var/new_value)

code/game/machinery/oxygen_pump.dm

@@ -121,7 +121,7 @@
 		return
 	//when there is a breather:
 	if(breather && target != breather)
-		to_chat(user, span_warning("\The pump is already in use."))
+		to_chat(user, span_warning("\The [src] is already in use."))
 		return
 	//Checking if breather is still valid
 	if(target == breather && target.wear_mask != contained)

code/game/machinery/telecomms/broadcaster.dm

@@ -737,7 +737,7 @@ var/message_delay = 0 // To make sure restarting the recentmessages list is kept
 /atom/proc/test_telecomms()
 	var/datum/signal/signal = src.telecomms_process()
 	var/pos_z = get_z(src)
-	return (pos_z in signal.data["level"] && signal.data["done"])
+	return ((pos_z in signal.data["level"]) && signal.data["done"])
 
 /atom/proc/telecomms_process(var/do_sleep = 1)
 

code/game/machinery/telecomms/logbrowser.dm

@@ -131,7 +131,7 @@
 			var/newnet = tgui_input_text(ui.user, "Which network do you want to view?", "Comm Monitor", network, 15)
 			newnet = sanitize(newnet,15)
 
-			if(newnet && ((ui.user in range(1, src) || issilicon(ui.user))))
+			if(newnet && ((ui.user in range(1, src)) || issilicon(ui.user)))
 				if(length(newnet) > 15)
 					set_temp("FAILED: NETWORK TAG STRING TOO LENGTHY", "bad")
 					return TRUE

code/game/machinery/telecomms/telemonitor.dm

@@ -102,7 +102,7 @@
 		if("network")
 			var/newnet = tgui_input_text(ui.user, "Which network do you want to view?", "Comm Monitor", network, 15)
 			newnet = sanitize(newnet,15) //Honestly, I'd be amazed if someone managed to do HTML in 15 chars.
-			if(newnet && ((ui.user in range(1, src) || issilicon(ui.user))))
+			if(newnet && ((ui.user in range(1, src)) || issilicon(ui.user)))
 				if(length(newnet) > 15)
 					set_temp("FAILED: NETWORK TAG STRING TOO LENGTHY", "bad")
 					return TRUE

code/game/machinery/telecomms/traffic_control.dm

@@ -195,7 +195,7 @@
 		var/newnet = tgui_input_text(usr, "Which network do you want to view?", "Comm Monitor", network, 15)
 		newnet = sanitize(newnet,15)
 
-		if(newnet && ((usr in range(1, src) || issilicon(usr))))
+		if(newnet && ((usr in range(1, src)) || issilicon(usr)))
 			if(length(newnet) > 15)
 				temp = "<font color = #D70B00>- FAILED: NETWORK TAG STRING TOO LENGHTLY -</font>"
 

code/game/machinery/wall_frames.dm

@@ -70,11 +70,11 @@
 	var/turf/loc = get_turf(user)
 	var/area/A = loc.loc
 	if(!istype(loc, /turf/simulated/floor))
-		to_chat(user, span_danger("\The frame cannot be placed on this spot."))
+		to_chat(user, span_danger("\The [src] cannot be placed on this spot."))
 		return
 
 	if(A.requires_power == 0 || A.name == "Space")
-		to_chat(user, span_danger("\The [src] Alarm cannot be placed in this area."))
+		to_chat(user, span_danger("\The [src] cannot be placed in this area."))
 		return
 
 	if(gotwallitem(loc, ndir))

code/game/memory_profiler_ch.dm

@@ -138,7 +138,7 @@
 			by_variable[variable] += 16
 
 /proc/list_memory_size(list/L,list/list_of_lists,list/recursed_from)
-	if(L in recursed_from || LAZYLEN(recursed_from) > 64 || (LAZYLEN(recursed_from) && (L in list_of_lists))) return 0
+	if((L in recursed_from) || LAZYLEN(recursed_from) > 64 || (LAZYLEN(recursed_from) && (L in list_of_lists))) return 0
 	if(LAZYLEN(recursed_from) && refcount(L) > 4)
 		if(L in list_of_lists) list_of_lists[L]++
 		else list_of_lists[L] = 1

code/game/objects/items/devices/communicator/helper.dm

@@ -393,8 +393,9 @@
 // Copied from /obj/machinery/computer/supplycomp/ui_interact(),
 // code\game\machinery\computer\supply.dm, starting at line 55
 /obj/item/commcard/proc/get_supply_shuttle_status()
-	var/shuttle_status[0]
+	var/list/shuttle_status = list()
 	var/datum/shuttle/autodock/ferry/supply/shuttle = SSsupply.shuttle
+
 	if(shuttle)
 		if(shuttle.has_arrive_time())
 			shuttle_status["location"] = "In transit"
@@ -445,7 +446,7 @@
 				shuttle_status["engine"] = "Engaged"
 
 	else
-		shuttle["mode"] = SUP_SHUTTLE_ERROR
+		shuttle_status["mode"] = SUP_SHUTTLE_ERROR
 
 	return shuttle_status
 

code/game/objects/items/devices/defib.dm

@@ -272,11 +272,7 @@
 
 //Checks for various conditions to see if the mob is revivable
 /obj/item/shockpaddles/proc/can_defib(mob/living/carbon/human/H) //This is checked before doing the defib operation
-	//CHOMPEdit Begin - Vox can be revived with jumper cables
-	if(H.get_species() == SPECIES_VOX && use_on_synthetic)
-		// Will silently continue to the other two checks.
-	//CHOMPEdit End - Edit included the else on the next line.
-	else if((H.species.flags & NO_DEFIB))
+	if((H.species.flags & NO_DEFIB))
 		return "buzzes, \"Incompatible physiology. Operation aborted.\""
 	else if(H.isSynthetic() && !use_on_synthetic)
 		return "buzzes, \"Synthetic Body. Operation aborted.\""

code/game/objects/items/devices/flash.dm

@@ -195,7 +195,7 @@
 						H.eye_blurry = max(H.eye_blurry, flash_strength + 5)
 						H.flash_eyes()
 						H.adjustHalLoss(halloss_per_flash * (flash_strength / 5)) // Should take four flashes to stun.
-						H.apply_damage(flash_strength * H.species.flash_burn/5, BURN, BP_HEAD, 0, 0, "Photon burns")
+						H.apply_damage(flash_strength * H.species.flash_burn/5, BURN, BP_HEAD, 0, 0)
 
 			else
 				flashfail = 1

code/game/objects/items/weapons/capture_crystal.dm

@@ -483,8 +483,8 @@
 
 //IF the crystal somehow ends up in a tummy and digesting with a bound mob who doesn't want to be eaten, let's move them to the ground
 /obj/item/capture_crystal/digest_act(var/atom/movable/item_storage = null)
-	if(bound_mob) //CHOMPEdit
-		if(bound_mob in contents && !bound_mob.devourable)
+	if(bound_mob) // CHOMPEdit
+		if((bound_mob in contents) && !bound_mob.devourable)
 			bound_mob.forceMove(src.drop_location())
 	return ..()
 

code/game/objects/items/weapons/material/shards.dm

@@ -89,11 +89,11 @@
 
 	if(user.gloves && !protected_hands)
 		to_chat(user, span_warning("\The [src] partially cuts into your hand through your gloves as you hit \the [target]!"))
-		user.apply_damage(light_glove_d + will_break ? break_damage : 0, BRUTE, active_hand, 0, 0, src, src.sharp, src.edge) // Ternary to include break damage
+		user.apply_damage(light_glove_d + will_break ? break_damage : 0, BRUTE, active_hand, 0, 0, src.sharp, src.edge, src) // Ternary to include break damage
 
 	else if(!user.gloves)
 		to_chat(user, span_warning("\The [src] cuts into your hand as you hit \the [target]!"))
-		user.apply_damage(no_glove_d + will_break ? break_damage : 0, BRUTE, active_hand, 0, 0, src, src.sharp, src.edge)
+		user.apply_damage(no_glove_d + will_break ? break_damage : 0, BRUTE, active_hand, 0, 0, src.sharp, src.edge, src)
 
 	if(will_break && src.loc == user) // If it's not in our hand anymore
 		user.visible_message(span_danger("[user] hit \the [target] with \the [src], shattering it!"), span_warning("You shatter \the [src] in your hand!"))

code/game/objects/items/weapons/traps.dm

@@ -352,7 +352,7 @@
 
 	L.add_modifier(/datum/modifier/entangled, 3 SECONDS)
 
-	if(!L.apply_damage(force * (issilicon(L) ? 0.25 : 1), BRUTE, target_zone, blocked, soaked, src, sharp, edge))
+	if(!L.apply_damage(force * (issilicon(L) ? 0.25 : 1), BRUTE, target_zone, blocked, soaked, sharp, edge, src))
 		return
 
 	playsound(src, 'sound/effects/glass_step.ogg', 50, 1) // not sure how to handle metal shards with sounds

code/game/objects/micro_structures.dm

@@ -70,7 +70,6 @@ var/global/list/micro_tunnels = list()
 	for(var/datum/planet/P in SSplanets.planets)
 		if(myturf.z in P.expected_z_levels)
 			planet = P
-		else
 	for(var/obj/structure/micro_tunnel/t in micro_tunnels)
 		if(t == src)
 			continue
@@ -85,7 +84,6 @@ var/global/list/micro_tunnels = list()
 			if(targetturf.z in planet.expected_z_levels)
 				destinations |= t
 				continue
-			else
 		var/above = GetAbove(myturf)
 		if(above && t.z == z + 1)
 			destinations |= t

code/game/objects/mob_spawner_vr.dm

@@ -181,7 +181,7 @@ It also makes it so a ghost wont know where all the goodies/mobs are.
 
 
 /obj/structure/mob_spawner/scanner/proc/CheckProximity(atom/movable/AM,turf/new_loc)
-	if(AM in mobs_in_range && (!AM || get_dist(src,new_loc) > range))
+	if((AM in mobs_in_range) && (!AM || get_dist(src,new_loc) > range))
 		mobs_in_range -= AM
 
 //CHOMPEdit End

code/game/objects/structures/crates_lockers/crates.dm

@@ -152,7 +152,6 @@
 			if (prob(50))
 				qdel(src)
 			return
-		else
 	return
 
 /obj/structure/closet/crate/secure

code/game/objects/structures/gargoyle.dm

@@ -40,7 +40,7 @@
 		comp.paused = FALSE
 		identifier = length(comp.identifier) > 0 ? comp.identifier : initial(identifier)
 		material = length(comp.material) > 0 ? comp.material : initial(material)
-		tint = length(comp.tint) > 0 ? comp.tint : initial(tint)
+		tint = length(comp.tint) > 0 ? comp.tint : initial(comp.tint)
 		adjective = length(comp.adjective) > 0 ? comp.adjective : initial(adjective)
 		if (copytext_char(adjective, -1) != "s")
 			adjective += "s"

code/game/objects/structures/girders.dm

@@ -321,7 +321,6 @@
 			if (prob(5))
 				dismantle()
 			return
-		else
 	return
 
 /obj/structure/girder/cult

code/game/objects/structures/lattice.dm

@@ -50,7 +50,6 @@
 			return
 		if(3.0)
 			return
-		else
 	return
 
 /obj/structure/lattice/attackby(obj/item/C as obj, mob/user as mob)

code/game/objects/structures/medical_stand_vr.dm

@@ -275,7 +275,7 @@
 		to_chat(user, span_warning("There is no tank in \the [src]."))
 		return
 	if(is_loosen)
-		to_chat(user, span_warning("Tighten \the nut with a wrench first."))
+		to_chat(user, span_warning("Tighten the nut with a wrench first."))
 		return
 	if(!Adjacent(target))
 		return

code/game/objects/structures/railing.dm

@@ -277,7 +277,6 @@
 		if(3.0)
 			qdel(src)
 			return
-		else
 	return
 
 // Duplicated from structures.dm, but its a bit different.

code/game/objects/structures/signs.dm

@@ -1855,7 +1855,7 @@
 	desc = "The red flag of the Five Arrows."
 	description_fluff = "The Five Arrows is an independent government entity that seceded from the Solar Confederate Government in 2570, in response to perceived \
 	failures in aiding the Sagittarius Heights during the Skathari Incursion. The success of the government in achieving effective local defense and prosperity has \
-	since attracted the membership of Kauq'xum, a remote Skrellian colony. \The Five Arrows formed the model for SolGov's own semi-autonomous \"Regional Blocs\"."
+	since attracted the membership of Kauq'xum, a remote Skrellian colony. The Five Arrows formed the model for SolGov's own semi-autonomous \"Regional Blocs\"."
 	icon_state = "fivearrows"
 	flagtype = /obj/item/flag/fivearrows
 
@@ -1870,7 +1870,7 @@
 	desc = "The red flag of the Five Arrows."
 	description_fluff = "The Five Arrows is an independent government entity that seceded from the Solar Confederate Government in 2570, in response to perceived \
 	failures in aiding the Sagittarius Heights during the Skathari Incursion. The success of the government in achieving effective local defense and prosperity has \
-	since attracted the membership of Kauq'xum, a remote Skrellian colony. \The Five Arrows formed the model for SolGov's own semi-autonomous \"Regional Blocs\"."
+	since attracted the membership of Kauq'xum, a remote Skrellian colony. The Five Arrows formed the model for SolGov's own semi-autonomous \"Regional Blocs\"."
 	flag_path = "fivearrows"
 
 /obj/item/flag/fivearrows/l

code/game/objects/structures/transit_tubes.dm

@@ -581,7 +581,6 @@
 			return 6
 		if("SOUTHWEST", "SW")
 			return 10
-		else
 	return 0
 
 
@@ -606,5 +605,4 @@
 			return "NW"
 		if(10)
 			return "SW"
-		else
 	return

code/game/turfs/simulated/outdoors/outdoors.dm

@@ -52,7 +52,7 @@ var/list/turf_edge_cache = list()
 			user.setClickCooldown(delay)
 			if(do_after(user, delay, src))
 				new/obj/structure/closet/grave/dirthole(src)
-				to_chat(user, span_notice("You dug up \a hole!"))
+				to_chat(user, span_notice("You dug up a hole!"))
 				return
 		else
 			to_chat(user, span_notice("\The [user] begins digging into \the [src] with \the [C]."))