Merge pull request #2479 from caelaislinn/bleeding-edge-freeze

RUST updates, other

code/modules/events/grid_check.dm

@@ -1,11 +1,11 @@
 /datum/event/grid_check	//NOTE: Times are measured in master controller ticks!
-	startWhen		= 5
+	announceWhen		= 5
 
 /datum/event/grid_check/setup()
-	endWhen = rand(90,600)
+	endWhen = rand(30,120)
 
 /datum/event/grid_check/start()
-	power_failure(1)
+	power_failure(0)
 
 /datum/event/grid_check/announce()
 	command_alert("Abnormal activity detected in [station_name()]'s powernet. As a precautionary measure, the station's power will be shut off for an indeterminate duration.", "Automated Grid Check")
@@ -13,7 +13,4 @@
 		M << sound('sound/AI/poweroff.ogg')
 
 /datum/event/grid_check/end()
-	command_alert("Power has been restored to [station_name()]. We apologize for the inconvenience.", "Power Systems Nominal")
-	for(var/mob/M in player_list)
-		M << sound('sound/AI/poweron.ogg')
 	power_restore()

code/modules/power/generator.dm

@@ -1,18 +1,14 @@
-// dummy generator object for testing
 
-/*/obj/machinery/power/generator/verb/set_amount(var/g as num)
-	set src in view(1)
-
-	gen_amount = g
-
-*/
+//updated by cael_aislinn on 5/3/2013 to be rotateable, moveable and generally more flexible
 /obj/machinery/power/generator
 	name = "thermoelectric generator"
 	desc = "It's a high efficiency thermoelectric generator."
 	icon_state = "teg"
-	anchored = 1
 	density = 1
 	use_power = 0
+	anchored = 0
+	idle_power_usage = 50
+	active_power_usage = 1000
 
 	var/obj/machinery/atmospherics/binary/circulator/circ1
 	var/obj/machinery/atmospherics/binary/circulator/circ2
@@ -20,28 +16,39 @@
 	var/lastgen = 0
 	var/lastgenlev = -1
 
-
 /obj/machinery/power/generator/New()
 	..()
 
-	spawn(5)
-		circ1 = locate(/obj/machinery/atmospherics/binary/circulator) in get_step(src,WEST)
-		circ2 = locate(/obj/machinery/atmospherics/binary/circulator) in get_step(src,EAST)
+	spawn(1)
+		reconnect()
 
-		if(circ1)
-			circ1.side = 1
-			circ1.update_icon()
-		if(circ2)
-			circ2.side = 2
-			circ2.update_icon()
+//generators connect in dir and reverse_dir(dir) directions
+//mnemonic to determine circulator/generator directions: the cirulators orbit clockwise around the generator
+//so a circulator to the NORTH of the generator connects first to the EAST, then to the WEST
+//and a circulator to the WEST of the generator connects first to the NORTH, then to the SOUTH
+//note that the circulator's outlet dir is it's always facing dir, and it's inlet is always the reverse
+/obj/machinery/power/generator/proc/reconnect()
+	circ1 = null
+	circ2 = null
+	if(src.loc && anchored)
+		if(src.dir & (EAST|WEST))
+			circ1 = locate(/obj/machinery/atmospherics/binary/circulator) in get_step(src,EAST)
+			circ2 = locate(/obj/machinery/atmospherics/binary/circulator) in get_step(src,WEST)
 
-		if(!circ1 || !circ2)
-			stat |= BROKEN
+			if(circ1 && circ2)
+				if(circ1.dir != SOUTH || circ2.dir != NORTH)
+					circ1 = null
+					circ2 = null
 
-		updateicon()
+		else if(src.dir & (NORTH|SOUTH))
+			circ1 = locate(/obj/machinery/atmospherics/binary/circulator) in get_step(src,NORTH)
+			circ2 = locate(/obj/machinery/atmospherics/binary/circulator) in get_step(src,SOUTH)
+
+			if(circ1 && circ2 && (circ1.dir != EAST || circ2.dir != WEST))
+				circ1 = null
+				circ2 = null
 
 /obj/machinery/power/generator/proc/updateicon()
-
 	if(stat & (NOPOWER|BROKEN))
 		overlays.Cut()
 	else
@@ -56,57 +63,64 @@
 
 	//world << "Generator process ran"
 
-	if(!circ1 || !circ2)
+	if(!circ1 || !circ2 || !anchored || stat & (BROKEN|NOPOWER))
 		return
 
 	//world << "circ1 and circ2 pass"
 
-	var/datum/gas_mixture/cold_air = circ1.return_transfer_air()
-	var/datum/gas_mixture/hot_air = circ2.return_transfer_air()
+	var/datum/gas_mixture/air1 = circ1.return_transfer_air()
+	var/datum/gas_mixture/air2 = circ2.return_transfer_air()
 
 	lastgen = 0
 
 	//world << "hot_air = [hot_air]; cold_air = [cold_air];"
 
-	if(cold_air && hot_air)
+	if(air1 && air2)
 
-		//world << "hot_air = [hot_air] temperature = [hot_air.temperature]; cold_air = [cold_air] temperature = [hot_air.temperature];"
+		//world << "hot_air = [hot_air] temperature = [air2.temperature]; cold_air = [cold_air] temperature = [air2.temperature];"
 
 		//world << "coldair and hotair pass"
-		var/cold_air_heat_capacity = cold_air.heat_capacity()
-		var/hot_air_heat_capacity = hot_air.heat_capacity()
+		var/air1_heat_capacity = air1.heat_capacity()
+		var/air2_heat_capacity = air2.heat_capacity()
+		var/delta_temperature = abs(air2.temperature - air1.temperature)
 
-		var/delta_temperature = hot_air.temperature - cold_air.temperature
+		//world << "delta_temperature = [delta_temperature]; air1_heat_capacity = [air1_heat_capacity]; air2_heat_capacity = [air2_heat_capacity]"
 
-		//world << "delta_temperature = [delta_temperature]; cold_air_heat_capacity = [cold_air_heat_capacity]; hot_air_heat_capacity = [hot_air_heat_capacity]"
-
-		if(delta_temperature > 0 && cold_air_heat_capacity > 0 && hot_air_heat_capacity > 0)
+		if(delta_temperature > 0 && air1_heat_capacity > 0 && air2_heat_capacity > 0)
+			use_power = 2
 			var/efficiency = 0.65
-
-			var/energy_transfer = delta_temperature*hot_air_heat_capacity*cold_air_heat_capacity/(hot_air_heat_capacity+cold_air_heat_capacity)
-
+			var/energy_transfer = delta_temperature*air2_heat_capacity*air1_heat_capacity/(air2_heat_capacity+air1_heat_capacity)
 			var/heat = energy_transfer*(1-efficiency)
 			lastgen = energy_transfer*efficiency
 
-			//world << "lastgen = [lastgen]; heat = [heat]; delta_temperature = [delta_temperature]; hot_air_heat_capacity = [hot_air_heat_capacity]; cold_air_heat_capacity = [cold_air_heat_capacity];"
+			//world << "lastgen = [lastgen]; heat = [heat]; delta_temperature = [delta_temperature]; air2_heat_capacity = [air2_heat_capacity]; air1_heat_capacity = [air1_heat_capacity];"
 
-			hot_air.temperature = hot_air.temperature - energy_transfer/hot_air_heat_capacity
-			cold_air.temperature = cold_air.temperature + heat/cold_air_heat_capacity
+			if(air2.temperature > air1.temperature)
+				air2.temperature = air2.temperature - energy_transfer/air2_heat_capacity
+				air1.temperature = air1.temperature + heat/air1_heat_capacity
+			else
+				air2.temperature = air2.temperature + heat/air2_heat_capacity
+				air1.temperature = air1.temperature - energy_transfer/air1_heat_capacity
 
-			world << "POWER: [lastgen] W generated at [efficiency*100]% efficiency and sinks sizes [cold_air_heat_capacity], [hot_air_heat_capacity]"
+			//world << "POWER: [lastgen] W generated at [efficiency*100]% efficiency and sinks sizes [air1_heat_capacity], [air2_heat_capacity]"
 
 			add_avail(lastgen)
-	// update icon overlays only if displayed level has changed
 
-	if(hot_air)
-		circ2.air2.merge(hot_air)
+	if(air1)
+		circ1.air2.merge(air1)
 
-	if(cold_air)
-		circ1.air2.merge(cold_air)
+	if(air2)
+		circ2.air2.merge(air2)
 
+	// update icon overlays and power usage only if displayed level has changed
 	var/genlev = max(0, min( round(11*lastgen / 100000), 11))
 	if(genlev != lastgenlev)
 		lastgenlev = genlev
+		active_power_usage = lastgenlev * 1000
+		if(lastgenlev > 0)
+			use_power = 2
+		else
+			use_power = 1
 		updateicon()
 
 	src.updateDialog()
@@ -115,10 +129,18 @@
 	if(stat & (BROKEN|NOPOWER)) return
 	interact(user)
 
+/obj/machinery/power/generator/attackby(obj/item/weapon/W as obj, mob/user as mob)
+	if(istype(W, /obj/item/weapon/wrench))
+		anchored = !anchored
+		user << "\blue You [anchored ? "secure" : "unsecure"] the bolts holding [src] to the floor."
+		use_power = anchored
+		reconnect()
+	else
+		..()
 
 /obj/machinery/power/generator/attack_hand(mob/user)
 	add_fingerprint(user)
-	if(stat & (BROKEN|NOPOWER)) return
+	if(stat & (BROKEN|NOPOWER) || !anchored) return
 	interact(user)
 
 
@@ -132,19 +154,28 @@
 
 	var/t = "<PRE><B>Thermo-Electric Generator</B><HR>"
 
-	t += "Output : [round(lastgen)] W<BR><BR>"
+	if(circ1 && circ2)
+		t += "Output : [round(lastgen)] W<BR><BR>"
 
-	t += "<B>Cold loop</B><BR>"
-	t += "Temperature Inlet: [round(circ1.air1.temperature, 0.1)] K  Outlet: [round(circ1.air2.temperature, 0.1)] K<BR>"
-	t += "Pressure Inlet: [round(circ1.air1.return_pressure(), 0.1)] kPa  Outlet: [round(circ1.air2.return_pressure(), 0.1)] kPa<BR>"
+		t += "<B>Primary Circulator (top/right)</B><BR>"
+		t += "Inlet Pressure: [round(circ1.air1.return_pressure(), 0.1)] kPa<BR>"
+		t += "Inlet Temperature: [round(circ1.air1.temperature, 0.1)] K<BR>"
+		t += "Outlet Pressure: [round(circ1.air2.return_pressure(), 0.1)] kPa<BR>"
+		t += "Outlet Temperature: [round(circ1.air2.temperature, 0.1)] K<BR>"
 
-	t += "<B>Hot loop</B><BR>"
-	t += "Temperature Inlet: [round(circ2.air1.temperature, 0.1)] K  Outlet: [round(circ2.air2.temperature, 0.1)] K<BR>"
-	t += "Pressure Inlet: [round(circ2.air1.return_pressure(), 0.1)] kPa  Outlet: [round(circ2.air2.return_pressure(), 0.1)] kPa<BR>"
+		t += "<B>Secondary Circulator (bottom/left)</B><BR>"
+		t += "Inlet Pressure: [round(circ2.air1.return_pressure(), 0.1)] kPa<BR>"
+		t += "Inlet Temperature: [round(circ2.air1.temperature, 0.1)] K<BR>"
+		t += "Outlet Pressure: [round(circ2.air2.return_pressure(), 0.1)] kPa<BR>"
+		t += "Outlet Temperature: [round(circ2.air2.temperature, 0.1)] K<BR>"
+	else
+		t += "Unable to connect to circulators.<br>"
+		t += "Ensure both are in position and wrenched into place."
 
-	t += "<BR><HR><A href='?src=\ref[src];close=1'>Close</A>"
+	t += "<BR>"
+	t += "<HR>"
+	t += "<A href='?src=\ref[src]'>Refresh</A> <A href='?src=\ref[src];close=1'>Close</A>"
 
-	t += "</PRE>"
 	user << browse(t, "window=teg;size=460x300")
 	onclose(user, "teg")
 	return 1
@@ -156,6 +187,7 @@
 		usr << browse(null, "window=teg")
 		usr.unset_machine()
 		return 0
+	updateDialog()
 	return 1
 
 
@@ -163,3 +195,13 @@
 	..()
 	updateicon()
 
+
+/obj/machinery/power/generator/verb/rotate()
+	set category = "Object"
+	set name = "Rotate Generator"
+	set src in view(1)
+
+	if (usr.stat || usr.restrained()  || anchored)
+		return
+
+	src.dir = turn(src.dir, 90)

code/modules/power/generator_type2.dm

@@ -69,7 +69,7 @@
 			hot_air.temperature = hot_air.temperature - energy_transfer/hot_air_heat_capacity
 			cold_air.temperature = cold_air.temperature + heat/cold_air_heat_capacity
 
-			world << "POWER: [lastgen] W generated at [efficiency*100]% efficiency and sinks sizes [cold_air_heat_capacity], [hot_air_heat_capacity]"
+			//world << "POWER: [lastgen] W generated at [efficiency*100]% efficiency and sinks sizes [cold_air_heat_capacity], [hot_air_heat_capacity]"
 
 			if(input1.network)
 				input1.network.update = 1