[MIRROR] Linter diagnostics + bans non-var relative pathing

code/modules/admin/DB ban/functions.dm

@@ -1,6 +1,6 @@
 
 //Either pass the mob you wish to ban in the 'banned_mob' attribute, or the banckey, banip and bancid variables. If both are passed, the mob takes priority! If a mob is not passed, banckey is the minimum that needs to be passed! banip and bancid are optional.
-datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration = -1, var/reason, var/job = "", var/rounds = 0, var/banckey = null, var/banip = null, var/bancid = null)
+/datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration = -1, var/reason, var/job = "", var/rounds = 0, var/banckey = null, var/banip = null, var/bancid = null)
 
 	if(!check_rights(R_MOD,0) && !check_rights(R_BAN))	return
 
@@ -90,7 +90,7 @@ datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration =
 	qdel(query_insert) //CHOMPEdit TGSQL
 
 
-datum/admins/proc/DB_ban_unban(var/ckey, var/bantype, var/job = "")
+/datum/admins/proc/DB_ban_unban(var/ckey, var/bantype, var/job = "")
 
 	if(!check_rights(R_BAN))	return
 
@@ -154,7 +154,7 @@ datum/admins/proc/DB_ban_unban(var/ckey, var/bantype, var/job = "")
 
 	DB_ban_unban_by_id(ban_id)
 
-datum/admins/proc/DB_ban_edit(var/banid = null, var/param = null)
+/datum/admins/proc/DB_ban_edit(var/banid = null, var/param = null)
 
 	if(!check_rights(R_BAN))	return
 
@@ -212,7 +212,7 @@ datum/admins/proc/DB_ban_edit(var/banid = null, var/param = null)
 	to_chat(usr, "<span class='filter_adminlog'>Cancelled</span>")
 	return
 
-datum/admins/proc/DB_ban_unban_by_id(var/id)
+/datum/admins/proc/DB_ban_unban_by_id(var/id)
 
 	if(!check_rights(R_BAN))	return
 

code/modules/admin/IsBanned.dm

@@ -1,6 +1,6 @@
 #ifndef OVERRIDE_BAN_SYSTEM
 //Blocks an attempt to connect before even creating our client datum thing.
-world/IsBanned(key,address,computer_id)
+/world/IsBanned(key,address,computer_id)
 	if(ckey(key) in admin_datums)
 		return ..()
 
@@ -81,5 +81,4 @@ world/IsBanned(key,address,computer_id)
 			message_admins("[key] has logged in with a blank ip in the ban check.")
 		return ..()	//default pager ban stuff
 #endif
-#undef OVERRIDE_BAN_SYSTEM
 

code/modules/admin/admin.dm

@@ -20,7 +20,7 @@ var/global/floorIsLava = 0
 				var/msg = rendered
 				to_chat(C,msg)
 
-proc/admin_notice(var/message, var/rights)
+/proc/admin_notice(var/message, var/rights)
 	for(var/mob/M in mob_list)
 		if(check_rights(rights, 0, M))
 			to_chat(M,message)
@@ -1578,7 +1578,7 @@ var/datum/announcement/minor/admin_min_announcer = new
 			P.adminbrowse()
 
 
-datum/admins/var/obj/item/weapon/paper/admin/faxreply // var to hold fax replies in
+/datum/admins/var/obj/item/weapon/paper/admin/faxreply // var to hold fax replies in
 
 /datum/admins/proc/faxCallback(var/obj/item/weapon/paper/admin/P, var/obj/machinery/photocopier/faxmachine/destination)
 	var/customname = input(src.owner, "Pick a title for the report", "Title") as text|null

code/modules/admin/admin_attack_log.dm

@@ -3,11 +3,11 @@
 /mob/var/attack_log = list( )
 /mob/var/dialogue_log = list( )
 
-proc/log_and_message_admins(var/message as text, var/mob/user = usr)
+/proc/log_and_message_admins(var/message as text, var/mob/user = usr)
 	log_admin(user ? "[key_name(user)] [message]" : "EVENT [message]")
 	message_admins(user ? "[key_name_admin(user)] [message]" : "EVENT [message]")
 
-proc/log_and_message_admins_many(var/list/mob/users, var/message)
+/proc/log_and_message_admins_many(var/list/mob/users, var/message)
 	if(!users || !users.len)
 		return
 
@@ -18,7 +18,7 @@ proc/log_and_message_admins_many(var/list/mob/users, var/message)
 	log_admin("[english_list(user_keys)] [message]")
 	message_admins("[english_list(user_keys)] [message]")
 /* Old procs
-proc/admin_attack_log(var/mob/attacker, var/mob/victim, var/attacker_message, var/victim_message, var/admin_message)
+/proc/admin_attack_log(var/mob/attacker, var/mob/victim, var/attacker_message, var/victim_message, var/admin_message)
 	if(victim)
 		victim.attack_log += text("\[[time_stamp()]\] <font color='orange'>[key_name(attacker)] - [victim_message]</font>")
 	if(attacker)
@@ -26,14 +26,14 @@ proc/admin_attack_log(var/mob/attacker, var/mob/victim, var/attacker_message, va
 
 	msg_admin_attack("[key_name(attacker)] [admin_message] [key_name(victim)] (INTENT: [attacker? uppertext(attacker.a_intent) : "N/A"]) (<A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[attacker.x];Y=[attacker.y];Z=[attacker.z]'>JMP</a>)")
 
-proc/admin_attacker_log_many_victims(var/mob/attacker, var/list/mob/victims, var/attacker_message, var/victim_message, var/admin_message)
+/proc/admin_attacker_log_many_victims(var/mob/attacker, var/list/mob/victims, var/attacker_message, var/victim_message, var/admin_message)
 	if(!victims || !victims.len)
 		return
 
 	for(var/mob/victim in victims)
 		admin_attack_log(attacker, victim, attacker_message, victim_message, admin_message)
 
-proc/admin_inject_log(mob/attacker, mob/victim, obj/item/weapon, reagents, amount_transferred, violent=0)
+/proc/admin_inject_log(mob/attacker, mob/victim, obj/item/weapon, reagents, amount_transferred, violent=0)
 	if(violent)
 		violent = "violently "
 	else

code/modules/admin/admin_report.dm

@@ -3,7 +3,7 @@
 // they can only be read by admins and moderators.
 
 // a single admin report
-datum/admin_report/var
+/datum//admin_report/var
 	ID     // the ID of the report
 	body   // the content of the report
 	author // key of the author
@@ -13,7 +13,7 @@ datum/admin_report/var
 	offender_key // store the key of the offender
 	offender_cid // store the cid of the offender
 
-datum/report_topic_handler
+/datum//report_topic_handler
 	Topic(href,href_list)
 		..()
 		var/client/C = locate(href_list["client"])
@@ -31,7 +31,7 @@ world/New()
 	report_topic_handler = new
 
 // add a new news datums
-proc/make_report(body, author, okey, cid)
+/proc/make_report(body, author, okey, cid)
 	var/savefile/Reports = new("data/reports.sav")
 	var/list/reports
 	var/lastID
@@ -57,7 +57,7 @@ proc/make_report(body, author, okey, cid)
 	Reports["lastID"] << lastID
 
 // load the reports from disk
-proc/load_reports()
+/proc/load_reports()
 	var/savefile/Reports = new("data/reports.sav")
 	var/list/reports
 
@@ -68,7 +68,7 @@ proc/load_reports()
 	return reports
 
 // check if there are any unhandled reports
-client/proc/unhandled_reports()
+/client/proc/unhandled_reports()
 	if(!src.holder) return 0
 	var/list/reports = load_reports()
 
@@ -80,7 +80,7 @@ client/proc/unhandled_reports()
 	return 0
 
 // checks if the player has an unhandled report against him
-client/proc/is_reported()
+/client/proc/is_reported()
 	var/list/reports = load_reports()
 
 	for(var/datum/admin_report/N in reports) if(!N.done)
@@ -90,7 +90,7 @@ client/proc/is_reported()
 	return 0
 
 // display only the reports that haven't been handled
-client/proc/display_admin_reports()
+/client/proc/display_admin_reports()
 	set category = "Admin"
 	set name = "Display Admin Reports"
 	if(!src.holder) return
@@ -118,7 +118,7 @@ client/proc/display_admin_reports()
 	usr << browse(output, "window=news;size=600x400")
 
 
-client/proc/Report(mob/M as mob in world)
+/client/proc/Report(mob/M as mob in world)
 	set category = "Admin"
 	if(!src.holder)
 		return
@@ -136,7 +136,7 @@ client/proc/Report(mob/M as mob in world)
 	spawn(1)
 		display_admin_reports()
 
-client/proc/mark_report_done(ID as num)
+/client/proc/mark_report_done(ID as num)
 	if(!src.holder || src.holder.level < 0)
 		return
 
@@ -157,7 +157,7 @@ client/proc/mark_report_done(ID as num)
 	Reports["reports"]   << reports
 
 
-client/proc/edit_report(ID as num)
+/client/proc/edit_report(ID as num)
 	if(!src.holder || src.holder.level < 0)
 		to_chat(src, "<b>You tried to modify the news, but you're not an admin!</b>")
 		return

code/modules/admin/holder2.dm

@@ -60,7 +60,7 @@ if rights_required == 0, then it simply checks if they are an admin.
 if it doesn't return 1 and show_msg=1 it will prints a message explaining why the check has failed
 generally it would be used like so:
 
-proc/admin_proc()
+/proc/admin_proc()
 	if(!check_rights(R_ADMIN)) return
 	to_world("you have enough rights!")
 

code/modules/admin/player_notes.dm

@@ -4,11 +4,11 @@
 /*
 #define NOTESFILE "data/player_notes.sav"	//where the player notes are saved
 
-datum/admins/proc/notes_show(var/ckey)
+/datum/admins/proc/notes_show(var/ckey)
 	usr << browse("<head><title>Player Notes</title></head><body>[notes_gethtml(ckey)]</body>","window=player_notes;size=700x400")
 
 
-datum/admins/proc/notes_gethtml(var/ckey)
+/datum/admins/proc/notes_gethtml(var/ckey)
 	var/savefile/notesfile = new(NOTESFILE)
 	if(!notesfile)	return "<font color='red'>Error: Cannot access [NOTESFILE]</font>"
 	if(ckey)

code/modules/admin/topic.dm

@@ -1979,13 +1979,13 @@
 				PlayerNotesFilter()
 		return
 
-mob/living/proc/can_centcom_reply()
+/mob/living/proc/can_centcom_reply()
 	return 0
 
-mob/living/carbon/human/can_centcom_reply()
+/mob/living/carbon/human/can_centcom_reply()
 	return istype(l_ear, /obj/item/device/radio/headset) || istype(r_ear, /obj/item/device/radio/headset)
 
-mob/living/silicon/ai/can_centcom_reply()
+/mob/living/silicon/ai/can_centcom_reply()
 	return common_radio != null && !check_unable(2)
 
 /atom/proc/extra_admin_link()

code/modules/admin/verbs/buildmode.dm

@@ -66,115 +66,117 @@
 /obj/effect/bmode/builddir
 	icon_state = "build"
 	screen_loc = "NORTH,WEST"
-	Click()
-		switch(dir)
-			if(NORTH)
-				set_dir(EAST)
-			if(EAST)
-				set_dir(SOUTH)
-			if(SOUTH)
-				set_dir(WEST)
-			if(WEST)
-				set_dir(NORTHWEST)
-			if(NORTHWEST)
-				set_dir(NORTH)
-		return 1
+
+/obj/effect/bmode/builddir/Click()
+	switch(dir)
+		if(NORTH)
+			set_dir(EAST)
+		if(EAST)
+			set_dir(SOUTH)
+		if(SOUTH)
+			set_dir(WEST)
+		if(WEST)
+			set_dir(NORTHWEST)
+		if(NORTHWEST)
+			set_dir(NORTH)
+	return 1
 
 /obj/effect/bmode/buildhelp
 	icon = 'icons/misc/buildmode.dmi'
 	icon_state = "buildhelp"
 	screen_loc = "NORTH,WEST+1"
-	Click()
-		switch(master.cl.buildmode)
 
-			if(BUILDMODE_BASIC)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Left Mouse Button        = Construct / Upgrade<br>\
-								Right Mouse Button       = Deconstruct / Delete / Downgrade<br>\
-								Left Mouse Button + ctrl = R-Window<br>\
-								Left Mouse Button + alt  = Airlock<br><br>\
-								Use the button in the upper left corner to<br>\
-								change the direction of built objects.<br>\
-								***********************************************************</span>")
+/obj/effect/bmode/buildhelp/Click()
+	switch(master.cl.buildmode)
 
-			if(BUILDMODE_ADVANCED)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Right Mouse Button on buildmode button = Set object type<br>\
-								Middle Mouse Button on buildmode button= On/Off object type saying<br>\
-								Middle Mouse Button on turf/obj        = Capture object type<br>\
-								Left Mouse Button on turf/obj          = Place objects<br>\
-								Right Mouse Button                     = Delete objects<br>\
-								Mouse Button + ctrl                    = Copy object type<br><br>\
-								Use the button in the upper left corner to<br>\
-								change the direction of built objects.<br>\
-								***********************************************************</span>")
+		if(BUILDMODE_BASIC)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Left Mouse Button        = Construct / Upgrade<br>\
+							Right Mouse Button       = Deconstruct / Delete / Downgrade<br>\
+							Left Mouse Button + ctrl = R-Window<br>\
+							Left Mouse Button + alt  = Airlock<br><br>\
+							Use the button in the upper left corner to<br>\
+							change the direction of built objects.<br>\
+							***********************************************************</span>")
 
-			if(BUILDMODE_EDIT)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Right Mouse Button on buildmode button = Select var(type) & value<br>\
-								Left Mouse Button on turf/obj/mob      = Set var(type) & value<br>\
-								Right Mouse Button on turf/obj/mob     = Reset var's value<br>\
-								***********************************************************</span>")
+		if(BUILDMODE_ADVANCED)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Right Mouse Button on buildmode button = Set object type<br>\
+							Middle Mouse Button on buildmode button= On/Off object type saying<br>\
+							Middle Mouse Button on turf/obj        = Capture object type<br>\
+							Left Mouse Button on turf/obj          = Place objects<br>\
+							Right Mouse Button                     = Delete objects<br>\
+							Mouse Button + ctrl                    = Copy object type<br><br>\
+							Use the button in the upper left corner to<br>\
+							change the direction of built objects.<br>\
+							***********************************************************</span>")
 
-			if(BUILDMODE_THROW)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Left Mouse Button on turf/obj/mob      = Select<br>\
-								Right Mouse Button on turf/obj/mob     = Throw<br>\
-								***********************************************************</span>")
+		if(BUILDMODE_EDIT)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Right Mouse Button on buildmode button = Select var(type) & value<br>\
+							Left Mouse Button on turf/obj/mob      = Set var(type) & value<br>\
+							Right Mouse Button on turf/obj/mob     = Reset var's value<br>\
+							***********************************************************</span>")
 
-			if(BUILDMODE_ROOM)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Left Mouse Button on turf              = Select as point A<br>\
-								Right Mouse Button on turf             = Select as point B<br>\
-								Right Mouse Button on buildmode button = Change floor/wall type<br>\
-								***********************************************************</span>")
+		if(BUILDMODE_THROW)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Left Mouse Button on turf/obj/mob      = Select<br>\
+							Right Mouse Button on turf/obj/mob     = Throw<br>\
+							***********************************************************</span>")
 
-			if(BUILDMODE_LADDER)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Left Mouse Button on turf              = Set as upper ladder loc<br>\
-								Right Mouse Button on turf             = Set as lower ladder loc<br>\
-								***********************************************************</span>")
+		if(BUILDMODE_ROOM)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Left Mouse Button on turf              = Select as point A<br>\
+							Right Mouse Button on turf             = Select as point B<br>\
+							Right Mouse Button on buildmode button = Change floor/wall type<br>\
+							***********************************************************</span>")
 
-			if(BUILDMODE_CONTENTS)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Left Mouse Button on turf/obj/mob      = Select<br>\
-								Right Mouse Button on turf/obj/mob     = Move into selection<br>\
-								***********************************************************</span>")
+		if(BUILDMODE_LADDER)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Left Mouse Button on turf              = Set as upper ladder loc<br>\
+							Right Mouse Button on turf             = Set as lower ladder loc<br>\
+							***********************************************************</span>")
 
-			if(BUILDMODE_LIGHTS)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Left Mouse Button on turf/obj/mob      = Make it glow<br>\
-								Right Mouse Button on turf/obj/mob     = Reset glowing<br>\
-								Right Mouse Button on buildmode button = Change glow properties<br>\
-								***********************************************************</span>")
+		if(BUILDMODE_CONTENTS)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Left Mouse Button on turf/obj/mob      = Select<br>\
+							Right Mouse Button on turf/obj/mob     = Move into selection<br>\
+							***********************************************************</span>")
 
-			if(BUILDMODE_AI)
-				to_chat(usr, "<span class='notice'>***********************************************************<br>\
-								Left Mouse Button drag box             = Select only mobs in box<br>\
-								Left Mouse Button drag box + shift     = Select additional mobs in area<br>\
-								Left Mouse Button on non-mob           = Deselect all mobs<br>\
-								Left Mouse Button on AI mob            = Select/Deselect mob<br>\
-								Left Mouse Button + alt on AI mob      = Toggle hostility on mob<br>\
-								Left Mouse Button + shift on AI mob    = Toggle AI (also resets)<br>\
-								Left Mouse Button + ctrl on AI mob 	  = Copy mob faction<br>\
-								Right Mouse Button + ctrl on any mob   = Paste mob faction copied with Left Mouse Button + shift<br>\
-								Right Mouse Button on enemy mob        = Command selected mobs to attack mob<br>\
-								Right Mouse Button on allied mob       = Command selected mobs to follow mob<br>\
-								Right Mouse Button + shift on any mob  = Command selected mobs to follow mob regardless of faction<br>\
-								Note: The following also reset the mob's home position:<br>\
-								Right Mouse Button on tile             = Command selected mobs to move to tile (will cancel if enemies are seen)<br>\
-								Right Mouse Button + shift on tile     = Command selected mobs to reposition to tile (will not be inturrupted by enemies)<br>\
-								Right Mouse Button + alt on obj/turfs  = Command selected mobs to attack obj/turf<br>\
-								***********************************************************</span>")
-		return 1
+		if(BUILDMODE_LIGHTS)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Left Mouse Button on turf/obj/mob      = Make it glow<br>\
+							Right Mouse Button on turf/obj/mob     = Reset glowing<br>\
+							Right Mouse Button on buildmode button = Change glow properties<br>\
+							***********************************************************</span>")
+
+		if(BUILDMODE_AI)
+			to_chat(usr, "<span class='notice'>***********************************************************<br>\
+							Left Mouse Button drag box             = Select only mobs in box<br>\
+							Left Mouse Button drag box + shift     = Select additional mobs in area<br>\
+							Left Mouse Button on non-mob           = Deselect all mobs<br>\
+							Left Mouse Button on AI mob            = Select/Deselect mob<br>\
+							Left Mouse Button + alt on AI mob      = Toggle hostility on mob<br>\
+							Left Mouse Button + shift on AI mob    = Toggle AI (also resets)<br>\
+							Left Mouse Button + ctrl on AI mob 	  = Copy mob faction<br>\
+							Right Mouse Button + ctrl on any mob   = Paste mob faction copied with Left Mouse Button + shift<br>\
+							Right Mouse Button on enemy mob        = Command selected mobs to attack mob<br>\
+							Right Mouse Button on allied mob       = Command selected mobs to follow mob<br>\
+							Right Mouse Button + shift on any mob  = Command selected mobs to follow mob regardless of faction<br>\
+							Note: The following also reset the mob's home position:<br>\
+							Right Mouse Button on tile             = Command selected mobs to move to tile (will cancel if enemies are seen)<br>\
+							Right Mouse Button + shift on tile     = Command selected mobs to reposition to tile (will not be inturrupted by enemies)<br>\
+							Right Mouse Button + alt on obj/turfs  = Command selected mobs to attack obj/turf<br>\
+							***********************************************************</span>")
+	return 1
 
 /obj/effect/bmode/buildquit
 	icon_state = "buildquit"
 	screen_loc = "NORTH,WEST+3"
 
-	Click()
-		togglebuildmode(master.cl.mob)
-		return 1
+/obj/effect/bmode/buildquit/Click()
+	togglebuildmode(master.cl.mob)
+	return 1
 
 /obj/effect/bmode/buildholder
 	density = 0

code/modules/admin/verbs/lightning_strike.dm

@@ -95,6 +95,5 @@
 				C.ear_deaf += 10
 			to_chat(L, span("danger", "Lightning struck nearby, and the thunderclap is deafening!"))
 
-#undef GROUNDING_ROD_RANGE
 #undef LIGHTNING_ZAP_RANGE
 #undef LIGHTNING_POWER

code/modules/admin/verbs/mapping.dm

@@ -28,9 +28,9 @@ GLOBAL_LIST_BOILERPLATE(all_debugging_effects, /obj/effect/debugging)
 	icon = 'icons/480x480.dmi'
 	icon_state = "25percent"
 
-	New()
-		src.pixel_x = -224
-		src.pixel_y = -224
+/obj/effect/debugging/camera_range/New()
+	src.pixel_x = -224
+	src.pixel_y = -224
 
 /obj/effect/debugging/marker
 	icon = 'icons/turf/areas.dmi'

code/modules/admin/verbs/playsound.dm

@@ -76,7 +76,7 @@ var/list/sounds_cache = list()
 				M << 'bananaphone.ogg'
 
 
-client/proc/space_asshole()
+/client/proc/space_asshole()
 	set category = "Fun"
 	set name = "Space Asshole"
 
@@ -87,7 +87,7 @@ client/proc/space_asshole()
 				M << 'sound/music/space_asshole.ogg'
 
 
-client/proc/honk_theme()
+/client/proc/honk_theme()
 	set category = "Fun"
 	set name = "Honk"
 

code/modules/admin/verbs/randomverbs.dm

@@ -161,7 +161,7 @@
 	feedback_add_details("admin_verb","GOD") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
 
 
-proc/cmd_admin_mute(mob/M as mob, mute_type, automute = 0)
+/proc/cmd_admin_mute(mob/M as mob, mute_type, automute = 0)
 	if(automute)
 		if(!config.automute_on)
 			return