Commit Graph

3285 Commits

Author SHA1 Message Date
petethegoat@gmail.com
84b9929282 Comitting for Giacom!
In short:
AI messaging
Time of death for health scanners
Most lists are sorted alphabetically

See http://nanotrasen.com/phpBB3/viewtopic.php?f=16&t=9220 for detailed information.

I wasn't able to test this as thoroughly as I'd like, but what I could test seems fine.
I don't forsee any issues popping up with this stuff.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3993 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-05 22:47:30 +00:00
sieve32@gmail.com
9e35d8cda8 Changes to Syndicate Radios, which fixes Issue 595. Now if a an radio doesn't have the Syndicate encryption on it, it won't receive any messages over the Syndicate channel(If I can learn TCOMMs a bit better I'll try to make it a per-message basis)
Changed 'traitor' headsets to 'syndicate' headsets to have it make a bit more sense. Syndicate encryption is tied to the keys, so anything with a Syndicate Key can hear the Syndicate Channel. 
Also, added 2 intercoms to the Nuke OP shuttle that are on the Syndicate frequency and have the needed encryption.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3991 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-05 21:36:15 +00:00
johnsonmt88@gmail.com
3bd93d58a8 git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3990 316c924e-a436-60f5-8080-3fe189b3f50e 2012-07-05 21:06:44 +00:00
sieve32@gmail.com
93e4d2c1ff Quick bugfix for falsewalls, defined an update_icon() for them that is called by smoothwalls to keep the icons from de-syncing.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3989 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-05 19:21:27 +00:00
elly1989@rocketmail.com
515d1652dd Aliens can now slash cameras to deactivate them.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3988 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-05 14:01:48 +00:00
elly1989@rocketmail.com
b88733fd89 Alien larva now chestburst even after their host has died. To do this I had to make a custom process() for the alien_embryo disease.
I gave up trying to get facehuggers  to hug laying down mobs after a throw. Instead I just fixed the attack() proc so aliens can slap them onto people's faces.

Changed the chestbursting code so larva are created even if no client is available. I will be making a verb so ghosts can posses aliens/larvae with no ckey depending on what headcoders think of the idea. I didn't think it fair that aliens should suffer because not enough ghosts have be_alien enabled at the exact moment a larvae chestbursts. 

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3987 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-05 13:21:25 +00:00
CIB123@gmail.com
d27457b405 Fixed the BE_CULTIST/BE_PAI mixup in the preferences.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3986 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-05 12:18:51 +00:00
elly1989@rocketmail.com
60c7b28274 Resolves issue 499. Blood runes are now totally invisible to AIs.
Created defines for disabilities and sdisabilities bitflags. Thos areas of code really need attention. Why are there so many blind variables/flags D= disability bitflags are located in setup.dm

Handcuff overlays now update when beepsky/ed-209s cuff you.

Resolves issue 628. Took a stab at tidying up handle_regular_hud_updates() for humans. If it's all working perfectly as it appears to be I'll start doing the same for other mobs. Whomever started 'fixing' this and then just abandoned it with redundant and heavily-broken code should be ashamed :[ It was/is in a real sorry state.

Resolves issue 617. Shades can no longer be weakened (stunbatons etc).

Fixed an issue with one of the antag deaf-sting/rune/whatever-it-was-I-forget causing nearsightedness rather than deafness :P


git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3985 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-05 07:44:18 +00:00
elly1989@rocketmail.com
86effe3429 ghosts now have stat=DEAD so certain verbs don't break.
replaced canweaken and canstun variables with status_flags bitfield. Current flags are CANWEAKEN CANSTUN CANPARALYSE. Although you could add stuff like CANDAMAGE, CANBLIND, CANDEAFEN etc. to add additional flexibility to mob code and reduce on duplication.

Added humans_need_surnames as a config option. If when spawning  a human has only one name it will give them a random surname. I'd recommend leaving it on so that people can't name themselves "floor" "Unknown" etc.

totally removed autolowercasing of names (except for first letter) due to people pestering me. inb4 everyone starts CRUISECONTROLLING.

allowed a few characters like @ # etc for when the flag allow_numbers is set. So AIs can use those symbols (numbers and symbols cannot be used as the first character because of syntax.

Added alium nests. They're basically beds that only aliums can use. They are made of sticky resin which aliums secure their prey too for sexytimes.

Weed nodes are no longer dense.

Tidied up some alium verbs so that they are more structured. This will allow me to add Alt-Click neurotoxin shooting for queens and sentinels

Queens can secrete resin now to build nests/walls/membranes (doors to come!)
Drones that evolve into queens when there is already a live Queen will become princesses instead so the hive can tell them how stupid they are for splitting from the will of the hive. It also gives them a number so they can be differentiated between.

Credits to 39kk9t for fixing larva/death.dm, hissing which I forgot to do and some of the alium verbs. You're awesome <3

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3983 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-04 20:53:13 +00:00
johnsonmt88@gmail.com
188b487542 AI's are no longer permanently blinded by power loss. Fixes issue 603
- Thanks to Zekkeit/39kk9t for this fix!

Cultists now get stunned by their own stun rune again.
- Apparently this would have been game-breakingly spammable

Added WJohnston's mech toys as arcade prizes!

Made mech tool code less of a nightmare to navigate:
- Moved mech medical tools into their own .dm file
- Moved unused mech tools into their own .dm file

Fixed a major pAI exploit.

Fixed the odysseus picking up people who were buckled, causing the person to be unable to move.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3982 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-04 19:52:45 +00:00
johnsonmt88@gmail.com
f037a0b074 Clown clumsiness no longer applies to laser-tag guns.
The stun rune:
- Now stuns cyborgs.
- No longer stuns cultists.

Stun talismans no longer permanently mute or stun cyborgs. Fixes issue 618.

Removed 'charges', 'maximum_charges' and 'status' variables from the chain of command as they did nothing anyway.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3979 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 21:52:02 +00:00
ericgfwong@hotmail.com
88a9e130fd -Fixed Kitchen Maintenance door using the wrong access
-Moved antitoxin bottles to the top in Medicine closets

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3978 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 19:02:27 +00:00
johnsonmt88@gmail.com
f9986387c3 Second part of moving simple_animals.
TortoiseSVN was barking at me, so I had to do it like this.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3977 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 17:22:46 +00:00
johnsonmt88@gmail.com
bb901f7583 Mob define cleanup: Part 2
Moved the simple_animal folder into /mob/living.
- Thanks to tortoiseSVN issues, I will have to remove the old simple_animal folder in a second commit.

Moved to living:
- maxHealth
- health
- control_object
- incorporeal_move

Moved to carbon:
- silent
- alien_egg_flag

Moved to human: (human_defines.dm)
- All vars that used to be defined in human.dm
- underwear
- backbag
- miming

Deleted from mob:
- r_epil	//Old var, not used anymore
- r_ch_cou	//Old var, not used anymore
- r_Tourette	//Old var, not used anymore
- spellvoice() 	//Old proc, not used anymore
- get_damage()	//Unused, we have getHealth() that does the same thing

Removed some unticked files that have already been replaced.

This also fixes cyborgs being 'knocked unconscious' by rolling pins and secure breifcases
- Additionally; to knock someone out with a rolling pin you must now be targeting the victims head.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3976 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 17:14:49 +00:00
ericgfwong@hotmail.com
4d72ac303f -Added deliverable disposals to genetics
-Added medical cartridge to geneticist PDAs

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3975 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 04:36:13 +00:00
ericgfwong@hotmail.com
c7a784cf00 Oh god I'm terrible at this. Sorry.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3974 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 03:10:21 +00:00
ericgfwong@hotmail.com
cbe3e71410 -Added a couple of grey softcaps to the map
-Fixed grey softcaps having the wrong name

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3973 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 03:06:15 +00:00
ericgfwong@hotmail.com
9e8f39683f -Softcaps can now be dyed in washing machines. Thanks to Intigracy for the sprite work
-Merged cargo maintenance /area/ into mining dock (It was so small and pointless)
-A few aesthetic changes to the map

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3972 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-03 02:20:42 +00:00
baloh.matevz
30348f24c4 - Added a confirmation message for the 'sleep' verb
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3971 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-02 20:26:16 +00:00
d_h2005@yahoo.com
507aeac51e Fixing some derps:
-Cocoa pods no longer turn invisible at a certain point.
-Changed some dumb descriptions.
-Fixed larvae UI positioning
-Further adjusted capsaicin/frost oil. Cold is already lethal to metroids, so the extra damage stuff was redundant.
-Fix for somatoray runtimes when shot at metroids and xenos and stuff.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3970 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-02 20:20:13 +00:00
kortgstation@gmail.com
ac9762228e Fix for my commit regarding simple animals and turrets. Pete is a hero, etc
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3969 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-02 20:11:20 +00:00
quartz235@gmail.com
ecd057f10d Fixes Issue 502
- Absorbing someone with the same real_name as a prior victim now properly adds to your genome count for end-round report
 - Done via new changeling datum var (ugh) called absorbcount that is just a number that increases on any successful absorb (also increases properly in the event of absorbing another changeling,) couldn't see a better way about this without overhauling the entire changeling datum layout, objective checks, etc.

Removed direct narrate (not global) rank check, since everyone gets subtlemessage and the like it didn't make sense to restrict this

Readded timestamps on fingerprints_hidden which I guess were removed during a revert?

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3968 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-02 11:09:02 +00:00
kortgstation@gmail.com
5c471a68f5 The cult blade now stuns/damages non-cultists who pick it up.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3967 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-02 07:15:47 +00:00
ericgfwong@hotmail.com
46f6579528 -Added missing RCs in kitchen and hydroponics
-Excluded a few hairstyles from female random appearance

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3966 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-02 06:50:13 +00:00
elly1989@rocketmail.com
0db2c72ebe removed html from the VarEdit logging stuff ebcause it's reaaaaaaally annoying :P
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3965 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-02 00:03:28 +00:00
kortgstation@gmail.com
51d0fbc3ce Simple animals (wraiths, juggernauts, etc) can now be targeted by turrets. They can also destroy turrets
Simple animals can now smash lights.

Simple animals use their attack value vs grilles now, I'm not sure why they didn't before. This means juggernauts should smash them quickly, and artificers much more slowly.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3964 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-01 23:37:54 +00:00
elly1989@rocketmail.com
47bb6e7588 Relaxed the enforced lowercasing of characters in names to allow stuff like MacTavish as per request.
Relaxed forced uppercasing following numbers for AIs

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3963 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-01 23:28:49 +00:00
polyxenitopalidou@gmail.com
eac2093f02 •Mein datumvars will be perfect.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3960 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-01 20:50:26 +00:00
elly1989@rocketmail.com
20a799bc28 Similar naming restrictions applied to AIs. However numbers are allowed and only a minimum of one word is required for the name.
Names with he word "cyborg" in are rejected.
Fixed the "Invalid name" help message.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3958 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-01 02:53:55 +00:00
elly1989@rocketmail.com
6594f7098e Actually, tweak to previous commit to prevent preceding and trailing spaces counting as a second word
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3957 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-01 01:07:13 +00:00
elly1989@rocketmail.com
2a775f9d1f Added some restrictions to round-start names for humans. this was necessary due to people using meta names like "floor" "unknown" "lol" etc.
If you feel the restrictions are to strict please let me know here or on the feedback forums.

Generally only A-Z, a-z, space, . - ' are allowed.
Names should be 2 words at least.
Names with too many space, . - ' are rejected.
Names are auto-capitalised.
Names with not enough regular alpha-numeric characters are rejected.
Names with bad characters such as \ etc are rejected.

Raised the minimum character age at the request of a few people. It's now the minimum age for enlisting in the army for most countries (17)

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3956 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-01 00:53:52 +00:00
petethegoat@gmail.com
bbf978d3cd Two tiny fixes, before I forget.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3955 316c924e-a436-60f5-8080-3fe189b3f50e
2012-07-01 00:40:10 +00:00
elly1989@rocketmail.com
d82f9b52d4 Fix for issue 610
Cause: objects not being removed from client.screen

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3951 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-30 17:48:05 +00:00
elly1989@rocketmail.com
257f6afdd4 Little name-fix for Pete.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3950 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 23:43:35 +00:00
d_h2005@yahoo.com
42ebbb4202 -Newly adjusted HUD sprites for borgs and xenos, designed for erro's interface!
-Inhands for booze bottles, milk/juice cartons, hot cocoa and tea.
-defines for hot sauce and cold sauce bottles (mostly for my testing)

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3949 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 20:13:40 +00:00
sieve32@gmail.com
3dc8dd8c30 Quick fix for Issue 578, now the conversion code for cult and rev actually checks the implants instead of job (Some jobs are still excluded for whatever reason).
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3948 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 17:15:06 +00:00
petethegoat@gmail.com
7f5de70b91 Reverted r3944, with the exception of stock_parts.dmi
Fixed issue 605.

Committing minor adjustments to watercloset.dm and paperbin.dm too!

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3947 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 15:56:51 +00:00
elly1989@rocketmail.com
feeb0fa395 Runtime fix for resisting out of spacevines. Cleaned it up a bit so escaping being tangled up in vines is a little more intuitive.
You'll either need something to cut them to remove them, or simply 'hit' them to unbuckle somebody tangled up. You can resist to untangle yourself.

Reduced the frequency at which they tangle people by 75%, because it was just frustratingly frequent.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3946 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 14:14:28 +00:00
elly1989@rocketmail.com
85b67461a5 Fix for buckled mobs being moved when bumped (where both parties are using help intent).
Incidentally this also fixes an oooooold pre-existing issue with a few other mobs like corgis. :3

resolves issue 604

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3945 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 12:49:00 +00:00
vageyenaman@gmail.com
9a7675ce5a Implemented Tobba's new lighting system. This grants some infrastructure to allow for colored light sources. It should also, theoretically, but more efficient.
Created a quick variable to let projectiles automatically illuminate.

Implemented some of Ausops' sprites.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3944 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 03:43:30 +00:00
ericgfwong@hotmail.com
3710c741a7 -Moved a couple of items out of medical storage so chemists can grab them
-Added medicine closet to genetics. It contains syringes and a couple of antitoxin bottles
-Removed air scrubber not connected to anything in medbay
-Removed duplicate window in the incinerator
-Added better descs for camera monitors
-Merged Surgery and Sleeper room /area/s

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3943 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 02:06:56 +00:00
elly1989@rocketmail.com
8d5583d65c Fixes Issue 602.
Set AI's canweaken to 0.

If this has any side effects that I am unaware of let me know and I'll look at the problem again.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3942 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-29 00:22:53 +00:00
elly1989@rocketmail.com
a04513648a Fix for forhuggers appearing under hud/inventory slots of aliums.
Well, I say 'fix' I just removed the active-hugger image code. It didn't really add anything worthwhile to them.

Simplified a little snippet of WC code.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3941 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-28 23:46:57 +00:00
elly1989@rocketmail.com
9c407b9516 Adds a type check for put_in_l_hand() and put_in_r_hand() to avoid server crashing runtimes caused by bad code or var editing.
git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3940 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-28 22:06:24 +00:00
elly1989@rocketmail.com
0f34375088 Runtime fix for:
runtime error: Cannot read null.reagent_list
proc name: Point To (/atom/verb/point)
  source file: cellautomata.dm,176
  usr: Zinedine Zidane (/mob/living/simple_animal/corgi)
  src: null
  call stack:
Point To()

Cause:
corgi/
    var/reagents = null

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3939 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-28 21:22:06 +00:00
elly1989@rocketmail.com
f1e66b05a9 Using ViewVars logs to the runtime log now. This is so it's easier for coders to tell which runtimes were caused by admins rather than normal gameplay.
Decided to add this after one of our admins put a human inside a toilet cistern causing untold mayhem in the runtime log :P

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3938 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-28 20:46:36 +00:00
petethegoat@gmail.com
a2c5a0f15b Committing work on mirrors, and a capitalisation fix for pizza boxes.
Mirrors aren't on the map yet, but should work fine.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3937 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-28 18:57:32 +00:00
elly1989@rocketmail.com
3941c9b86c Standardised the handle_regular_status_updates() procs for alien hunter, queen and sentinel. They were just copypasta so I fixed the updatehealth() procs and removed the unneeded code.
Removed the invisibility verb for hunters. They now cloak when using stalk intent instead. :3 rawr

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3935 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-28 17:37:42 +00:00
johnsonmt88@gmail.com
80b15df54b ** Mob Define Cleanup: Part 1 **
I'm currently working on moving all of the vars in mob_defines.dm and some procs in mob.dm into more fitting places. For example, ghosts and simple animals can not be cloned, so they do not need a cloneloss var. Cloneloss would be better fitting to /mob/living or even /mob/living/carbon. 

By moving these defines into proper children of /mob we lower the amount of resources that must be set aside every time a mob is created and we lower the amount of data that gets transfered between mobs when we combine, transfer or transform them. In theory, this should help free up some resources and combat lag.

Due to how integrated some of these defines are in the rest of the code, I'm going to be committing this cleanup in small batches. Doing it this way instead of one massive commit means that bugs will be easier to locate and identify. It is also less likely to overwhelm players with bugs, and if it still does, it will make it easier for us to revert only the section that is causing problems. Smaller commits also means merging with existing code will be less of a nightmare and has less potential for merging mistakes.

One of my goals in this cleanup is to add a description to every single variable in mob defines. While some of them are self explanatory, there are some there that are used in horribly obscure ways on top of having no comment to describe their use.

-----------------------

Mob defines moved to living:
- last_special*
- bruteloss
- oxyloss
- toxloss
- fireloss
- cloneloss
- brainloss
- halloss
- hallucination
- hallucinations(list)

*Note: I believe this variable is not needed, but the code it is used in (the resist verb) is cluttered and messy. That chunk of code probably use a re-write. I'll put it on my TODO list and if I survive mob_defines I'll try to get around to it but if anyone wants to do it for me, that would certainly help!

-----------------------

Mob procs moved to living:
- getBruteLoss()
- adjustBruteLoss()
- getOxyLoss()
- adjustOxyLoss()
- setOxyLoss()
- getToxLoss()
- adjustToxLoss()
- setToxLoss()
- getFireLoss()
- adjustFireLoss()
- getCloneLoss()
- adjustCloneLoss()
- setCloneLoss()
- getHalLoss()
- adjustHalLoss()
- setHalLoss()
- getBrainLoss()
- adjustBrainLoss()
- setBrainLoss

Mob procs moved to carbon:
getDNA()
setDNA()

-----------------------

Mob verbs moved to carbon:
- Sleep
- Lay down / Get up

-----------------------

The : operator...

The thing that has been killing me through this whole cleanup is people using or copy/pasting the : operator everywhere. 


*** Please use obj.var_or_procname. Do not use obj:var_or_procname ***


Using obj:procname will not throw a compiler error if obj does not have that specific var or proc. This means that the coder making changes will NOT be informed of an error which will result in a proc failing, potentially being completely unusable and definatly causing a runtime error.

With that said, I fully anticipate that most bugs (if any) caused by this mob define cleanup to be the result of : operators.

I've been replacing many : operators in favour of the . operator as I've been going, most noteably I went out of my way to remove almost every : operator from the 4000+ line Chemistry-Regents.dm
Exceptions:
- Water: Turf and Atmos related vars. I'm not familiar with the members and methods in those class' hierarchy.
- Silicate: because it's commented out and I honestly dont see it returning.
- Thermite: Turf and Atmos related vars.
- Corn Oil: Turf and Atmos related vars.

Final note: While this may be the source of some mob-related bugs, there are two other revisions that have been committed between now and the last time either of the the two tgstation servers have been updated. These revisions both touch mob-related files. I'm not blaming these other revisions for anything, especially since one of them is mine anyway, I'm just listing them here for refrence to help quickly identify any problems.
- My human/life() changes in r3925 
- Carn's life() standardizations in r3933

Stuff unrelated to mob defines:
- Fixed borgs and such being able to go into DNA modifiers.
- Changelog updated and I added Sieve to the list of coders.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3934 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-28 17:06:19 +00:00
elly1989@rocketmail.com
ea333ff216 Ugh another big 'Carn broke everything' commit.
Tried to standardise the (confusing as all hell) handle_regular_status_updates() procs for monkeys alien/humanoid, alien/larva, brains and humans.

Removed clamp_values as per Rockdtben's request.

Hopefully this should make those procs a lot easier to read and work with as well as reduce the number of calculations done every call.

Admin's rejuvinate verb cures disabilities, sdisabilities and sight/hearing.

Xenos can actually use their sleeping icon properly now.

If I've broken anything let me know directly and I'll have it fixed/reverted within 24 hours.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@3933 316c924e-a436-60f5-8080-3fe189b3f50e
2012-06-27 19:47:17 +00:00