cyberpresidentvanellope/CHOMPStation2
1
0
Fork 0
mirror of https://github.com/CHOMPStation2/CHOMPStation2.git synced 2025-12-12 03:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
16,014 Commits 10 Branches 0 Tags
8e1b286a846ce64d67b3662fc43bbcc2f33de78c
Commit Graph

11923 Commits

Author SHA1 Message Date
Loganbacca
8e1b286a84 Mining drill text 
- Adds drill_verb variables to pickaxe subtypes, so drills will now be described as "drilling" instead of "picking"
 2014-02-28 12:15:41 +13:00
Loganbacca
fbfdccebaf Suit sensor toggle 
- Changes the suit sensor toggle verb to select from a list, instead of cycling through one mode at a time.
 2014-02-28 12:15:26 +13:00
Mloc-Argent
f5ab084eac Fixes admin attack logs to show up in-game as well as in the logfiles. 
Signed-off-by: Mloc-Argent <colmohici@gmail.com>
 2014-02-25 20:36:46 +00:00
Ccomp5950
3ab7e8438a Runtime fix: Sparks trying to delete that which does not exist. 
runtime error: Cannot execute null.delete().
proc name: start (/datum/effect/effect/system/spark_spread/start)
  source file: effect_system.dm,204
  usr: Mark Hoover (/mob/living/carbon/human)
  src: /datum/effect/effect/system/sp... (/datum/effect/effect/system/spark_spread)
  call stack:
/datum/effect/effect/system/sp... (/datum/effect/effect/system/spark_spread): start()
runtime error: Cannot execute null.delete().
proc name: start (/datum/effect/effect/system/spark_spread/start)
  source file: effect_system.dm,204
  usr: Mark Hoover (/mob/living/carbon/human)
  src: /datum/effect/effect/system/sp... (/datum/effect/effect/system/spark_spread)
  call stack:
/datum/effect/effect/system/sp... (/datum/effect/effect/system/spark_spread): start()
 2014-02-25 00:28:00 -06:00
Ccomp5950
ceb220f705 Runtime fix: OH GOD NOT THE BEEs WON'T SOMEONE CALM THEM DOWN? 
Other then NULL?

runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
runtime error: Cannot read null.type
proc name: Life (/mob/living/simple_animal/bee/Life)
  source file: bees.dm,91
 2014-02-25 00:21:41 -06:00
Ccomp5950
e098746209 Runtime fix: RP_Revolution's auto_add_rev_head loves that null. 
runtime error: Cannot read null.client
proc name: process (/datum/game_mode/revolution/rp_revolution/process)
  source file: rp_revolution.dm,198
runtime error: Cannot read null.client
proc name: process (/datum/game_mode/revolution/rp_revolution/process)
  source file: rp_revolution.dm,198
runtime error: Cannot read null.client
proc name: process (/datum/game_mode/revolution/rp_revolution/process)
  source file: rp_revolution.dm,198
runtime error: Cannot read null.client
proc name: process (/datum/game_mode/revolution/rp_revolution/process)
  source file: rp_revolution.dm,198
runtime error: Cannot read null.client
proc name: process (/datum/game_mode/revolution/rp_revolution/process)
  source file: rp_revolution.dm,198
runtime error: Cannot read null.client
proc name: process (/datum/game_mode/revolution/rp_revolution/process)
  source file: rp_revolution.dm,198
 2014-02-25 00:20:44 -06:00
Chinsky
0ba65efd18 Merge pull request #4477 from Ccomp5950/runtimefixes 
Runtimefixes
 2014-02-25 06:01:59 +04:00
Ccomp5950
23faf801ae Merge pull request #4468 from Segrain/master 
Bugfixes.
 2014-02-24 18:59:54 -06:00
Segrain
bd5585052c Fix for #4479. 2014-02-25 03:33:18 +03:00
Mloc
fa2061a249 Fix for ban queries. 2014-02-25 00:11:07 +00:00
Ccomp5950
0f538a9b2f Typo fix. 
Screw typechecks and their need for closing parens :*(
 2014-02-24 01:50:44 -06:00
Ccomp5950
f071421552 Runtime fix: Null isn't really that sharp. 
runtime error: Cannot read null.sharp
proc name: is sharp (/proc/is_sharp)
  source file: unsorted.dm,1270
  usr: Arthur Ward (/mob/living/carbon/human)
  src: null
  call stack:
is sharp(null)
the police tape (/obj/item/tape/police): breaktape(null, Arthur Ward (/mob/living/carbon/human))
the police tape (/obj/item/tape/police): attack hand(Arthur Ward (/mob/living/carbon/human))
Arthur Ward (/mob/living/carbon/human): UnarmedAttack(the police tape (/obj/item/tape/police), 1)
Arthur Ward (/mob/living/carbon/human): ClickOn(the police tape (/obj/item/tape/police), "icon-x=16;icon-y=10;left=1;scr...")
the police tape (/obj/item/tape/police): Click(the floor (172,128,1) (/turf/simulated/floor), "mapwindow.map", "icon-x=16;icon-y=10;left=1;scr...")
 2014-02-24 01:39:25 -06:00
Ccomp5950
3d88998123 Runtime fix: usr = 0??? 
runtime error: Cannot read 0.item_use_icon
proc name: remove gun icons (/client/proc/remove_gun_icons)
  source file: targeting.dm,273
  usr: 0
  src: Vivalas (/client)
  call stack:
Vivalas (/client): remove gun icons()
the taser gun (/obj/item/weapon/gun/energy/taser): dropped(Jonathon Sommer (/mob/living/carbon/human))
Jonathon Sommer (/mob/living/carbon/human): drop r hand(null)
Jonathon Sommer (/mob/living/carbon/human): update canmove()
Jonathon Sommer (/mob/living/carbon/human): Weaken(5)
Jonathon Sommer (/mob/living/carbon/human): Weaken(5)
Jonathon Sommer (/mob/living/carbon/human): apply effect(5, "weaken", 0)
Jonathon Sommer (/mob/living/carbon/human): apply effects(0, 5, 0, 0, 0, 0, 0, 0, 0)
 2014-02-24 01:35:04 -06:00
Ccomp5950
d5951781fd Runtime fix: Alarms keep trying to heat up space. 
runtime error: Cannot execute null.heat capacity().
proc name: process (/obj/machinery/alarm/process)
  source file: alarm.dm,186
runtime error: Cannot execute null.heat capacity().
proc name: process (/obj/machinery/alarm/process)
  source file: alarm.dm,186

over and over and over.
 2014-02-24 01:27:04 -06:00
Ccomp5950
75116bfd53 Runtime fix: Someone using a gas mask with no tank...IN SPACE 
runtime error: Cannot read null.oxygen
proc name: copy from (/datum/gas_mixture/proc/copy_from)
  source file: FEA_gas_mixture.dm,480
  usr: null
  src: /datum/gas_mixture (/datum/gas_mixture)
  call stack:
/datum/gas_mixture (/datum/gas_mixture): copy from(null)
Basileus (/mob/living/carbon/human): breathe()
Basileus (/mob/living/carbon/human): Life()
/datum/controller/game_control... (/datum/controller/game_controller): process mobs()
/datum/controller/game_control... (/datum/controller/game_controller): process()
runtime error: Cannot read null.toxins
proc name: breathe (/mob/living/carbon/human/proc/breathe)
  source file: life.dm,339
  usr: null
  src: Basileus (/mob/living/carbon/human)
  call stack:
Basileus (/mob/living/carbon/human): breathe()
Basileus (/mob/living/carbon/human): Life()
/datum/controller/game_control... (/datum/controller/game_controller): process mobs()
/datum/controller/game_control... (/datum/controller/game_controller): process()
 2014-02-24 01:16:19 -06:00
Ccomp5950
0bcd89360a Runtime fix: I have no UI, and I must close it. 
runtime error: Cannot execute null.close().
proc name: Topic (/obj/item/device/pda/Topic)
  source file: PDA.dm,485
  usr: Garry Myers (/mob/living/carbon/human)
  src: PDA-Garry Myers (Station Engin... (/obj/item/device/pda/engineering)
  call stack:
PDA-Garry Myers (Station Engin... (/obj/item/device/pda/engineering): Topic("src=\[0x2003e95];choice=Messag...", /list (/list))
NeroHarry (/client): Topic("src=\[0x2003e95];choice=Messag...", /list (/list), PDA-Garry Myers (Station Engin... (/obj/item/device/pda/engineering))
NeroHarry (/client): Topic("src=\[0x2003e95];choice=Messag...", /list (/list), PDA-Garry Myers (Station Engin... (/obj/item/device/pda/engineering))
 2014-02-24 00:51:57 -06:00
Ccomp5950
1eb66f1f78 Runtime fix blood_DNA length checks when it's possibly null. 
runtime error: Cannot read null.len
proc name: attack self (/obj/item/weapon/melee/telebaton/attack_self)
  source file: swords_axes_etc.dm,156
 2014-02-24 00:47:55 -06:00
Ccomp5950
cea151813e Runtime fix: Dirt in SPAAAAACCEEEEEEE 
ndefined variable /turf/space/var/dirt
proc name: reaction turf (/datum/reagent/space_cleaner/reaction_turf)
source file: Chemistry-Reagents.dm,939
 2014-02-24 00:44:00 -06:00
Mloc
faa1dd38ba Merge pull request #4473 from Ccomp5950/dev_power 
DEV EMPOWERMENT  Gives people with R_DEBUG access to runtimelogs.
 2014-02-23 15:03:02 +00:00
Ccomp5950
e72c584ac8 Reapplys this runtime fix when dead /mob/living would not have a client. 2014-02-22 03:47:46 -06:00
Ccomp5950
8ef2e10237 This reverts commit all the say code changes over the last couple of days. 
Except for the removal of the redundant get_mobs_in_view used for bolding ghosts text.
 2014-02-22 03:46:10 -06:00
Ccomp5950
92e0c60126 Remove clients removal derp. 2014-02-22 02:50:49 -06:00
Ccomp5950
d95caffecb DEV EMPOWERMENT Gives people with R_DEBUG access to runtimelogs. 
Also moves make_everyone_random to R_FUN where it belongs, gets rid of that dumb panel from my awesome dev screen.
 2014-02-22 01:45:43 -06:00
Segrain
86c73e242b Fix for embedding. 2014-02-22 10:16:55 +03:00
Segrain
05c82c970b Tiny fix. 2014-02-22 06:56:51 +03:00
Segrain
2b9842c113 Smallfix. 2014-02-22 06:56:12 +03:00
Segrain
fd738a5767 Smallfix. 2014-02-22 06:54:48 +03:00
Segrain
b04d00ff7b Typo fix. 2014-02-22 06:54:11 +03:00
Segrain
ef3b565f64 Fix for #4458. 2014-02-22 06:53:37 +03:00
Segrain
c6d39deac0 Fix for #4445. 2014-02-22 06:49:57 +03:00
Ccomp5950
6dc330a398 Bugfix: get_mobs_in_view won't allow AIeyes to hear chat. 
Also:  Added a client check to saycode for now that stops runtimes when you have a dead body with no client and removed colons from it.
herp derp.
 2014-02-21 21:29:34 -06:00
Ccomp5950
440f784c70 Bugfix: People unable to hear while in certain locations. (And some debug verbs) 
...hopefully
 2014-02-21 02:11:11 -06:00
Chinsky
fac3b8c580 Merge pull request #4460 from Ccomp5950/FUCK_recursive_mob_check 
Compile fix / optimizations
 2014-02-19 16:49:54 +04:00
Ccomp5950
04a0537b1f Compile fix / optimizations 
Removed client check from mob so that if a pAI is being held by a SSD client it can still hear.

Removed 3rd deep .loc check 2 is plenty, and was making the proc rather expensive
(if you shove a pAI in a bag and toss the bag into a locker, the pAI will be deaf, you jerk).
 2014-02-19 00:12:14 -06:00
Ccomp5950
0ec00981f8 Unintended feature/bug. 
Players viewing through security cameras can hear, this is a bit to powerful.

So removing, it's easy to readd the feature later on.
 2014-02-18 20:00:16 -06:00
Chinsky
0080e1f293 Merge pull request #4459 from Ccomp5950/FUCK_recursive_mob_check 
Unintended feature/bug.
 2014-02-19 06:00:01 +04:00
Chinsky
225b195934 Merge pull request #4454 from Loganbacca/bayfix 
Various fixes
 2014-02-19 04:25:17 +04:00
Chinsky
2810cfc3cf Merge pull request #4457 from Ccomp5950/FUCK_recursive_mob_check 
Code effeciency project: /proc/get_mobs_in_view - hot
 2014-02-19 04:24:31 +04:00
Chinsky
3052a3bde7 Merge pull request #4451 from JoeyJo0/master 
Fixed #4439 and a small issue in the TCommSat
 2014-02-19 04:22:55 +04:00
Loganbacca
ec3ae41708 Mech fab upgrade fix 
Nano manipulators were not lowering build time at all.
Stock and Pico manipulaors were lowering build time by 6%.

This fixes that. Now: Stock = standard build time, Nano = 6% faster, Pico = 12% faster.
 2014-02-19 12:49:27 +13:00
Ccomp5950
af19351608 Further optimizations, no need to loop through items with multiple istype checks 2014-02-18 06:51:45 -06:00
Ccomp5950
d29a7fb260 pAI / MMI emote fixes. 
Fixes #4191
 2014-02-18 06:47:06 -06:00
Ccomp5950
5909abb080 This is rather ironic... 
My VERY FIRST PR, I used it to make ghost chat be bold, instead of using viewers() to figure out
what ghosts could see the mob, I used get_mob_in_view() which sounded pretty descriptive.

Unfortunately for me it was one of the most CPU intensive ways of determining who could view the speaker for this.

So yeah, removing the second get_mobs_in_view and replacing it with viewers()

Yes this code has been in since Oct/Nov time frame :(
 2014-02-18 05:40:06 -06:00
Ccomp5950
4e09cf33ac Code effeciency project: /proc/get_mobs_in_view 
Before:  Everytime you say something. This proc is ran.  Along with it, recurses through EVERY /obj/ & /mob/ in view's contents, and EVERY /obj/ & /mob/ in that contents...and once again.

After:  Fuck recursion, we're going to loop through clients and see if they are within any obj's or mobs within one iteration.  MUCH cheaper, and probably less buggy.

If someone can't hear everyone and they are within an object and it's not catching?  add it to the list commented for it of type checks.
 2014-02-18 02:11:59 -06:00
Loganbacca
42946bd2ad Vent pump efficiency 
- Tweaked the pressure delta check to "> 0.5", so pumps will stop transferring minor volumes of air every tick (because a delta of 3.05176e-005 is still greater than 0). This also reduces the calls to gas_mixture/merge() and gas_mixture/remove() significantly once the air in the environment has equalized.

The results after running the game for 10 minutes:
```
Proc Name												Self CPU	Total CPU	Real Time	Calls
/obj/machinery/atmospherics/unary/vent_pump/process		0.035		0.141		0.141		3808	<- before
/obj/machinery/atmospherics/unary/vent_pump/process		0.014		0.042		0.043		3808	<- after
```
 2014-02-18 16:16:10 +13:00
Loganbacca
b8b1bd82a4 Wardrobe fix 
Fixes #4447

- Added a parent call to each wardrobe subtypes New() proc.
Wardrobes weren't calling obj/structure/closet/New(), so weren't adding items in the same location to their contents when first created.

- Removed wardrobe/New() proc.
So all subtypes don't inherit an extra set of blue uniforms and brown shoes. Only one wardrobe on the map is of this type, and it's on the derelict, so didn't think it was worth making a map change.
 2014-02-18 11:12:27 +13:00
Mloc
eb593a628f Merge pull request #4449 from Ccomp5950/apc_icon_fix 
Code effeciency project: apc update_icons
 2014-02-17 15:55:29 +00:00
Mloc
242aae0f97 Merge pull request #4450 from Ccomp5950/dna2-everyone_human_fix 
DNA2 fix.
 2014-02-17 15:55:07 +00:00
Chinsky
79683c5206 Merge pull request #4448 from Segrain/master 
Smallfix.
 2014-02-17 03:28:43 +04:00
Joey Haas
296e839f03 Fixed issue #4439 (Detomax ignores status of messaging server) 2014-02-17 00:18:28 +01:00