mirror of
https://github.com/CHOMPStation2/CHOMPStation2.git
synced 2025-12-10 18:22:39 +00:00
Fixes the pressure regulator's reported flow rate not being set to 0 when no gas could be transferred.
268 lines
8.6 KiB
Plaintext
268 lines
8.6 KiB
Plaintext
#define REGULATE_NONE 0
|
|
#define REGULATE_INPUT 1 //shuts off when input side is below the target pressure
|
|
#define REGULATE_OUTPUT 2 //shuts off when output side is above the target pressure
|
|
|
|
#undefine
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate
|
|
icon = 'icons/atmos/passive_gate.dmi'
|
|
icon_state = "map"
|
|
level = 1
|
|
|
|
name = "pressure regulator"
|
|
desc = "A one-way air valve that can be used to regulate input or output pressure, and flow rate. Does not require power."
|
|
|
|
use_power = 0
|
|
|
|
var/on = 0 //doesn't actually use power. this is just whether the valve is open or not
|
|
var/target_pressure = ONE_ATMOSPHERE
|
|
var/max_pressure_setting = 15000 //kPa
|
|
var/set_flow_rate = ATMOS_DEFAULT_VOLUME_PUMP * 2.5
|
|
var/regulate_mode = REGULATE_OUTPUT
|
|
|
|
var/flowing = 0 //for icons - becomes zero if the valve closes itself due to regulation mode
|
|
|
|
var/frequency = 0
|
|
var/id = null
|
|
var/datum/radio_frequency/radio_connection
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/New()
|
|
..()
|
|
air1.volume = ATMOS_DEFAULT_VOLUME_PUMP * 2.5
|
|
air2.volume = ATMOS_DEFAULT_VOLUME_PUMP * 2.5
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/update_icon()
|
|
icon_state = (on && flowing)? "on" : "off"
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/update_underlays()
|
|
if(..())
|
|
underlays.Cut()
|
|
var/turf/T = get_turf(src)
|
|
if(!istype(T))
|
|
return
|
|
add_underlay(T, node1, turn(dir, 180))
|
|
add_underlay(T, node2, dir)
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/hide(var/i)
|
|
update_underlays()
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/process()
|
|
..()
|
|
if(!on)
|
|
last_flow_rate = 0
|
|
return 0
|
|
|
|
var/output_starting_pressure = air2.return_pressure()
|
|
var/input_starting_pressure = air1.return_pressure()
|
|
|
|
var/pressure_delta
|
|
switch (regulate_mode)
|
|
if (REGULATE_INPUT)
|
|
pressure_delta = input_starting_pressure - target_pressure
|
|
if (REGULATE_OUTPUT)
|
|
pressure_delta = target_pressure - output_starting_pressure
|
|
|
|
//-1 if pump_gas() did not move any gas, >= 0 otherwise
|
|
var/returnval = -1
|
|
if((regulate_mode == REGULATE_NONE || pressure_delta > 0.01) && (air1.temperature > 0 || air2.temperature > 0)) //since it's basically a valve, it makes sense to check both temperatures
|
|
flowing = 1
|
|
|
|
//flow rate limit
|
|
var/transfer_moles = (set_flow_rate/air1.volume)*air1.total_moles
|
|
|
|
//Figure out how much gas to transfer to meet the target pressure.
|
|
switch (regulate_mode)
|
|
if (REGULATE_INPUT)
|
|
var/air_temperature = (air1.temperature > 0)? air1.temperature : air2.temperature
|
|
var/input_volume = air1.volume + (network1? network1.volume : 0)
|
|
transfer_moles = min(transfer_moles, pressure_delta*input_volume/(air_temperature * R_IDEAL_GAS_EQUATION))
|
|
if (REGULATE_OUTPUT)
|
|
var/air_temperature = (air2.temperature > 0)? air2.temperature : air1.temperature
|
|
var/output_volume = air2.volume + (network2? network2.volume : 0)
|
|
|
|
transfer_moles = min(transfer_moles, pressure_delta*output_volume/(air_temperature * R_IDEAL_GAS_EQUATION))
|
|
|
|
//pump_gas() will return a negative number if no flow occurred
|
|
returnval = pump_gas(src, air1, air2, transfer_moles, available_power=0) //available_power=0 means we only move gas if it would flow naturally
|
|
|
|
if (returnval < 0)
|
|
flowing = 0
|
|
last_flow_rate = 0
|
|
else
|
|
if(network1)
|
|
network1.update = 1
|
|
|
|
if(network2)
|
|
network2.update = 1
|
|
|
|
if (!last_flow_rate)
|
|
flowing = 0
|
|
|
|
update_icon()
|
|
|
|
|
|
//Radio remote control
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/proc/set_frequency(new_frequency)
|
|
radio_controller.remove_object(src, frequency)
|
|
frequency = new_frequency
|
|
if(frequency)
|
|
radio_connection = radio_controller.add_object(src, frequency, filter = RADIO_ATMOSIA)
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/proc/broadcast_status()
|
|
if(!radio_connection)
|
|
return 0
|
|
|
|
var/datum/signal/signal = new
|
|
signal.transmission_method = 1 //radio signal
|
|
signal.source = src
|
|
|
|
signal.data = list(
|
|
"tag" = id,
|
|
"device" = "AGP",
|
|
"power" = on,
|
|
"target_output" = target_pressure,
|
|
"regulate_mode" = regulate_mode,
|
|
"set_flow_rate" = set_flow_rate,
|
|
"sigtype" = "status"
|
|
)
|
|
|
|
radio_connection.post_signal(src, signal, filter = RADIO_ATMOSIA)
|
|
|
|
return 1
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/initialize()
|
|
..()
|
|
if(frequency)
|
|
set_frequency(frequency)
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/receive_signal(datum/signal/signal)
|
|
if(!signal.data["tag"] || (signal.data["tag"] != id) || (signal.data["sigtype"]!="command"))
|
|
return 0
|
|
|
|
if("power" in signal.data)
|
|
on = text2num(signal.data["power"])
|
|
|
|
if("power_toggle" in signal.data)
|
|
on = !on
|
|
|
|
if("set_target_pressure" in signal.data)
|
|
target_pressure = between(
|
|
0,
|
|
text2num(signal.data["set_target_pressure"]),
|
|
max_pressure_setting
|
|
)
|
|
|
|
if("set_regulate_mode" in signal.data)
|
|
regulate_mode = text2num(signal.data["set_regulate_mode"])
|
|
|
|
if("set_flow_rate" in signal.data)
|
|
regulate_mode = text2num(signal.data["set_flow_rate"])
|
|
|
|
if("status" in signal.data)
|
|
spawn(2)
|
|
broadcast_status()
|
|
return //do not update_icon
|
|
|
|
spawn(2)
|
|
broadcast_status()
|
|
update_icon()
|
|
return
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/attack_hand(user as mob)
|
|
if(..())
|
|
return
|
|
src.add_fingerprint(usr)
|
|
if(!src.allowed(user))
|
|
user << "\red Access denied."
|
|
return
|
|
usr.set_machine(src)
|
|
ui_interact(user)
|
|
return
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/ui_interact(mob/user, ui_key = "main", var/datum/nanoui/ui = null, var/force_open = 1)
|
|
if(stat & (BROKEN|NOPOWER))
|
|
return
|
|
|
|
// this is the data which will be sent to the ui
|
|
var/data[0]
|
|
|
|
data = list(
|
|
"on" = on,
|
|
"pressure_set" = round(target_pressure*100), //Nano UI can't handle rounded non-integers, apparently.
|
|
"max_pressure" = max_pressure_setting,
|
|
"input_pressure" = round(air1.return_pressure()*100),
|
|
"output_pressure" = round(air2.return_pressure()*100),
|
|
"regulate_mode" = regulate_mode,
|
|
"set_flow_rate" = round(set_flow_rate*10),
|
|
"last_flow_rate" = round(last_flow_rate*10),
|
|
)
|
|
|
|
// update the ui if it exists, returns null if no ui is passed/found
|
|
ui = nanomanager.try_update_ui(user, src, ui_key, ui, data, force_open)
|
|
if (!ui)
|
|
// the ui does not exist, so we'll create a new() one
|
|
// for a list of parameters and their descriptions see the code docs in \code\modules\nano\nanoui.dm
|
|
ui = new(user, src, ui_key, "pressure_regulator.tmpl", name, 470, 370)
|
|
ui.set_initial_data(data) // when the ui is first opened this is the data it will use
|
|
ui.open() // open the new ui window
|
|
ui.set_auto_update(1) // auto update every Master Controller tick
|
|
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/Topic(href,href_list)
|
|
if(..()) return
|
|
|
|
if(href_list["toggle_valve"])
|
|
on = !on
|
|
|
|
if(href_list["regulate_mode"])
|
|
switch(href_list["regulate_mode"])
|
|
if ("off") regulate_mode = REGULATE_NONE
|
|
if ("input") regulate_mode = REGULATE_INPUT
|
|
if ("output") regulate_mode = REGULATE_OUTPUT
|
|
|
|
switch(href_list["set_press"])
|
|
if ("min")
|
|
target_pressure = 0
|
|
if ("max")
|
|
target_pressure = max_pressure_setting
|
|
if ("set")
|
|
var/new_pressure = input(usr,"Enter new output pressure (0-[max_pressure_setting]kPa)","Pressure Control",src.target_pressure) as num
|
|
src.target_pressure = between(0, new_pressure, max_pressure_setting)
|
|
|
|
switch(href_list["set_flow_rate"])
|
|
if ("min")
|
|
set_flow_rate = 0
|
|
if ("max")
|
|
set_flow_rate = air1.volume
|
|
if ("set")
|
|
var/new_flow_rate = input(usr,"Enter new flow rate limit (0-[air1.volume]kPa)","Flow Rate Control",src.set_flow_rate) as num
|
|
src.set_flow_rate = between(0, new_flow_rate, air1.volume)
|
|
|
|
usr.set_machine(src) //Is this even needed with NanoUI?
|
|
src.update_icon()
|
|
src.add_fingerprint(usr)
|
|
return
|
|
|
|
/obj/machinery/atmospherics/binary/passive_gate/attackby(var/obj/item/weapon/W as obj, var/mob/user as mob)
|
|
if (!istype(W, /obj/item/weapon/wrench))
|
|
return ..()
|
|
if (on)
|
|
user << "\red You cannot unwrench this [src], turn it off first."
|
|
return 1
|
|
var/datum/gas_mixture/int_air = return_air()
|
|
var/datum/gas_mixture/env_air = loc.return_air()
|
|
if ((int_air.return_pressure()-env_air.return_pressure()) > 2*ONE_ATMOSPHERE)
|
|
user << "\red You cannot unwrench this [src], it too exerted due to internal pressure."
|
|
add_fingerprint(user)
|
|
return 1
|
|
playsound(src.loc, 'sound/items/Ratchet.ogg', 50, 1)
|
|
user << "\blue You begin to unfasten \the [src]..."
|
|
if (do_after(user, 40))
|
|
user.visible_message( \
|
|
"[user] unfastens \the [src].", \
|
|
"\blue You have unfastened \the [src].", \
|
|
"You hear ratchet.")
|
|
new /obj/item/pipe(loc, make_from=src)
|
|
del(src)
|