mirror of
https://github.com/CHOMPStation2/CHOMPStation2.git
synced 2025-12-10 18:22:39 +00:00
776b221828
- Moved pipe construction defines into __defines/construction.dm
- Unified pipe *unwrenching* by creating a standard proc along with the `construction_type` var.
- Eliminated the pipe fitting name & icon_state lookup tables by adding `pipe_state` var on atmos machinery and referencing that.
- Each pipe which can be made from a fitting object should override `pipe_state` with the icon state to be used on the pipe fitting object.
- Eliminated the giant switch statement of doom in pipe construction by delegating that work to `on_construction` proc.
- To make this work, every pipe must implement `get_neighbor_nodes_for_init` which returns a list of nodes which should be re-initialized on that pipe's construction.
- Combined the SCRUBBERS, SUPPLY and REGULAR pipe fitting classes together by storing the `piping_layer` variable and using the `setPipingLayer` procs
- Standardized the code for searching for node neighbors into the `can_be_node` proc.
- This proc is also improved in that is a mutual check, `check_connectable` is called on BOTH objects, so they have to mutually agree to connect as nodes. Eliminates lots of special edge case logic.
- Updated all the `amos_init` procs to use `can_be_node`. In the most common cases, even that boilerplate code is consolidated into the `STANDARD_ATMOS_CHOOSE_NODE` macro.
- Implemented `pipe_flags` which lets pipes declare (or override) certain requirements.
- Adds a "pipe_recipe" datum to help out things that construct pipes. By taking it out of the dispenser, we open the road for multiple dispenser types. No, no RPD yet. Soon.
- Enhances the pipe dispenser to operate on pipe recipe datums instead of hard coded lists of pipes it can construct. These datums are also (partially) initialized from the pipe machine types themselves, reducing having to define stuff in multiple places.
- Switched pipe dispenser UI to use browse(). Not a NanoUI, but makes it a bit prettier with low effort.
- Changed pipe dispenser to use a button selector to switch between Regular/Scrubbers/Supply instead of having separate list items.
- Added icon states to HE pipes to support the "connected on neither side" state.
109 lines
3.7 KiB
Plaintext
109 lines
3.7 KiB
Plaintext
//
|
|
// Universal Pipe Adapter - Designed for connecting scrubbers, normal, and supply pipes together.
|
|
//
|
|
/obj/machinery/atmospherics/pipe/simple/visible/universal
|
|
name="Universal pipe adapter"
|
|
desc = "An adapter for regular, supply and scrubbers pipes"
|
|
connect_types = CONNECT_TYPE_REGULAR|CONNECT_TYPE_SUPPLY|CONNECT_TYPE_SCRUBBER
|
|
icon_state = "map_universal"
|
|
pipe_flags = PIPING_ALL_LAYER|PIPING_CARDINAL_AUTONORMALIZE
|
|
construction_type = /obj/item/pipe/binary
|
|
pipe_state = "universal"
|
|
|
|
/obj/machinery/atmospherics/pipe/simple/visible/universal/update_icon(var/safety = 0)
|
|
if(!check_icon_cache())
|
|
return
|
|
|
|
alpha = 255
|
|
|
|
overlays.Cut()
|
|
overlays += icon_manager.get_atmos_icon("pipe", , pipe_color, "universal")
|
|
underlays.Cut()
|
|
|
|
if (node1)
|
|
universal_underlays(node1)
|
|
if(node2)
|
|
universal_underlays(node2)
|
|
else
|
|
var/node1_dir = get_dir(node1,src)
|
|
universal_underlays(,node1_dir)
|
|
else if (node2)
|
|
universal_underlays(node2)
|
|
else
|
|
universal_underlays(,dir)
|
|
universal_underlays(,turn(dir, -180))
|
|
|
|
/obj/machinery/atmospherics/pipe/simple/visible/universal/update_underlays()
|
|
..()
|
|
update_icon()
|
|
|
|
|
|
|
|
/obj/machinery/atmospherics/pipe/simple/hidden/universal
|
|
name="Universal pipe adapter"
|
|
desc = "An adapter for regular, supply and scrubbers pipes"
|
|
connect_types = CONNECT_TYPE_REGULAR|CONNECT_TYPE_SUPPLY|CONNECT_TYPE_SCRUBBER
|
|
icon_state = "map_universal"
|
|
pipe_flags = PIPING_ALL_LAYER|PIPING_CARDINAL_AUTONORMALIZE
|
|
construction_type = /obj/item/pipe/binary
|
|
pipe_state = "universal"
|
|
|
|
/obj/machinery/atmospherics/pipe/simple/hidden/universal/update_icon(var/safety = 0)
|
|
if(!check_icon_cache())
|
|
return
|
|
|
|
alpha = 255
|
|
|
|
overlays.Cut()
|
|
overlays += icon_manager.get_atmos_icon("pipe", , pipe_color, "universal")
|
|
underlays.Cut()
|
|
|
|
if (node1)
|
|
universal_underlays(node1)
|
|
if(node2)
|
|
universal_underlays(node2)
|
|
else
|
|
var/node2_dir = turn(get_dir(src,node1),-180)
|
|
universal_underlays(,node2_dir)
|
|
else if (node2)
|
|
universal_underlays(node2)
|
|
var/node1_dir = turn(get_dir(src,node2),-180)
|
|
universal_underlays(,node1_dir)
|
|
else
|
|
universal_underlays(,dir)
|
|
universal_underlays(,turn(dir, -180))
|
|
|
|
/obj/machinery/atmospherics/pipe/simple/hidden/universal/update_underlays()
|
|
..()
|
|
update_icon()
|
|
|
|
/obj/machinery/atmospherics/proc/universal_underlays(var/obj/machinery/atmospherics/node, var/direction)
|
|
var/turf/T = loc
|
|
if(node)
|
|
var/node_dir = get_dir(src,node)
|
|
if(node.icon_connect_type == "-supply")
|
|
add_underlay_adapter(T, , node_dir, "")
|
|
add_underlay_adapter(T, node, node_dir, "-supply")
|
|
add_underlay_adapter(T, , node_dir, "-scrubbers")
|
|
else if (node.icon_connect_type == "-scrubbers")
|
|
add_underlay_adapter(T, , node_dir, "")
|
|
add_underlay_adapter(T, , node_dir, "-supply")
|
|
add_underlay_adapter(T, node, node_dir, "-scrubbers")
|
|
else
|
|
add_underlay_adapter(T, node, node_dir, "")
|
|
add_underlay_adapter(T, , node_dir, "-supply")
|
|
add_underlay_adapter(T, , node_dir, "-scrubbers")
|
|
else
|
|
add_underlay_adapter(T, , direction, "-supply")
|
|
add_underlay_adapter(T, , direction, "-scrubbers")
|
|
add_underlay_adapter(T, , direction, "")
|
|
|
|
/obj/machinery/atmospherics/proc/add_underlay_adapter(var/turf/T, var/obj/machinery/atmospherics/node, var/direction, var/icon_connect_type) //modified from add_underlay, does not make exposed underlays
|
|
if(node)
|
|
if(!T.is_plating() && node.level == 1 && istype(node, /obj/machinery/atmospherics/pipe))
|
|
underlays += icon_manager.get_atmos_icon("underlay", direction, color_cache_name(node), "down" + icon_connect_type)
|
|
else
|
|
underlays += icon_manager.get_atmos_icon("underlay", direction, color_cache_name(node), "intact" + icon_connect_type)
|
|
else
|
|
underlays += icon_manager.get_atmos_icon("underlay", direction, color_cache_name(node), "retracted" + icon_connect_type)
|