mirror of
https://github.com/Citadel-Station-13/Citadel-Station-13-RP.git
synced 2026-08-26 05:46:27 +01:00
update filter (#6836)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request filter is now in datum level so you can do it on /images as well <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
This commit is contained in:
@@ -51,6 +51,9 @@
|
||||
*/
|
||||
var/list/cooldowns
|
||||
|
||||
/// List for handling persistent filters.
|
||||
var/list/filter_data
|
||||
|
||||
#ifdef REFERENCE_TRACKING
|
||||
var/running_find_references
|
||||
var/last_find_references = 0
|
||||
@@ -162,6 +165,132 @@
|
||||
SEND_SIGNAL(source, COMSIG_CD_RESET(index), S_TIMER_COOLDOWN_TIMELEFT(source, index))
|
||||
TIMER_COOLDOWN_END(source, index)
|
||||
|
||||
|
||||
//? Filters
|
||||
|
||||
/** Add a filter to the datum.
|
||||
* This is on datum level, despite being most commonly / primarily used on atoms, so that filters can be applied to images / mutable appearances.
|
||||
* Can also be used to assert a filter's existence. I.E. update a filter regardless if it exists or not.
|
||||
*
|
||||
* Arguments:
|
||||
* * name - Filter name
|
||||
* * priority - Priority used when sorting the filter.
|
||||
* * params - Parameters of the filter.
|
||||
*/
|
||||
/datum/proc/add_filter(name, priority, list/params)
|
||||
LAZYINITLIST(filter_data)
|
||||
var/list/copied_parameters = params.Copy()
|
||||
copied_parameters["priority"] = priority
|
||||
filter_data[name] = copied_parameters
|
||||
update_filters()
|
||||
|
||||
///A version of add_filter that takes a list of filters to add rather than being individual, to limit calls to update_filters().
|
||||
/datum/proc/add_filters(list/list/filters)
|
||||
LAZYINITLIST(filter_data)
|
||||
for(var/list/individual_filter as anything in filters)
|
||||
var/list/params = individual_filter["params"]
|
||||
var/list/copied_parameters = params.Copy()
|
||||
copied_parameters["priority"] = individual_filter["priority"]
|
||||
filter_data[individual_filter["name"]] = copied_parameters
|
||||
update_filters()
|
||||
|
||||
/// Reapplies all the filters.
|
||||
/datum/proc/update_filters()
|
||||
ASSERT(isatom(src) || isimage(src))
|
||||
var/atom/atom_cast = src // filters only work with images or atoms.
|
||||
atom_cast.filters = null
|
||||
tim_sort(filter_data, GLOBAL_PROC_REF(cmp_filter_data_priority), TRUE)
|
||||
for(var/filter_raw in filter_data)
|
||||
var/list/data = filter_data[filter_raw]
|
||||
var/list/arguments = data.Copy()
|
||||
arguments -= "priority"
|
||||
atom_cast.filters += filter(arglist(arguments))
|
||||
UNSETEMPTY(filter_data)
|
||||
|
||||
/obj/item/update_filters()
|
||||
. = ..()
|
||||
update_action_buttons()
|
||||
|
||||
/** Update a filter's parameter to the new one. If the filter doesn't exist we won't do anything.
|
||||
*
|
||||
* Arguments:
|
||||
* * name - Filter name
|
||||
* * new_params - New parameters of the filter
|
||||
* * overwrite - TRUE means we replace the parameter list completely. FALSE means we only replace the things on new_params.
|
||||
*/
|
||||
/datum/proc/modify_filter(name, list/new_params, overwrite = FALSE)
|
||||
var/filter = get_filter(name)
|
||||
if(!filter)
|
||||
return
|
||||
if(overwrite)
|
||||
filter_data[name] = new_params
|
||||
else
|
||||
for(var/thing in new_params)
|
||||
filter_data[name][thing] = new_params[thing]
|
||||
update_filters()
|
||||
|
||||
/** Update a filter's parameter and animate this change. If the filter doesn't exist we won't do anything.
|
||||
* Basically a [datum/proc/modify_filter] call but with animations. Unmodified filter parameters are kept.
|
||||
*
|
||||
* Arguments:
|
||||
* * name - Filter name
|
||||
* * new_params - New parameters of the filter
|
||||
* * time - time arg of the BYOND animate() proc.
|
||||
* * easing - easing arg of the BYOND animate() proc.
|
||||
* * loop - loop arg of the BYOND animate() proc.
|
||||
*/
|
||||
/datum/proc/transition_filter(name, list/new_params, time, easing, loop)
|
||||
var/filter = get_filter(name)
|
||||
if(!filter)
|
||||
return
|
||||
// This can get injected by the filter procs, we want to support them so bye byeeeee
|
||||
new_params -= "type"
|
||||
animate(filter, new_params, time = time, easing = easing, loop = loop)
|
||||
modify_filter(name, new_params)
|
||||
|
||||
/// Updates the priority of the passed filter key
|
||||
/datum/proc/change_filter_priority(name, new_priority)
|
||||
if(!filter_data || !filter_data[name])
|
||||
return
|
||||
|
||||
filter_data[name]["priority"] = new_priority
|
||||
update_filters()
|
||||
|
||||
/// Returns the filter associated with the passed key
|
||||
/datum/proc/get_filter(name)
|
||||
ASSERT(isatom(src) || isimage(src))
|
||||
if(filter_data && filter_data[name])
|
||||
var/atom/atom_cast = src // filters only work with images or atoms.
|
||||
return atom_cast.filters[filter_data.Find(name)]
|
||||
|
||||
/// Returns the indice in filters of the given filter name.
|
||||
/// If it is not found, returns null.
|
||||
/datum/proc/get_filter_index(name)
|
||||
return filter_data?.Find(name)
|
||||
|
||||
/// Removes the passed filter, or multiple filters, if supplied with a list.
|
||||
/datum/proc/remove_filter(name_or_names)
|
||||
if(!filter_data)
|
||||
return
|
||||
|
||||
var/list/names = islist(name_or_names) ? name_or_names : list(name_or_names)
|
||||
|
||||
. = FALSE
|
||||
for(var/name in names)
|
||||
if(filter_data[name])
|
||||
filter_data -= name
|
||||
. = TRUE
|
||||
|
||||
if(.)
|
||||
update_filters()
|
||||
return .
|
||||
|
||||
/datum/proc/clear_filters()
|
||||
ASSERT(isatom(src) || isimage(src))
|
||||
var/atom/atom_cast = src // filters only work with images or atoms.
|
||||
filter_data = null
|
||||
atom_cast.filters = null
|
||||
|
||||
//* Duplication *//
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user