Underfloor refactor + Mild codebase cleanup (#6518)

refactors deprecated and old level / hide system to a more orchestrated
and slightly more efficient one
This commit is contained in:
silicons
2024-06-20 17:09:48 -06:00
committed by GitHub
parent 624552b357
commit 83bc9a7ebf
101 changed files with 641 additions and 1384 deletions
+6 -21
View File
@@ -28,8 +28,6 @@
var/fatigue_pressure = 55*ONE_ATMOSPHERE
alert_pressure = 55*ONE_ATMOSPHERE
level = 1
/obj/machinery/atmospherics/pipe/zpipe/Initialize(mapload, newdir)
. = ..()
init_dir()
@@ -53,11 +51,6 @@
if(SOUTHWEST)
initialize_directions = SOUTH
/obj/machinery/atmospherics/pipe/zpipe/hide(var/i)
if(istype(loc, /turf/simulated))
invisibility = i ? 101 : 0
update_icon()
/obj/machinery/atmospherics/pipe/zpipe/process(delta_time)
if(!parent) //This should cut back on the overhead calling build_network thousands of times per cycle
..()
@@ -105,7 +98,6 @@
/obj/machinery/atmospherics/pipe/zpipe/update_icon()
color = pipe_color
return
/obj/machinery/atmospherics/pipe/zpipe/disconnect(obj/machinery/atmospherics/reference)
if(reference == node1)
@@ -123,11 +115,13 @@
// the elusive up pipe //
/////////////////////////
/obj/machinery/atmospherics/pipe/zpipe/up
icon = 'icons/obj/structures.dmi'
icon_state = "up"
icon = 'icons/obj/structures.dmi'
icon_state = "up"
name = "upwards pipe"
desc = "A pipe segment to connect upwards."
name = "upwards pipe"
desc = "A pipe segment to connect upwards."
hides_underfloor = OBJ_UNDERFLOOR_NEVER
/obj/machinery/atmospherics/pipe/zpipe/up/atmos_init()
normalize_dir()
@@ -151,11 +145,6 @@
node2 = target
break
/* Citadel change, why are upwards pipes capable of being hidden by tiles????
var/turf/T = src.loc // hide if turf is not intact
hide(!T.is_plating())
*/
///////////////////////
// and the down pipe //
///////////////////////
@@ -189,10 +178,6 @@
node2 = target
break
var/turf/T = src.loc // hide if turf is not intact
if(level == 1 && !T.is_plating()) hide(1) // but respect level
///////////////////////
// supply/scrubbers //
///////////////////////