mirror of
https://github.com/Citadel-Station-13/Citadel-Station-13-RP.git
synced 2026-08-31 05:16:30 +01:00
0e0a0af01d
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request - Adds the Experimental Rapid Part Exchange Device. Using bluespace technology for storage, this RPED is more compact (can be put in backpacks), uses an automated panel opening mechanism to more quickly replace parts, and can generally carry more. It's basically the Bluespace RPED from other codebases, except you still need to be near machines to replace parts with them. - Doubles the maximum volume part replacers can carry - this was apparently an oversight by Sili. - Adds the bluespace RPED sprite for the experimental RPED. - Fixes lack of RPED in-hand sprites by simply adding the sprites. - A sound for when parts are replaced is played as feedback. The sound was already in the files. - RPEDs should be able to scoop up beakers that are clicked directly now. - Adds the "tier number" of a stock part in the design name, allowing researchers to be able to search for a stock part's tier more easily using the search bar. - **Most importantly, RPEDs can finally now add parts into unfinished machine frames.** ## Why It's Good For The Game Primarily R&D QoL. In some later PR, I want to be able to make some more machines upgradable, particularly everything in the kitchen. ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> 🆑 add: The Experimental Rapid Part Exchange Device is now available for researchers to fabricate in the protolathe when enough research has been done. tweak: RPEDs now play sounds if they successfully replace parts. qol: You can now search stock parts by tier in the protolathe menu. qol: RPEDs can now add parts into unfinished machine frames. Like they should have. fix: You can now properly scoop up beakers with the RPED when they're clicked. fix: The volume capacity of RPEDs have been fixed, allowing for RPEDs to carry their supposed item capacity as it was before the storage overhaul. imageadd: BSRPED sprite, in-hand sprites for RPED and BSRPED /🆑 <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: silicons <2003111+silicons@users.noreply.github.com>
172 lines
5.6 KiB
Plaintext
172 lines
5.6 KiB
Plaintext
//Circuit boards are in /code/game/objects/items/weapons/circuitboards/machinery/
|
|
|
|
/obj/machinery/constructable_frame //Made into a seperate type to make future revisions easier.
|
|
name = "machine frame"
|
|
icon = 'icons/obj/stock_parts.dmi'
|
|
icon_state = "box_0"
|
|
density = TRUE
|
|
anchored = TRUE
|
|
use_power = USE_POWER_OFF
|
|
var/obj/item/circuitboard/circuit = null
|
|
var/list/components = null
|
|
var/list/req_components = null
|
|
var/list/req_component_names = null
|
|
var/state = 1
|
|
|
|
proc/update_desc()
|
|
var/D
|
|
if(req_components)
|
|
var/list/component_list = new
|
|
for(var/I in req_components)
|
|
if(req_components[I] > 0)
|
|
component_list += "[num2text(req_components[I])] [req_component_names[I]]"
|
|
D = "Requires [english_list(component_list)]."
|
|
desc = D
|
|
|
|
/obj/machinery/constructable_frame/machine_frame/attackby(obj/item/P as obj, mob/user as mob)
|
|
if(user.a_intent == INTENT_HARM) //anti-snowflake melee measures
|
|
return ..()
|
|
switch(state)
|
|
if(1)
|
|
if(istype(P, /obj/item/stack/cable_coil))
|
|
var/obj/item/stack/cable_coil/C = P
|
|
if (C.get_amount() < 5)
|
|
to_chat(user, SPAN_WARNING("You need five lengths of cable to add them to the frame."))
|
|
return
|
|
playsound(src.loc, 'sound/items/Deconstruct.ogg', 50, TRUE)
|
|
to_chat(user, SPAN_NOTICE("You start to add cables to the frame."))
|
|
if(do_after(user, 20) && state == 1)
|
|
if(C.use(5))
|
|
to_chat(user, SPAN_NOTICE("You add cables to the frame."))
|
|
state = 2
|
|
icon_state = "box_1"
|
|
else
|
|
if(P.is_wrench())
|
|
playsound(src, W.tool_sound, 75, TRUE)
|
|
to_chat(user, SPAN_NOTICE("You dismantle the frame"))
|
|
new /obj/item/stack/material/steel(src.loc, 5)
|
|
qdel(src)
|
|
if(2)
|
|
if(istype(P, /obj/item/circuitboard))
|
|
var/obj/item/circuitboard/B = P
|
|
if(B.board_type == "machine")
|
|
playsound(src.loc, 'sound/items/Deconstruct.ogg', 50, TRUE)
|
|
to_chat(user, SPAN_NOTICE("You add the circuit board to the frame."))
|
|
circuit = P
|
|
user.drop_item()
|
|
P.loc = src
|
|
icon_state = "box_2"
|
|
state = 3
|
|
components = list()
|
|
req_components = circuit.req_components.Copy()
|
|
for(var/A in circuit.req_components)
|
|
req_components[A] = circuit.req_components[A]
|
|
req_component_names = circuit.req_components.Copy()
|
|
for(var/A in req_components)
|
|
var/cp = text2path(A)
|
|
var/obj/ct = new cp() // have to quickly instantiate it get name
|
|
req_component_names[A] = ct.name
|
|
update_desc()
|
|
to_chat(user, desc)
|
|
else
|
|
to_chat(user, SPAN_WARNING("This frame does not accept circuit boards of this type!"))
|
|
else
|
|
if(P.is_wirecutter())
|
|
playsound(src.loc, P.tool_sound, 50, TRUE)
|
|
to_chat(user, SPAN_NOTICE("You remove the cables."))
|
|
state = 1
|
|
icon_state = "box_0"
|
|
var/obj/item/stack/cable_coil/A = new /obj/item/stack/cable_coil(src.loc)
|
|
A.amount = 5
|
|
|
|
if(3)
|
|
if(P.is_crowbar())
|
|
playsound(src, P.tool_sound, 50, TRUE)
|
|
state = 2
|
|
circuit.loc = src.loc
|
|
circuit = null
|
|
if(components.len == 0)
|
|
to_chat(user, SPAN_NOTICE("You remove the circuit board."))
|
|
else
|
|
to_chat(user, SPAN_NOTICE("You remove the circuit board and other components."))
|
|
for(var/obj/item/W in components)
|
|
W.loc = src.loc
|
|
desc = initial(desc)
|
|
req_components = null
|
|
components = null
|
|
icon_state = "box_1"
|
|
else
|
|
if(P.is_screwdriver())
|
|
var/component_check = 1
|
|
for(var/R in req_components)
|
|
if(req_components[R] > 0)
|
|
component_check = 0
|
|
break
|
|
if(component_check)
|
|
playsound(src.loc, P.tool_sound, 50, TRUE)
|
|
var/obj/machinery/new_machine = new src.circuit.build_path(src.loc, src.dir)
|
|
|
|
if(new_machine.component_parts)
|
|
new_machine.component_parts.Cut()
|
|
else
|
|
new_machine.component_parts = list()
|
|
|
|
src.circuit.construct(new_machine)
|
|
|
|
for(var/obj/O in src)
|
|
O.loc = new_machine
|
|
new_machine.component_parts += O
|
|
|
|
circuit.loc = new_machine
|
|
|
|
new_machine.RefreshParts()
|
|
qdel(src)
|
|
else if(istype(P, /obj/item/storage/part_replacer))
|
|
var/obj/item/storage/part_replacer/partreplacer = P
|
|
var/addedparts = FALSE
|
|
for(var/obj/item/I in partreplacer.contents)
|
|
if(is_valid_part(I))
|
|
partreplacer.obj_storage.remove(I)
|
|
take_part(I)
|
|
addedparts = TRUE
|
|
if(addedparts)
|
|
playsound(src.loc, partreplacer.part_replacement_sound, 50, TRUE)
|
|
to_chat(user, desc)
|
|
else
|
|
to_chat(user, SPAN_NOTICE("There doesn't seem to be any components in [partreplacer] that can be added."))
|
|
else if(istype(P, /obj/item))
|
|
if(!is_valid_part(P))
|
|
to_chat(user, SPAN_WARNING("You cannot add that component to the machine!"))
|
|
return
|
|
if(!user.attempt_insert_item_for_installation(P, src))
|
|
to_chat(user, SPAN_WARNING("[P] appears to be stuck to your hand!"))
|
|
return
|
|
playsound(src.loc, 'sound/items/Deconstruct.ogg', 50, TRUE)
|
|
take_part(P, user)
|
|
to_chat(user, desc)
|
|
|
|
/obj/machinery/constructable_frame/proc/is_valid_part(obj/item/P)
|
|
for(var/I in req_components)
|
|
if(istype(P, text2path(I)) && (req_components[I] > 0))
|
|
return TRUE
|
|
return FALSE
|
|
|
|
/obj/machinery/constructable_frame/proc/take_part(obj/item/P, mob/user)
|
|
if(istype(P, /obj/item/stack)) //usually for cable coil. can support other stacks.
|
|
var/obj/item/stack/S = P
|
|
if(S.get_amount() > 1)
|
|
var/camt = min(S.amount, req_components[I]) // amount of the stack to take, ideally amount required, but limited by amount provided
|
|
var/obj/item/stack/SP = new S.type(src)
|
|
SP.amount = camt
|
|
SP.update_icon()
|
|
S.use(camt)
|
|
components += SP
|
|
req_components[I] -= camt
|
|
update_desc()
|
|
return TRUE
|
|
P.forceMove(src)
|
|
components += P
|
|
req_components[I]--
|
|
update_desc()
|
|
return TRUE
|