mirror of
https://github.com/Citadel-Station-13/Citadel-Station-13-RP.git
synced 2026-08-26 00:46:58 +01:00
SorrowfulwindsandGitHub
927f61808e
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Space dust has had an incorrect icon_state for 7+ years, this makes it visible again. Updates the space_dust event to actually work if triggered by the GM events. It was using specific strings while being fed integer defines instead. Cleans up some older code, a commented out call to space_dust that is older than the hard sync and can just go away. Removes space_dust not damaging singulo engine equipment since we don't use the singulo and its a skill issue if your singulo gets sniped by space dust. I think the entire event system on its own may have issues actually turning on but this event can at least be manually triggered by GMs and work now. <img width="132" height="117" alt="image" src="https://github.com/user-attachments/assets/8fc35622-feeb-4189-9c40-9990615caa4e" /> <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Lowers legacy tech debt, increases shareholder value. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog -Fix the icon for space dust. -Modernize severity value to use EVENT_LEVEL_* defines. -Add EVENT_LEVEL_EXTREME define for a severity 4 choice. -Remove old code for protecting singulo equipment. -Remove commented out code for dust swarm older than the hardsync. -Update gm event system to correctly call dust_swarm. <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> 🆑 fix: fixed space dust /🆑 <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
18 lines
513 B
Plaintext
18 lines
513 B
Plaintext
/datum/gm_action/dust
|
|
name = "dust"
|
|
departments = list(DEPARTMENT_ENGINEERING)
|
|
chaotic = 10
|
|
reusable = TRUE
|
|
|
|
/datum/gm_action/dust/announce()
|
|
command_announcement.Announce("Debris resulting from activity on another nearby asteroid is approaching your colony.", "Dust Alert")
|
|
|
|
/datum/gm_action/dust/get_weight()
|
|
var/engineers = metric.count_people_in_department(DEPARTMENT_ENGINEERING)
|
|
var/weight = 30 + (engineers * 25)
|
|
return weight
|
|
|
|
/datum/gm_action/dust/start()
|
|
..()
|
|
dust_swarm(EVENT_LEVEL_MODERATE)
|