Revert "Tg status tab"

This reverts commit 931f3ca63b.

code/controllers/subsystem/acid.dm

@@ -7,9 +7,9 @@ SUBSYSTEM_DEF(acid)
 	var/list/currentrun = list()
 	var/list/processing = list()
 
-/datum/controller/subsystem/acid/stat_entry(msg)
-	msg = "P:[length(processing)]"
-	return ..()
+/datum/controller/subsystem/acid/stat_entry()
+	..("P:[processing.len]")
+
 
 /datum/controller/subsystem/acid/fire(resumed = 0)
 	if (!resumed)

code/controllers/subsystem/adjacent_air.dm

@@ -6,13 +6,12 @@ SUBSYSTEM_DEF(adjacent_air)
 	priority = FIRE_PRIORITY_ATMOS_ADJACENCY
 	var/list/queue = list()
 
-/datum/controller/subsystem/adjacent_air/stat_entry(msg)
+/datum/controller/subsystem/adjacent_air/stat_entry()
 #ifdef TESTING
-	msg = "P:[length(queue)], S:[GLOB.atmos_adjacent_savings[1]], T:[GLOB.atmos_adjacent_savings[2]]"
+	..("P:[length(queue)], S:[GLOB.atmos_adjacent_savings[1]], T:[GLOB.atmos_adjacent_savings[2]]")
 #else
-	msg = "P:[length(queue)]"
+	..("P:[length(queue)]")
 #endif
-	return ..()
 
 /datum/controller/subsystem/adjacent_air/Initialize()
 	while(length(queue))

code/controllers/subsystem/augury.dm

@@ -9,8 +9,7 @@ SUBSYSTEM_DEF(augury)
 	var/list/observers_given_action = list()
 
 /datum/controller/subsystem/augury/stat_entry(msg)
-	msg = "W:[watchers.len]|D:[length(doombringers)]"
-	return ..()
+	..("W:[watchers.len]|D:[doombringers.len]")
 
 /datum/controller/subsystem/augury/proc/register_doom(atom/A, severity)
 	doombringers[A] = severity

code/controllers/subsystem/disease.dm

@@ -20,8 +20,7 @@ SUBSYSTEM_DEF(disease)
 	return ..()
 
 /datum/controller/subsystem/disease/stat_entry(msg)
-	msg = "P:[length(active_diseases)]"
-	return ..()
+	..("P:[active_diseases.len]")
 
 /datum/controller/subsystem/disease/proc/get_disease_name(id)
 	var/datum/disease/advance/A = archive_diseases[id]

code/controllers/subsystem/fire_burning.dm

@@ -7,9 +7,9 @@ SUBSYSTEM_DEF(fire_burning)
 	var/list/currentrun = list()
 	var/list/processing = list()
 
-/datum/controller/subsystem/fire_burning/stat_entry(msg)
-	msg = "P:[length(processing)]"
-	return ..()
+/datum/controller/subsystem/fire_burning/stat_entry()
+	..("P:[processing.len]")
+
 
 /datum/controller/subsystem/fire_burning/fire(resumed = 0)
 	if (!resumed)

code/controllers/subsystem/garbage.dm

@@ -57,7 +57,7 @@ SUBSYSTEM_DEF(garbage)
 		msg += "TGR:[round((totalgcs/(totaldels+totalgcs))*100, 0.01)]%"
 	msg += " P:[pass_counts.Join(",")]"
 	msg += "|F:[fail_counts.Join(",")]"
-	return ..()
+	..(msg)
 
 /datum/controller/subsystem/garbage/Shutdown()
 	//Adds the del() log to the qdel log file

code/controllers/subsystem/idlenpcpool.dm

@@ -8,11 +8,10 @@ SUBSYSTEM_DEF(idlenpcpool)
 	var/list/currentrun = list()
 	var/static/list/idle_mobs_by_zlevel[][]
 
-/datum/controller/subsystem/idlenpcpool/stat_entry(msg)
+/datum/controller/subsystem/idlenpcpool/stat_entry()
 	var/list/idlelist = GLOB.simple_animals[AI_IDLE]
 	var/list/zlist = GLOB.simple_animals[AI_Z_OFF]
-	msg = "IdleNPCS:[length(idlelist)]|Z:[length(zlist)]"
-	return ..()
+	..("IdleNPCS:[idlelist.len]|Z:[zlist.len]")
 
 /datum/controller/subsystem/idlenpcpool/proc/MaxZChanged()
 	if (!islist(idle_mobs_by_zlevel))

code/controllers/subsystem/lighting.dm

@@ -7,13 +7,10 @@ SUBSYSTEM_DEF(lighting)
 	wait = 2
 	init_order = INIT_ORDER_LIGHTING
 	flags = SS_TICKER
-	var/static/list/sources_queue = list() // List of lighting sources queued for update.
-	var/static/list/corners_queue = list() // List of lighting corners queued for update.
-	var/static/list/objects_queue = list() // List of lighting objects queued for update.
 
-/datum/controller/subsystem/lighting/stat_entry(msg)
-	msg = "L:[length(sources_queue)]|C:[length(corners_queue)]|O:[length(objects_queue)]"
-	return ..()
+/datum/controller/subsystem/lighting/stat_entry()
+	..("L:[GLOB.lighting_update_lights.len]|C:[GLOB.lighting_update_corners.len]|O:[GLOB.lighting_update_objects.len]")
+
 
 /datum/controller/subsystem/lighting/Initialize(timeofday)
 	if(!initialized)

code/controllers/subsystem/machines.dm

@@ -22,10 +22,9 @@ SUBSYSTEM_DEF(machines)
 			NewPN.add_cable(PC)
 			propagate_network(PC,PC.powernet)
 
+/datum/controller/subsystem/machines/stat_entry()
+	..("M:[processing.len]|PN:[powernets.len]")
 
-/datum/controller/subsystem/machines/stat_entry(msg)
-	msg = "M:[length(processing)]|PN:[length(powernets)]"
-	return ..()
 
 /datum/controller/subsystem/machines/fire(resumed = 0)
 	if (!resumed)

code/controllers/subsystem/mobs.dm

@@ -10,9 +10,8 @@ SUBSYSTEM_DEF(mobs)
 	var/static/list/cubemonkeys = list()
 	var/static/list/cheeserats = list()
 
-/datum/controller/subsystem/mobs/stat_entry(msg)
-	msg = "P:[length(GLOB.mob_living_list)]"
-	return ..()
+/datum/controller/subsystem/mobs/stat_entry()
+	..("P:[GLOB.mob_living_list.len]")
 
 /datum/controller/subsystem/mobs/proc/MaxZChanged()
 	if (!islist(clients_by_zlevel))

code/controllers/subsystem/npcpool.dm

@@ -6,10 +6,9 @@ SUBSYSTEM_DEF(npcpool)
 
 	var/list/currentrun = list()
 
-/datum/controller/subsystem/npcpool/stat_entry(msg)
+/datum/controller/subsystem/npcpool/stat_entry()
 	var/list/activelist = GLOB.simple_animals[AI_ON]
-	msg = "NPCS:[length(activelist)]"
-	return ..()
+	..("NPCS:[activelist.len]")
 
 /datum/controller/subsystem/npcpool/fire(resumed = FALSE)
 

code/controllers/subsystem/overlays.dm

@@ -21,9 +21,10 @@ SUBSYSTEM_DEF(overlays)
 	fire(mc_check = FALSE)
 	return ..()
 
-/datum/controller/subsystem/overlays/stat_entry(msg)
-	msg = "Ov:[length(queue)]"
-	return ..()
+
+/datum/controller/subsystem/overlays/stat_entry()
+	..("Ov:[length(queue)]")
+
 
 /datum/controller/subsystem/overlays/Shutdown()
 	text2file(render_stats(stats), "[GLOB.log_directory]/overlay.log")

code/controllers/subsystem/processing/processing.dm

@@ -10,9 +10,8 @@ SUBSYSTEM_DEF(processing)
 	var/list/processing = list()
 	var/list/currentrun = list()
 
-/datum/controller/subsystem/processing/stat_entry(msg)
-	msg = "[stat_tag]:[length(processing)]"
-	return ..()
+/datum/controller/subsystem/processing/stat_entry()
+	..("[stat_tag]:[processing.len]")
 
 /datum/controller/subsystem/processing/fire(resumed = 0)
 	if (!resumed)

code/controllers/subsystem/spacedrift.dm

@@ -8,9 +8,9 @@ SUBSYSTEM_DEF(spacedrift)
 	var/list/currentrun = list()
 	var/list/processing = list()
 
-/datum/controller/subsystem/spacedrift/stat_entry(msg)
-	msg = "P:[length(processing)]"
-	return ..()
+/datum/controller/subsystem/spacedrift/stat_entry()
+	..("P:[processing.len]")
+
 
 /datum/controller/subsystem/spacedrift/fire(resumed = 0)
 	if (!resumed)

code/controllers/subsystem/statpanel.dm

@@ -1,114 +0,0 @@
-SUBSYSTEM_DEF(statpanels)
-	name = "Stat Panels"
-	wait = 4
-	init_order = INIT_ORDER_STATPANELS
-	runlevels = RUNLEVELS_DEFAULT | RUNLEVEL_LOBBY
-	var/list/currentrun = list()
-	var/encoded_global_data
-	var/mc_data_encoded
-	var/list/cached_images = list()
-
-/datum/controller/subsystem/statpanels/fire(resumed = FALSE)
-	if (!resumed)
-		var/datum/map_config/cached = SSmapping.next_map_config
-		var/round_time = world.time - SSticker.round_start_time
-		var/list/global_data = list(
-			"Map: [SSmapping.config?.map_name || "Loading..."]",
-			cached ? "Next Map: [cached.map_name]" : null,
-			"Round ID: [GLOB.round_id ? GLOB.round_id : "NULL"]",
-			"Server Time: [time2text(world.timeofday, "YYYY-MM-DD hh:mm:ss")]",
-			"Round Time: [round_time > MIDNIGHT_ROLLOVER ? "[round(round_time/MIDNIGHT_ROLLOVER)]:[worldtime2text()]" : worldtime2text()]",
-			"Station Time: [station_time_timestamp()]",
-			"Time Dilation: [round(SStime_track.time_dilation_current,1)]% AVG:([round(SStime_track.time_dilation_avg_fast,1)]%, [round(SStime_track.time_dilation_avg,1)]%, [round(SStime_track.time_dilation_avg_slow,1)]%)"
-		)
-
-		if(SSshuttle.emergency)
-			var/ETA = SSshuttle.emergency.getModeStr()
-			if(ETA)
-				global_data += "[ETA] [SSshuttle.emergency.getTimerStr()]"
-		encoded_global_data = url_encode(json_encode(global_data))
-
-		var/list/mc_data = list(
-			list("CPU:", world.cpu),
-			list("Instances:", "[num2text(world.contents.len, 10)]"),
-			list("World Time:", "[world.time]"),
-			list("Globals:", "Edit", "\ref[GLOB]"),
-			list("[config]:", "Edit", "\ref[config]"),
-			list("Byond:", "(FPS:[world.fps]) (TickCount:[world.time/world.tick_lag]) (TickDrift:[round(Master.tickdrift,1)]([round((Master.tickdrift/(world.time/world.tick_lag))*100,0.1)]%))"),
-			list("Master Controller:", Master ? "(TickRate:[Master.processing]) (Iteration:[Master.iteration])" : "ERROR", "\ref[Master]"),
-			list("Failsafe Controller:", Failsafe ? "Defcon: [Failsafe.defcon_pretty()] (Interval: [Failsafe.processing_interval] | Iteration: [Failsafe.master_iteration])" : "ERROR", "\ref[Failsafe]"),
-			list("","")
-		)
-		for(var/ss in Master.subsystems)
-			var/datum/controller/subsystem/sub_system = ss
-			mc_data[++mc_data.len] = list("\[[sub_system.state_letter()]][sub_system.name]", sub_system.stat_entry(), "\ref[sub_system]")
-		mc_data[++mc_data.len] = list("Camera Net", "Cameras: [GLOB.cameranet.cameras.len] | Chunks: [GLOB.cameranet.chunks.len]", "\ref[GLOB.cameranet]")
-		mc_data_encoded = url_encode(json_encode(mc_data))
-		src.currentrun = GLOB.clients.Copy()
-
-	var/list/currentrun = src.currentrun
-	while(length(currentrun))
-		var/client/target = currentrun[length(currentrun)]
-		currentrun.len--
-		var/ping_str = url_encode("Ping: [round(target.lastping, 1)]ms (Average: [round(target.avgping, 1)]ms)")
-		var/other_str = url_encode(json_encode(target.mob.get_status_tab_items()))
-		target << output("[encoded_global_data];[ping_str];[other_str]", "statbrowser:update")
-		if(!target.holder)
-			target << output("", "statbrowser:remove_admin_tabs")
-		else
-			var/turf/eye_turf = get_turf(target.eye)
-			var/coord_entry = url_encode(COORD(eye_turf))
-			target << output("[mc_data_encoded];[coord_entry];[url_encode(target.holder.href_token)]", "statbrowser:update_mc")
-			var/list/ahelp_tickets = GLOB.ahelp_tickets.stat_entry()
-			target << output("[url_encode(json_encode(ahelp_tickets))];", "statbrowser:update_tickets")
-			if(!length(GLOB.sdql2_queries))
-				target << output("", "statbrowser:remove_sqdl2")
-			else
-				var/list/sqdl2A = list()
-				sqdl2A[++sqdl2A.len] = list("", "Access Global SDQL2 List", REF(GLOB.sdql2_vv_statobj))
-				var/list/sqdl2B = list()
-				sqdl2A += sqdl2B
-				target << output(url_encode(json_encode(sqdl2A)), "statbrowser:update_sqdl2")
-		var/list/proc_holders = target.mob.get_proc_holders()
-		target.spell_tabs.Cut()
-		for(var/phl in proc_holders)
-			var/list/proc_holder_list = phl
-			target.spell_tabs |= proc_holder_list[1]
-		var/proc_holders_encoded = ""
-		if(length(proc_holders))
-			proc_holders_encoded = url_encode(json_encode(proc_holders))
-		target << output("[url_encode(json_encode(target.spell_tabs))];[proc_holders_encoded]", "statbrowser:update_spells")
-		if(target.mob?.listed_turf)
-			var/mob/target_mob = target.mob
-			if(!target_mob.TurfAdjacent(target_mob.listed_turf))
-				target << output("", "statbrowser:remove_listedturf")
-				target_mob.listed_turf = null
-			else
-				var/list/overrides = list()
-				var/list/turfitems = list()
-				for(var/img in target.images)
-					var/image/target_image = img
-					if(!target_image.loc || target_image.loc.loc != target_mob.listed_turf || !target_image.override)
-						continue
-					overrides += target_image.loc
-				for(var/tc in target_mob.listed_turf)
-					var/atom/movable/turf_content = tc
-					if(turf_content.mouse_opacity == MOUSE_OPACITY_TRANSPARENT)
-						continue
-					if(turf_content.invisibility > target_mob.see_invisible)
-						continue
-					if(turf_content in overrides)
-						continue
-					if(turf_content.IsObscured())
-						continue
-					if(length(turfitems) < 30) // only create images for the first 30 items on the turf, for performance reasons
-						if(!(REF(turf_content) in cached_images))
-							target << browse_rsc(getFlatIcon(turf_content, no_anim = TRUE), "[REF(turf_content)].png")
-							cached_images += REF(turf_content)
-						turfitems[++turfitems.len] = list("[turf_content.name]", REF(turf_content), "[REF(turf_content)].png")
-					else
-						turfitems[++turfitems.len] = list("[turf_content.name]", REF(turf_content))
-				turfitems = url_encode(json_encode(turfitems))
-				target << output("[turfitems];", "statbrowser:update_listedturf")
-		if(MC_TICK_CHECK)
-			return

code/controllers/subsystem/tgui.dm

@@ -16,9 +16,8 @@ SUBSYSTEM_DEF(tgui)
 /datum/controller/subsystem/tgui/Shutdown()
 	close_all_uis()
 
-/datum/controller/subsystem/tgui/stat_entry(msg)
-	msg = "P:[length(open_uis)]"
-	return ..()
+/datum/controller/subsystem/tgui/stat_entry()
+	..("P:[processing_uis.len]")
 
 /datum/controller/subsystem/tgui/fire(resumed = 0)
 	if (!resumed)

code/controllers/subsystem/throwing.dm

@@ -11,9 +11,9 @@ SUBSYSTEM_DEF(throwing)
 	var/list/currentrun
 	var/list/processing = list()
 
-/datum/controller/subsystem/throwing/stat_entry(msg)
-	msg = "P:[length(processing)]"
-	return ..()
+/datum/controller/subsystem/throwing/stat_entry()
+	..("P:[processing.len]")
+
 
 /datum/controller/subsystem/throwing/fire(resumed = 0)
 	if (!resumed)

code/controllers/subsystem/ticker.dm

@@ -402,7 +402,6 @@ SUBSYSTEM_DEF(ticker)
 			if(living.client)
 				var/obj/screen/splash/S = new(living.client, TRUE)
 				S.Fade(TRUE)
-				living.client.init_verbs()
 			livings += living
 	if(livings.len)
 		addtimer(CALLBACK(src, .proc/release_characters, livings), 30, TIMER_CLIENT_TIME)
@@ -678,7 +677,7 @@ SUBSYSTEM_DEF(ticker)
 	if(!round_end_sound)
 		round_end_sound = pick(\
 		'sound/roundend/iwishtherewassomethingmore.ogg',
-		'sound/roundend/likeisaid.ogg',
+		'sound/roundend/likeisaid.ogg',	
 		'sound/roundend/whatarottenwaytodie.ogg',
 		'sound/roundend/whatashame.ogg',
 		'sound/roundend/newroundsexy.ogg',

code/controllers/subsystem/timer.dm

@@ -34,8 +34,7 @@ SUBSYSTEM_DEF(timer)
 	bucket_resolution = world.tick_lag
 
 /datum/controller/subsystem/timer/stat_entry(msg)
-	msg = "B:[bucket_count] P:[length(second_queue)] H:[length(hashes)] C:[length(clienttime_timers)] S:[length(timer_id_dict)]"
-	return ..()
+	..("B:[bucket_count] P:[length(second_queue)] H:[length(hashes)] C:[length(clienttime_timers)] S:[length(timer_id_dict)]")
 
 /datum/controller/subsystem/timer/fire(resumed = FALSE)
 	var/lit = last_invoke_tick