diff --git a/code/modules/admin/DB ban/functions.dm b/code/modules/admin/DB ban/functions.dm
index f0fa25224b5..da0c6d64e60 100644
--- a/code/modules/admin/DB ban/functions.dm
+++ b/code/modules/admin/DB ban/functions.dm
@@ -1,5 +1,5 @@
-datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration = -1, var/reason, var/job = "", var/rounds = 0, var/banckey = null)
+datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration = -1, var/reason, var/job = "", var/rounds = 0, var/banckey = null, var/banip = null, var/bancid = null)
if(!check_rights(R_BAN)) return
@@ -45,6 +45,8 @@ datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration =
ip = banned_mob.client.address
else if(banckey)
ckey = ckey(banckey)
+ computerid = bancid
+ ip = banip
var/DBQuery/query = dbcon.NewQuery("SELECT id FROM erro_player WHERE ckey = '[ckey]'")
query.Execute()
@@ -268,7 +270,7 @@ datum/admins/proc/DB_ban_unban_by_id(var/id)
holder.DB_ban_panel()
-/datum/admins/proc/DB_ban_panel(var/playerckey = null, var/adminckey = null, var/playerip = null, var/pban = null, var/tban = null, var/jpban = null, var/jtban = null)
+/datum/admins/proc/DB_ban_panel(var/playerckey = null, var/adminckey = null, var/playerip = null, var/playercid = null, var/dbbantype = null, var/match = null)
if(!usr.client)
return
@@ -291,7 +293,7 @@ datum/admins/proc/DB_ban_unban_by_id(var/id)
output += "
"
- output += "Please note that all jobban bans or unbans are in-effect the following round."
+ output += "Please note that all jobban bans or unbans are in-effect the following round.
"
+ output += "This search shows only last 100 bans."
-
-
-
- if(adminckey || playerckey || playerip || pban || tban || jpban || jtban)
-
- var/blcolor = "#ffeeee" //banned light
- var/bdcolor = "#ffdddd" //banned dark
- var/ulcolor = "#eeffee" //unbanned light
- var/udcolor = "#ddffdd" //unbanned dark
-
- output += ""
- output += ""
- output += "| TYPE | "
- output += "CKEY | "
- output += "TIME APPLIED | "
- output += "ADMIN | "
- output += "OPTIONS | "
- output += "
"
+ if(adminckey || playerckey || playerip || playercid || dbbantype)
adminckey = ckey(adminckey)
playerckey = ckey(playerckey)
+ playerip = sql_sanitize_text(playerip)
+ playercid = sql_sanitize_text(playercid)
- var/adminsearch = ""
- var/playersearch = ""
- var/playeripsearch = ""
- var/pbansearch = ""
- var/tbansearch = ""
- var/jpbansearch = ""
- var/jtbansearch = ""
- if(adminckey)
- adminsearch = "AND a_ckey = '[adminckey]' "
- if(playerckey)
- playersearch = "AND ckey = '[playerckey]' "
- if(playerip)
- playeripsearch = "AND ip = '[playerip]' "
- if(pban != null)
- pbansearch = "AND bantype = 'PERMABAN'"
- if(tban != null)
- tbansearch = "AND bantype = 'TEMPBAN'"
- if(jpban != null)
- jpbansearch = "AND bantype = 'JOB_PERMABAN'"
- if(jtban != null)
- jtbansearch = "AND bantype = 'JOB_TEMPBAN'"
+ if(adminckey || playerckey || playerip || playercid || dbbantype)
+ var/blcolor = "#ffeeee" //banned light
+ var/bdcolor = "#ffdddd" //banned dark
+ var/ulcolor = "#eeffee" //unbanned light
+ var/udcolor = "#ddffdd" //unbanned dark
-
- var/DBQuery/select_query = dbcon.NewQuery("SELECT id, bantime, bantype, reason, job, duration, expiration_time, ckey, a_ckey, unbanned, unbanned_ckey, unbanned_datetime, edits, ip FROM erro_ban WHERE 1 [pbansearch] [tbansearch] [jpbansearch] [jtbansearch] [playersearch] [adminsearch] [playeripsearch] ORDER BY bantime DESC")
- select_query.Execute()
-
- while(select_query.NextRow())
- var/banid = select_query.item[1]
- var/bantime = select_query.item[2]
- var/bantype = select_query.item[3]
- var/reason = select_query.item[4]
- var/job = select_query.item[5]
- var/duration = select_query.item[6]
- var/expiration = select_query.item[7]
- var/ckey = select_query.item[8]
- var/ackey = select_query.item[9]
- var/unbanned = select_query.item[10]
- var/unbanckey = select_query.item[11]
- var/unbantime = select_query.item[12]
- var/edits = select_query.item[13]
- var/ip = select_query.item[14]
-
- var/lcolor = blcolor
- var/dcolor = bdcolor
- if(unbanned)
- lcolor = ulcolor
- dcolor = udcolor
-
- var/typedesc =""
- switch(bantype)
- if("PERMABAN")
- typedesc = "PERMABAN"
- if("TEMPBAN")
- typedesc = "TEMPBAN
([duration] minutes [(unbanned) ? "" : "(Edit))"]
Expires [expiration]"
- if("JOB_PERMABAN")
- typedesc = "JOBBAN
([job])"
- if("JOB_TEMPBAN")
- typedesc = "TEMP JOBBAN
([job])
([duration] minutes
Expires [expiration]"
- if("APPEARANCE_BAN")
- typedesc = "APPEARANCE/NAME BAN"
-
-
- output += ""
- output += "| [typedesc] | "
- output += "[ckey] | "
- output += "[bantime] | "
- output += "[ackey] | "
- output += "[(unbanned) ? "" : "Unban"] | "
+ output += ""
+ output += ""
+ output += "| TYPE | "
+ output += "CKEY | "
+ output += "TIME APPLIED | "
+ output += "ADMIN | "
+ output += "OPTIONS | "
output += "
"
- output += ""
- output += "| Reason: [(unbanned) ? "" : "(Edit)"] \"[reason]\" | "
- output += "IP: [ip] | "
- output += "
"
- if(edits)
+
+ var/adminsearch = ""
+ var/playersearch = ""
+ var/ipsearch = ""
+ var/cidsearch = ""
+ var/bantypesearch = ""
+
+ if(!match)
+ if(adminckey)
+ adminsearch = "AND a_ckey = '[adminckey]' "
+ if(playerckey)
+ playersearch = "AND ckey = '[playerckey]' "
+ if(playerip)
+ ipsearch = "AND ip = '[playerip]' "
+ if(playercid)
+ cidsearch = "AND computerid = '[playercid]' "
+ else
+ if(adminckey && lentext(adminckey) >= 3)
+ adminsearch = "AND a_ckey LIKE '[adminckey]%' "
+ if(playerckey && lentext(playerckey) >= 3)
+ playersearch = "AND ckey LIKE '[playerckey]%' "
+ if(playerip && lentext(playerip) >= 3)
+ ipsearch = "AND ip LIKE '[playerip]%' "
+ if(playercid && lentext(playercid) >= 7)
+ cidsearch = "AND computerid LIKE '[playercid]%' "
+
+ if(dbbantype)
+ bantypesearch = "AND bantype = "
+
+ switch(dbbantype)
+ if(BANTYPE_TEMP)
+ bantypesearch += "'TEMPBAN' "
+ if(BANTYPE_JOB_PERMA)
+ bantypesearch += "'JOB_PERMABAN' "
+ if(BANTYPE_JOB_TEMP)
+ bantypesearch += "'JOB_TEMPBAN' "
+ if(BANTYPE_APPEARANCE)
+ bantypesearch += "'APPEARANCE_BAN' "
+ else
+ bantypesearch += "'PERMABAN' "
+
+
+ var/DBQuery/select_query = dbcon.NewQuery("SELECT id, bantime, bantype, reason, job, duration, expiration_time, ckey, a_ckey, unbanned, unbanned_ckey, unbanned_datetime, edits, ip, computerid FROM erro_ban WHERE 1 [playersearch] [adminsearch] [ipsearch] [cidsearch] [bantypesearch] ORDER BY bantime DESC LIMIT 100")
+ select_query.Execute()
+
+ while(select_query.NextRow())
+ var/banid = select_query.item[1]
+ var/bantime = select_query.item[2]
+ var/bantype = select_query.item[3]
+ var/reason = select_query.item[4]
+ var/job = select_query.item[5]
+ var/duration = select_query.item[6]
+ var/expiration = select_query.item[7]
+ var/ckey = select_query.item[8]
+ var/ackey = select_query.item[9]
+ var/unbanned = select_query.item[10]
+ var/unbanckey = select_query.item[11]
+ var/unbantime = select_query.item[12]
+ var/edits = select_query.item[13]
+ var/ip = select_query.item[14]
+ var/cid = select_query.item[15]
+
+ var/lcolor = blcolor
+ var/dcolor = bdcolor
+ if(unbanned)
+ lcolor = ulcolor
+ dcolor = udcolor
+
+ var/typedesc =""
+ switch(bantype)
+ if("PERMABAN")
+ typedesc = "PERMABAN"
+ if("TEMPBAN")
+ typedesc = "TEMPBAN
([duration] minutes [(unbanned) ? "" : "(Edit))"]
Expires [expiration]"
+ if("JOB_PERMABAN")
+ typedesc = "JOBBAN
([job])"
+ if("JOB_TEMPBAN")
+ typedesc = "TEMP JOBBAN
([job])
([duration] minutes
Expires [expiration]"
+ if("APPEARANCE_BAN")
+ typedesc = "APPEARANCE/NAME BAN"
+
output += ""
- output += "| EDITS | "
+ output += "[typedesc] | "
+ output += "[ckey] | "
+ output += "[bantime] | "
+ output += "[ackey] | "
+ output += "[(unbanned) ? "" : "Unban"] | "
+ output += "
"
+ output += ""
+ output += "| IP: [ip] | "
+ output += "CIP: [cid] | "
output += "
"
output += ""
- output += "| [edits] | "
+ output += "Reason: [(unbanned) ? "" : "(Edit)"] \"[reason]\" | "
output += "
"
- if(unbanned)
- output += ""
- output += "| UNBANNED by admin [unbanckey] on [unbantime] | "
+ if(edits)
+ output += "
"
+ output += "| EDITS | "
+ output += "
"
+ output += ""
+ output += "| [edits] | "
+ output += "
"
+ if(unbanned)
+ output += ""
+ output += "| UNBANNED by admin [unbanckey] on [unbantime] | "
+ output += "
"
+ output += ""
+ output += "|   | "
output += "
"
- output += ""
- output += "|   | "
- output += "
"
- output += "
"
+ output += "
"
-
-
-
- else
-
- var/DBQuery/select_query = dbcon.NewQuery("SELECT bantype, COUNT(*) FROM erro_ban GROUP BY bantype")
- select_query.Execute()
-
- while(select_query.NextRow())
- var/bantype = select_query.item[1]
- var/count = select_query.item[2]
-
-
- output +="
"
- output += "| [bantype]:[count] | "
- output += "
"
- output += ""
-
-/*
- var/blcolor = "#ffeeee" //banned light
- var/bdcolor = "#ffdddd" //banned dark
- var/ulcolor = "#eeffee" //unbanned light
- var/udcolor = "#ddffdd" //unbanned dark
-
- output += ""
- output += ""
- output += "| TYPE | "
- output += "CKEY | "
- output += "TIME APPLIED | "
- output += "ADMIN | "
- output += "OPTIONS | "
- output += "
"
-
-
- var/DBQuery/select_query = dbcon.NewQuery("SELECT id, bantime, bantype, reason, job, duration, expiration_time, ckey, a_ckey, unbanned, unbanned_ckey, unbanned_datetime, edits, ip FROM erro_ban ORDER BY bantime DESC")
- select_query.Execute()
-
- while(select_query.NextRow())
- var/banid = select_query.item[1]
- var/bantime = select_query.item[2]
- var/bantype = select_query.item[3]
- var/reason = select_query.item[4]
- var/job = select_query.item[5]
- var/duration = select_query.item[6]
- var/expiration = select_query.item[7]
- var/ckey = select_query.item[8]
- var/ackey = select_query.item[9]
- var/unbanned = select_query.item[10]
- var/unbanckey = select_query.item[11]
- var/unbantime = select_query.item[12]
- var/edits = select_query.item[13]
- var/ip = select_query.item[14]
-
- var/lcolor = blcolor
- var/dcolor = bdcolor
- if(unbanned)
- lcolor = ulcolor
- dcolor = udcolor
-
- var/typedesc =""
- switch(bantype)
- if("PERMABAN")
- typedesc = "PERMABAN"
- if("TEMPBAN")
- typedesc = "TEMPBAN
([duration] minutes [(unbanned) ? "" : "(Edit))"]
Expires [expiration]"
- if("JOB_PERMABAN")
- typedesc = "JOBBAN
([job])"
- if("JOB_TEMPBAN")
- typedesc = "TEMP JOBBAN
([job])
([duration] minutes
Expires [expiration]"
-
- output += ""
- output += "| [typedesc] | "
- output += "[ckey] | "
- output += "[bantime] | "
- output += "[ackey] | "
- output += "[(unbanned) ? "" : "Unban"] | "
- output += "
"
- output += ""
- output += "| Reason: [(unbanned) ? "" : "(Edit)"] \"[reason]\" | "
- output += "IP: [ip] | "
- output += "
"
- if(edits)
- output += ""
- output += "| EDITS | "
- output += "
"
- output += ""
- output += "| [edits] | "
- output += "
"
- if(unbanned)
- output += ""
- output += "| UNBANNED by admin [unbanckey] on [unbantime] | "
- output += "
"
- output += ""
- output += "|   | "
- output += "
"
-
- output += "
"
-*/
- usr << browse(output,"window=lookupbans;size=900x500")
\ No newline at end of file
+ usr << browse(output,"window=lookupbans;size=900x700")
\ No newline at end of file
diff --git a/code/modules/admin/topic.dm b/code/modules/admin/topic.dm
index d9caa1eac15..210d020553f 100644
--- a/code/modules/admin/topic.dm
+++ b/code/modules/admin/topic.dm
@@ -45,16 +45,18 @@
if(!src.makeVoxRaiders())
usr << "\red Unfortunately there weren't enough candidates available."
- else if(href_list["dbsearchckey"] || href_list["dbsearchadmin"] || href_list["dbsearchip"] || href_list["dbpban"] || href_list["dbtban"] || href_list["dbjpban"] || href_list["dbjtban"])
+ else if(href_list["dbsearchckey"] || href_list["dbsearchadmin"] || href_list["dbsearchip"] || href_list["dbsearchcid"] || href_list["dbsearchbantype"])
var/adminckey = href_list["dbsearchadmin"]
var/playerckey = href_list["dbsearchckey"]
var/playerip = href_list["dbsearchip"]
- var/pban = href_list["dbpban"]
- var/tban = href_list["dbtban"]
- var/jpban = href_list["dbjpban"]
- var/jtban = href_list["dbjtban"]
+ var/playercid = href_list["dbsearchcid"]
+ var/dbbantype = text2num(href_list["dbsearchbantype"])
+ var/match = 0
- DB_ban_panel(playerckey, adminckey, playerip, pban, tban, jpban, jtban)
+ if("dbmatch" in href_list)
+ match = 1
+
+ DB_ban_panel(playerckey, adminckey, playerip, playercid, dbbantype, match)
return
else if(href_list["dbbanedit"])
@@ -66,11 +68,12 @@
DB_ban_edit(banid, banedit)
return
-
else if(href_list["dbbanaddtype"])
var/bantype = text2num(href_list["dbbanaddtype"])
var/banckey = href_list["dbbanaddckey"]
+ var/banip = href_list["dbbanaddip"]
+ var/bancid = href_list["dbbanaddcid"]
var/banduration = text2num(href_list["dbbaddduration"])
var/banjob = href_list["dbbanaddjob"]
var/banreason = href_list["dbbanreason"]
@@ -98,6 +101,12 @@
if(!banckey || !banreason || !banjob || !banduration)
usr << "Not enough parameters (Requires ckey, reason and job)"
return
+ if(BANTYPE_APPEARANCE)
+ if(!banckey || !banreason)
+ usr << "Not enough parameters (Requires ckey and reason)"
+ return
+ banduration = null
+ banjob = null
var/mob/playermob
@@ -106,9 +115,19 @@
playermob = M
break
+
banreason = "(MANUAL BAN) "+banreason
- DB_ban_record(bantype, playermob, banduration, banreason, banjob, null, banckey)
+ if(!playermob)
+ if(banip)
+ banreason = "[banreason] (CUSTOM IP)"
+ if(bancid)
+ banreason = "[banreason] (CUSTOM CID)"
+ else
+ message_admins("Ban process: A mob matching [playermob.ckey] was found at location [playermob.x], [playermob.y], [playermob.z]. Custom ip and computer id fields replaced with the ip and computer id from the located mob")
+
+ DB_ban_record(bantype, playermob, banduration, banreason, banjob, null, banckey, banip, bancid )
+
else if(href_list["editrights"])
if(!check_rights(R_PERMISSIONS))